Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a90dcf9c-f1dd-3cbe-3e35-f86499985790@redhat.com>
Date:   Mon, 7 Aug 2023 17:22:22 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH] mm: no need to export mm_kobj
Content-Language: en-US
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>, linux-mm@kvack.org
Cc:     linux-kernel@vger.kernel.org, Mike Rapoport <rppt@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>
References: <2023080436-algebra-cabana-417d@gregkh>
From:   David Hildenbrand <david@redhat.com>
Organization: Red Hat
In-Reply-To: <2023080436-algebra-cabana-417d@gregkh>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 04.08.23 08:43, Greg Kroah-Hartman wrote:
> There are no modules using mm_kobj, so do not export it.
> 
> Cc: Mike Rapoport <rppt@kernel.org>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
>   mm/mm_init.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/mm/mm_init.c b/mm/mm_init.c
> index a1963c3322af..1c9d6f428906 100644
> --- a/mm/mm_init.c
> +++ b/mm/mm_init.c
> @@ -154,7 +154,6 @@ early_param("mminit_loglevel", set_mminit_loglevel);
>   #endif /* CONFIG_DEBUG_MEMORY_INIT */
>   
>   struct kobject *mm_kobj;
> -EXPORT_SYMBOL_GPL(mm_kobj);
>   
>   #ifdef CONFIG_SMP
>   s32 vm_committed_as_batch = 32;

Reviewed-by: David Hildenbrand <david@redhat.com>

-- 
Cheers,

David / dhildenb