Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 7 Aug 2023 18:27:28 +0300
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Petr Mladek <pmladek@suse.com>
Cc:     Marco Elver <elver@google.com>, linux-kernel@vger.kernel.org,
        kasan-dev@googlegroups.com, linux-mm@kvack.org,
        Steven Rostedt <rostedt@goodmis.org>,
        Rasmus Villemoes <linux@rasmusvillemoes.dk>,
        Sergey Senozhatsky <senozhatsky@chromium.org>,
        Alexander Potapenko <glider@google.com>,
        Dmitry Vyukov <dvyukov@google.com>,
        Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v2 3/3] lib/vsprintf: Declare no_hash_pointers in
 sprintf.h
Message-ID: <ZNENYFMHPFgQkXQK@smile.fi.intel.com>
References: <20230805175027.50029-1-andriy.shevchenko@linux.intel.com>
 <20230805175027.50029-4-andriy.shevchenko@linux.intel.com>
 <ZNEIeUOHoOIZJ6UE@alley>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZNEIeUOHoOIZJ6UE@alley>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Mon, Aug 07, 2023 at 05:06:33PM +0200, Petr Mladek wrote:
> On Sat 2023-08-05 20:50:27, Andy Shevchenko wrote:
> > Sparse is not happy to see non-static variable without declaration:
> > lib/vsprintf.c:61:6: warning: symbol 'no_hash_pointers' was not declared. Should it be static?
> > 
> > Declare respective variable in the sprintf.h. With this, add a comment
> > to discourage its use if no real need.

> If we agreed to move sprintf() declarations into printk.h
> then this might go to printk.h as well.

Sure, but I disagree with printk.h approach (as I explained why in the reply
to the suggestion).

-- 
With Best Regards,
Andy Shevchenko