Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230807130108.853357011@linutronix.de> <20230807135026.698506626@linutronix.de>
In-Reply-To: <20230807135026.698506626@linutronix.de>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Mon, 7 Aug 2023 18:24:59 +0300
Message-ID: <CAHp75VeZic8KTj5x-OFMojWB2jn4tMq9eKSWm_MeJoaO5FQOGg@mail.gmail.com>
Subject: Re: [patch 05/53] x86/apic: Get rid of get_physical_broadcast()
To:     Thomas Gleixner <tglx@linutronix.de>
Cc:     LKML <linux-kernel@vger.kernel.org>, x86@kernel.org,
        Tom Lendacky <thomas.lendacky@amd.com>,
        Andrew Cooper <andrew.cooper3@citrix.com>,
        Arjan van de Ven <arjan@linux.intel.com>,
        Huang Rui <ray.huang@amd.com>, Juergen Gross <jgross@suse.com>,
        Dimitri Sivanich <dimitri.sivanich@hpe.com>,
        Michael Kelley <mikelley@microsoft.com>,
        Sohil Mehta <sohil.mehta@intel.com>,
        K Prateek Nayak <kprateek.nayak@amd.com>,
        Kan Liang <kan.liang@linux.intel.com>,
        Zhang Rui <rui.zhang@intel.com>,
        "Paul E. McKenney" <paulmck@kernel.org>,
        Feng Tang <feng.tang@intel.com>,
        Andy Shevchenko <andy@infradead.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Aug 7, 2023 at 4:52=E2=80=AFPM Thomas Gleixner <tglx@linutronix.de>=
 wrote:
>
> There is no point for this function. The only case where this is used whe=
n

used is when

> there is no XAPIC available, which means the broadcast address is 0xF.

...

> +               if (mpc_ioapic_id(ioapic_idx) >=3D broadcast_id) {
> +                       pr_err("BIOS bug, IO-APIC#%d ID is %d in the MPC =
table!...\n",

Wouldn't it be better to switch to FW_BUG instead of the "BIOS bug,  " thin=
gy?
Same for other similar cases.

> +                              ioapic_idx, mpc_ioapic_id(ioapic_idx));
> +                       pr_err("... fixing up to %d. (tell your hw vendor=
)\n", reg_00.bits.ID);
>                         ioapics[ioapic_idx].mp_config.apicid =3D reg_00.b=
its.ID;
>                 }

...

> -       if ((boot_cpu_data.x86_vendor =3D=3D X86_VENDOR_INTEL) &&
> -           !APIC_XAPIC(boot_cpu_apic_version))
> +       if ((boot_cpu_data.x86_vendor =3D=3D X86_VENDOR_INTEL) && !APIC_X=
APIC(boot_cpu_apic_version))
>                 return io_apic_get_unique_id(idx, id);

>         else

You can also kill the redundant 'else'.

>                 return id;

--=20
With Best Regards,
Andy Shevchenko