Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230801055826.6000-1-sunran001@208suo.com>
In-Reply-To: <20230801055826.6000-1-sunran001@208suo.com>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Mon, 7 Aug 2023 12:32:14 -0400
Message-ID: <CADnq5_PJZ-vS+p8ky1C2LFPEfp6bVfTMveL7wFeKKytwvqePgw@mail.gmail.com>
Subject: Re: [PATCH] drm/amd/pm: Clean up errors in vega10_hwmgr.c
To:     Ran Sun <sunran001@208suo.com>
Cc:     alexander.deucher@amd.com, airlied@gmail.com, daniel@ffwll.ch,
        dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

This one doesn't apply due to whitespace differences.

Alex

On Tue, Aug 1, 2023 at 1:58=E2=80=AFAM Ran Sun <sunran001@208suo.com> wrote=
:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: trailing statements should be on next line
> ERROR: space required before the open brace '{'
> ERROR: space required before the open parenthesis '('
> ERROR: space required after that ',' (ctx:VxV)
>
> Signed-off-by: Ran Sun <sunran001@208suo.com>
> ---
>  .../drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c  | 18 ++++++++++++------
>  1 file changed, 12 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c b/driv=
ers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c
> index 08518bc1cbbe..ba7294daddfe 100644
> --- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c
> +++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c
> @@ -670,17 +670,23 @@ static int vega10_patch_voltage_dependency_tables_w=
ith_lookup_table(
>         for (i =3D 0; i < 6; i++) {
>                 struct phm_ppt_v1_clock_voltage_dependency_table *vdt;
>                 switch (i) {
> -               case 0: vdt =3D table_info->vdd_dep_on_socclk;
> +               case 0:
> +                       vdt =3D table_info->vdd_dep_on_socclk;
>                         break;
> -               case 1: vdt =3D table_info->vdd_dep_on_sclk;
> +               case 1:
> +                       vdt =3D table_info->vdd_dep_on_sclk;
>                         break;
> -               case 2: vdt =3D table_info->vdd_dep_on_dcefclk;
> +               case 2:
> +                       vdt =3D table_info->vdd_dep_on_dcefclk;
>                         break;
> -               case 3: vdt =3D table_info->vdd_dep_on_pixclk;
> +               case 3:
> +                       vdt =3D table_info->vdd_dep_on_pixclk;
>                         break;
> -               case 4: vdt =3D table_info->vdd_dep_on_dispclk;
> +               case 4:
> +                       vdt =3D table_info->vdd_dep_on_dispclk;
>                         break;
> -               case 5: vdt =3D table_info->vdd_dep_on_phyclk;
> +               case 5:
> +                       vdt =3D table_info->vdd_dep_on_phyclk;
>                         break;
>                 }
>
> --
> 2.17.1
>