Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230725-mmc-removable-v1-1-b2e0c4f18e6d@weissschuh.net>
In-Reply-To: <20230725-mmc-removable-v1-1-b2e0c4f18e6d@weissschuh.net>
From:   Ulf Hansson <ulf.hansson@linaro.org>
Date:   Mon, 7 Aug 2023 17:51:17 +0200
Message-ID: <CAPDyKFrWXQHWaEX5=rq-Gf5-by90iqtxWCuUu_QquRaMfhHtVw@mail.gmail.com>
Subject: Re: [PATCH] mmc: core: propagate removable attribute to driver core
To:     =?UTF-8?Q?Thomas_Wei=C3=9Fschuh?= <linux@weissschuh.net>
Cc:     linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
        Christoph Hellwig <hch@lst.de>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, 25 Jul 2023 at 16:17, Thomas Wei=C3=9Fschuh <linux@weissschuh.net> =
wrote:
>
> Userspace can use this to distinguish hotpluggable mmc devices such as
> sdcards from non-hotpluggable ones such as eMMC.
> One example is the lsblk tool from util-linux.
>
> Note that dev_set_removable() is not related to GENHD_FL_REMOVABLE which
> is not applicable as per the comment in drivers/mmc/core/block.c
>
> Link: https://github.com/util-linux/util-linux/issues/2379
> Signed-off-by: Thomas Wei=C3=9Fschuh <linux@weissschuh.net>

Applied for next, thanks!

Kind regards
Uffe


> ---
>  drivers/mmc/core/bus.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/mmc/core/bus.c b/drivers/mmc/core/bus.c
> index 2c3074a605fc..0af96548e7da 100644
> --- a/drivers/mmc/core/bus.c
> +++ b/drivers/mmc/core/bus.c
> @@ -310,6 +310,9 @@ int mmc_add_card(struct mmc_card *card)
>
>
>         dev_set_name(&card->dev, "%s:%04x", mmc_hostname(card->host), car=
d->rca);
> +       dev_set_removable(&card->dev,
> +                         mmc_card_is_removable(card->host) ?
> +                         DEVICE_REMOVABLE : DEVICE_FIXED);
>
>         switch (card->type) {
>         case MMC_TYPE_MMC:
>
> ---
> base-commit: 0b5547c51827e053cc754db47d3ec3e6c2c451d2
> change-id: 20230725-mmc-removable-5cfdca9ed062
>
> Best regards,
> --
> Thomas Wei=C3=9Fschuh <linux@weissschuh.net>
>