Received: by 2002:a05:6359:6284:b0:131:369:b2a3 with SMTP id se4csp3218759rwb; Mon, 7 Aug 2023 09:55:31 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE4+GLDAqXfOs36k/7ysXO9xYs4vezTZtRPStfOSc8DP7txoJTCVJzeiM2DYfeEpNGm8vmP X-Received: by 2002:a17:902:f687:b0:1bb:f82f:fb93 with SMTP id l7-20020a170902f68700b001bbf82ffb93mr9138324plg.2.1691427330895; Mon, 07 Aug 2023 09:55:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691427330; cv=none; d=google.com; s=arc-20160816; b=QO//E+edzGQO2CNJfC45EEXk+4xYP5PsoE7Zxz1Ygumuvfw3fmXrubmg76lhIBJuZU /mOS0pm7zVaS1NCVUSUZD4NEJ8A6nywKBZK4N+yTTxqu2TA1cNZ2PcXC3zDs0GZm+39D 6sQnkCeWMhY+9Ov8CACerhHXhMrglLWULpmpNLEu4vVcxY6CH81zKLJ8bkxZOAit3uot wLi3z/X3YzocBmE/lSMD+NQGsyA/Rzd15S4CGxQ0jgzqKNVwYZvaT6FOIaYeA9A6pPP0 g4F8voDaeFt2IGusnqg7OgU0XUyx8VX4k91U595OsDvSZBstLhC+p3538AmjSRFARLWE Viyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=yim2L/qS43lchYXXHhjo17soDy/nlYWWk9HEUuy25oY=; fh=BAKkgipyos0M+GzVrQlMkJm8WUsN55A8R0UYklktQMk=; b=Du1Kpoc4/twCXSLSXHF7CaYhxQpeHnWyAWpdnti+/N+Ntavtl9KXJIygfzVpkb2pqI vcxooP0vXF/CsbC+j5OmNp4QkhG+CK5gSx81pIXmnm63b2BmzczHw7gVbvUKMab8Z1iF 54C7ePHNmWS5wDSooHFyGceAnjz0O4p31w/EYVInVIs1782jKAHPWiaD5dKnM8wS2e3N rQu6q8p965YNeVaIm3dNRZXm/bcSmL2CCb/xcj4fjiMvZzBv2pSM1UGZqe3EiKTrMjHL qsLahp6Okag50IZYRm04jQKd80GhzioZ7rSk3xF4Y/NGboYu81Ux1ivBS89hhyOEyqR+ e0gw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=df8RW7KA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id kv5-20020a17090328c500b001bbb8ebedddsi5881613plb.561.2023.08.07.09.55.18; Mon, 07 Aug 2023 09:55:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=df8RW7KA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231708AbjHGQhw (ORCPT + 99 others); Mon, 7 Aug 2023 12:37:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46172 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231495AbjHGQhv (ORCPT ); Mon, 7 Aug 2023 12:37:51 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F0FE2210C; Mon, 7 Aug 2023 09:37:30 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D254761F4D; Mon, 7 Aug 2023 16:37:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D62CFC433C8; Mon, 7 Aug 2023 16:37:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691426249; bh=kbR6aj7kA3a7cg6V1v3m4G4EXk5m/YqvQ/TjuNc6zMI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=df8RW7KAq8T9W0DcXonq+k1G0ctjiNzY7qo5gIssck/dkQ/ZCOq8HrL6MP7gyAxDO xII3nFOUVxfJfx6yOMVyuyMLlfSp4NOyZlvLRDDSHNj7SrIO2K6dI6aS/nTtraBcw9 hu6y2RGd7htd5QcOYE5YWd129UFltG2/ulafQRcuzaZLfhD1+Y7BffGZsvikZf0fNa XpqG80NDxc5JPameLByWC4RPYINdSAW+KcAS5OURx0wiU2Ej9W2Xu+x5E1xeCHVM3U gxNAMR9P+TkIZZYI+b/VvCr9ciWidcDRCsn0irqKo4Rn0phLfCo4fL23BWYuC/0afI WwVnuk53rqdmg== Date: Mon, 7 Aug 2023 09:37:27 -0700 From: Jakub Kicinski To: Hayes Wang Cc: "Limonciello, Mario" , "edumazet@google.com" , LKML , "netdev@vger.kernel.org" , "davem@davemloft.net" , "linux-usb@vger.kernel.org" , "pabeni@redhat.com" , Paul Menzel Subject: Re: Error 'netif_napi_add_weight() called with weight 256' Message-ID: <20230807093727.5249f517@kernel.org> In-Reply-To: <8fcbab1aa2e14262bea79222bf7a4976@realtek.com> References: <0bfd445a-81f7-f702-08b0-bd5a72095e49@amd.com> <20230731111330.5211e637@kernel.org> <673bc252-2b34-6ef9-1765-9c7cac1e8658@amd.com> <8fcbab1aa2e14262bea79222bf7a4976@realtek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 7 Aug 2023 09:57:15 +0000 Hayes Wang wrote: > > Perhaps Hayes Wang can comment on this (as the author of 195aae321c82). > > I test our devices on an Embedded system. > We find the throughput is low. > And it is caused by the weight. > Our NAPI function often uses the whole budget. > Finally, we increase the weight, and the throughput is good. Could it possibly be related to handling of aggregation? Problem must lay somewhere in USB specifics, since as I said there are 100Gbps devices running fine with budget of 64.