Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230801014318.4097-1-sunran001@208suo.com>
In-Reply-To: <20230801014318.4097-1-sunran001@208suo.com>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Mon, 7 Aug 2023 12:20:12 -0400
Message-ID: <CADnq5_PAgA958H9gx97k1eUXedNpcP8YtmuFihQPJc=ximkFvQ@mail.gmail.com>
Subject: Re: [PATCH] drm/amd/pm: Clean up errors in smu_v13_0.c
To:     Ran Sun <sunran001@208suo.com>
Cc:     alexander.deucher@amd.com, airlied@gmail.com, daniel@ffwll.ch,
        dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Applied.  Thanks!

On Mon, Jul 31, 2023 at 9:43=E2=80=AFPM Ran Sun <sunran001@208suo.com> wrot=
e:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: space required before the open parenthesis '('
> ERROR: that open brace { should be on the previous line
>
> Signed-off-by: Ran Sun <sunran001@208suo.com>
> ---
>  drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c b/drivers/gpu=
/drm/amd/pm/swsmu/smu13/smu_v13_0.c
> index 9b62b45ebb7f..895cda8e6934 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c
> +++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c
> @@ -1121,7 +1121,7 @@ smu_v13_0_display_clock_voltage_request(struct smu_=
context *smu,
>
>                 ret =3D smu_v13_0_set_hard_freq_limited_range(smu, clk_se=
lect, clk_freq, 0);
>
> -               if(clk_select =3D=3D SMU_UCLK)
> +               if (clk_select =3D=3D SMU_UCLK)
>                         smu->hard_min_uclk_req_from_dal =3D clk_freq;
>         }
>
> @@ -1437,8 +1437,7 @@ static int smu_v13_0_irq_process(struct amdgpu_devi=
ce *adev,
>         return 0;
>  }
>
> -static const struct amdgpu_irq_src_funcs smu_v13_0_irq_funcs =3D
> -{
> +static const struct amdgpu_irq_src_funcs smu_v13_0_irq_funcs =3D {
>         .set =3D smu_v13_0_set_irq_state,
>         .process =3D smu_v13_0_irq_process,
>  };
> @@ -1933,7 +1932,7 @@ static int smu_v13_0_get_dpm_level_count(struct smu=
_context *smu,
>
>         ret =3D smu_v13_0_get_dpm_freq_by_index(smu, clk_type, 0xff, valu=
e);
>         /* SMU v13.0.2 FW returns 0 based max level, increment by one for=
 it */
> -       if((smu->adev->ip_versions[MP1_HWIP][0] =3D=3D IP_VERSION(13, 0, =
2)) && (!ret && value))
> +       if ((smu->adev->ip_versions[MP1_HWIP][0] =3D=3D IP_VERSION(13, 0,=
 2)) && (!ret && value))
>                 ++(*value);
>
>         return ret;
> --
> 2.17.1
>