Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230801012608.4003-1-sunran001@208suo.com>
In-Reply-To: <20230801012608.4003-1-sunran001@208suo.com>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Mon, 7 Aug 2023 12:19:14 -0400
Message-ID: <CADnq5_OzhDL6tfu2HH2SDEQOnPukvoM0fPm3NN9ORSqOxrq1Wg@mail.gmail.com>
Subject: Re: [PATCH] drm/amd/pm: Clean up errors in smu_v13_0_7_ppt.c
To:     Ran Sun <sunran001@208suo.com>
Cc:     apw@canonical.com, joe@perches.com, alexander.deucher@amd.com,
        bpf@vger.kernel.org, dri-devel@lists.freedesktop.org,
        amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Applied.  Thanks!

On Mon, Jul 31, 2023 at 9:26=E2=80=AFPM Ran Sun <sunran001@208suo.com> wrot=
e:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: open brace '{' following struct go on the same line
> ERROR: spaces required around that '=3D' (ctx:VxW)
> ERROR: that open brace { should be on the previous line
>
> Signed-off-by: Ran Sun <sunran001@208suo.com>
> ---
>  drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c | 10 ++++------
>  1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c b/drive=
rs/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c
> index b1f0937ccade..26ba51ec0567 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c
> +++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c
> @@ -386,8 +386,7 @@ static int smu_v13_0_7_check_fw_status(struct smu_con=
text *smu)
>  }
>
>  #ifndef atom_smc_dpm_info_table_13_0_7
> -struct atom_smc_dpm_info_table_13_0_7
> -{
> +struct atom_smc_dpm_info_table_13_0_7 {
>         struct atom_common_table_header table_header;
>         BoardTable_t BoardTable;
>  };
> @@ -494,7 +493,7 @@ static int smu_v13_0_7_tables_init(struct smu_context=
 *smu)
>                        PAGE_SIZE, AMDGPU_GEM_DOMAIN_VRAM);
>         SMU_TABLE_INIT(tables, SMU_TABLE_ACTIVITY_MONITOR_COEFF,
>                        sizeof(DpmActivityMonitorCoeffIntExternal_t), PAGE=
_SIZE,
> -                      AMDGPU_GEM_DOMAIN_VRAM);
> +                      AMDGPU_GEM_DOMAIN_VRAM);
>         SMU_TABLE_INIT(tables, SMU_TABLE_COMBO_PPTABLE, MP0_MP1_DATA_REGI=
ON_SIZE_COMBOPPTABLE,
>                         PAGE_SIZE, AMDGPU_GEM_DOMAIN_VRAM);
>
> @@ -728,7 +727,7 @@ static int smu_v13_0_7_get_smu_metrics_data(struct sm=
u_context *smu,
>                                             MetricsMember_t member,
>                                             uint32_t *value)
>  {
> -       struct smu_table_context *smu_table=3D &smu->smu_table;
> +       struct smu_table_context *smu_table =3D &smu->smu_table;
>         SmuMetrics_t *metrics =3D
>                 &(((SmuMetricsExternal_t *)(smu_table->metrics_table))->S=
muMetrics);
>         int ret =3D 0;
> @@ -1635,8 +1634,7 @@ static int smu_v13_0_7_force_clk_levels(struct smu_=
context *smu,
>         return ret;
>  }
>
> -static const struct smu_temperature_range smu13_thermal_policy[] =3D
> -{
> +static const struct smu_temperature_range smu13_thermal_policy[] =3D {
>         {-273150,  99000, 99000, -273150, 99000, 99000, -273150, 99000, 9=
9000},
>         { 120000, 120000, 120000, 120000, 120000, 120000, 120000, 120000,=
 120000},
>  };
> --
> 2.17.1
>