Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230801020052.4192-1-sunran001@208suo.com>
In-Reply-To: <20230801020052.4192-1-sunran001@208suo.com>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Mon, 7 Aug 2023 12:20:53 -0400
Message-ID: <CADnq5_O9oAvxwcd5x5aAiXbDF36GeO6hnRGySr0rkHcXWtMXUw@mail.gmail.com>
Subject: Re: [PATCH] drm/amd/pm: Clean up errors in aldebaran_ppt.c
To:     Ran Sun <sunran001@208suo.com>
Cc:     alexander.deucher@amd.com, airlied@gmail.com, daniel@ffwll.ch,
        dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Applied.  Thanks!

On Mon, Jul 31, 2023 at 10:01=E2=80=AFPM Ran Sun <sunran001@208suo.com> wro=
te:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: that open brace { should be on the previous line
> ERROR: space required after that ',' (ctx:VxV)
> ERROR: spaces required around that '=3D' (ctx:VxW)
> ERROR: else should follow close brace '}'
>
> Signed-off-by: Ran Sun <sunran001@208suo.com>
> ---
>  drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c | 12 +++++-------
>  1 file changed, 5 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c b/drivers=
/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c
> index ce50ef46e73f..8f26123ac703 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c
> +++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c
> @@ -94,8 +94,7 @@
>   */
>  #define SUPPORT_BAD_CHANNEL_INFO_MSG_VERSION 0x00443300
>
> -static const struct smu_temperature_range smu13_thermal_policy[] =3D
> -{
> +static const struct smu_temperature_range smu13_thermal_policy[] =3D {
>         {-273150,  99000, 99000, -273150, 99000, 99000, -273150, 99000, 9=
9000},
>         { 120000, 120000, 120000, 120000, 120000, 120000, 120000, 120000,=
 120000},
>  };
> @@ -196,7 +195,7 @@ static const struct cmn2asic_mapping aldebaran_featur=
e_mask_map[SMU_FEATURE_COUN
>         ALDEBARAN_FEA_MAP(SMU_FEATURE_FW_CTF_BIT,                        =
       FEATURE_FW_CTF_BIT),
>         ALDEBARAN_FEA_MAP(SMU_FEATURE_THERMAL_BIT,                       =
       FEATURE_THERMAL_BIT),
>         ALDEBARAN_FEA_MAP(SMU_FEATURE_OUT_OF_BAND_MONITOR_BIT,  FEATURE_O=
UT_OF_BAND_MONITOR_BIT),
> -       ALDEBARAN_FEA_MAP(SMU_FEATURE_XGMI_PER_LINK_PWR_DWN_BIT,FEATURE_X=
GMI_PER_LINK_PWR_DWN),
> +       ALDEBARAN_FEA_MAP(SMU_FEATURE_XGMI_PER_LINK_PWR_DWN_BIT, FEATURE_=
XGMI_PER_LINK_PWR_DWN),
>         ALDEBARAN_FEA_MAP(SMU_FEATURE_DF_CSTATE_BIT,                    F=
EATURE_DF_CSTATE),
>  };
>
> @@ -580,7 +579,7 @@ static int aldebaran_get_smu_metrics_data(struct smu_=
context *smu,
>                                           MetricsMember_t member,
>                                           uint32_t *value)
>  {
> -       struct smu_table_context *smu_table=3D &smu->smu_table;
> +       struct smu_table_context *smu_table =3D &smu->smu_table;
>         SmuMetrics_t *metrics =3D (SmuMetrics_t *)smu_table->metrics_tabl=
e;
>         int ret =3D 0;
>
> @@ -1906,8 +1905,7 @@ static int aldebaran_mode1_reset(struct smu_context=
 *smu)
>         smu_cmn_get_smc_version(smu, NULL, &smu_version);
>         if (smu_version < 0x00440700) {
>                 ret =3D smu_cmn_send_smc_msg(smu, SMU_MSG_Mode1Reset, NUL=
L);
> -       }
> -       else {
> +       } else {
>                 /* fatal error triggered by ras, PMFW supports the flag
>                    from 68.44.0 */
>                 if ((smu_version >=3D 0x00442c00) && ras &&
> @@ -2116,7 +2114,7 @@ static const struct pptable_funcs aldebaran_ppt_fun=
cs =3D {
>         .register_irq_handler =3D smu_v13_0_register_irq_handler,
>         .set_azalia_d3_pme =3D smu_v13_0_set_azalia_d3_pme,
>         .get_max_sustainable_clocks_by_dc =3D smu_v13_0_get_max_sustainab=
le_clocks_by_dc,
> -       .baco_is_support=3D aldebaran_is_baco_supported,
> +       .baco_is_support =3D aldebaran_is_baco_supported,
>         .get_dpm_ultimate_freq =3D smu_v13_0_get_dpm_ultimate_freq,
>         .set_soft_freq_limited_range =3D aldebaran_set_soft_freq_limited_=
range,
>         .od_edit_dpm_table =3D aldebaran_usr_edit_dpm_table,
> --
> 2.17.1
>