Received: by 2002:a05:6359:6284:b0:131:369:b2a3 with SMTP id se4csp3234322rwb; Mon, 7 Aug 2023 10:07:08 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFD5AkUdL8qy49asMJDl2s45LGNRio8Q3B9s3KSRDP9XyKSjpko4+rHh874Tvw9qStUgJet X-Received: by 2002:a17:903:188:b0:1bb:3498:9caa with SMTP id z8-20020a170903018800b001bb34989caamr13016564plg.58.1691428027768; Mon, 07 Aug 2023 10:07:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691428027; cv=none; d=google.com; s=arc-20160816; b=gUA/UYpyo2DWfH3al19nv62I1gP36oIvqxW5Oqtah196nHIcRYfHcm6MyCJnkbPX/Q AwY80LZ+pRc1dK9Gbn8/GEBNVnFXn1Y/0G3dWE6d+rn81cCy2xq0aS0QECTUBiMrpGYm PiPFeb8hCC+4rNeQ/2jocqLzpf5aDSg38aBSv/ZRZ1mAvUNZTm6MtOM5vp47l8GMoedO C/WqOa4d9tW8CuKKy7q5CVzaBooHmA24unKfH4gq/ZqV2sCmNTvkKZ8M7H0tKnBWp49d WgrN4NDYrU95q+WgnNicT3GbuAC+1YDn/BscftUKFCxx1t1fMInCYqbmGSbie2H/+ywd P3GQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=L7MLgX//c9aErISuUZEec4pqzAsW+rw0jQNMnk+tMag=; fh=t+hei0m6FWvWE3h8ROlSj5pw/xTY3yBXufxuldTsP1A=; b=zOAlnPAK6Km9q1iW8eRafJn9YF3Dz4gwb7qcuq5tZO6ZjDQgrTXphmseHcALrvcB8E 4S8n/RNvlg6Q8rlHna3fpXspzacPf5JttG4ia0SWZbErzSajvBY9bKwbebZWs8o24mhk 21rDoTSWVNULaLpt1xAbAOBXcaB1aBbtfwt0mrhBXMBaOidZZL7zEsACPXw1tnPFT4Pb dK2NbEuJr9anYZbiUOagFPG0OW+GGyUD5jUoa0zstAyACbXQhsHWkNOZnb39OpHUas/5 rssQc6haDLKi7tq6sDMOp97ouDZmeNTfRL/5drqgVGdq4jl8C2Be0liXC4wbZfX08uaG NuSg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=YTfBQIIP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t1-20020a1709027fc100b001bbaa5e95fdsi5821023plb.102.2023.08.07.10.06.54; Mon, 07 Aug 2023 10:07:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=YTfBQIIP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230079AbjHGQYB (ORCPT + 99 others); Mon, 7 Aug 2023 12:24:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58640 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231500AbjHGQX6 (ORCPT ); Mon, 7 Aug 2023 12:23:58 -0400 Received: from mail-ot1-x336.google.com (mail-ot1-x336.google.com [IPv6:2607:f8b0:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F182E173D for ; Mon, 7 Aug 2023 09:23:32 -0700 (PDT) Received: by mail-ot1-x336.google.com with SMTP id 46e09a7af769-6bcccbd9365so3641702a34.2 for ; Mon, 07 Aug 2023 09:23:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691425386; x=1692030186; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=L7MLgX//c9aErISuUZEec4pqzAsW+rw0jQNMnk+tMag=; b=YTfBQIIP3baZBzHLZfZAMXXo1vU4qQaj4/9FJAZ5yCXXUFTOmBSm5XOSFICbcXZN34 cr4MqOZpTff4/J6LFvhwCPmHLfyAC/y3y9pB3W1oUiWI3YTqzj/zezcF/tDCrrGdxAsX QbLxFWWYIWY9uqW4feTfYHsMF8/iWFW+Ujq7V08hj974ZQWAk9xMlzEO8CaSbm139ZHK 0hHba4i4DViLEzTdrUQpKuaoAAw0HilZqSTPJ/lc2gVUk6B0cJTENI7FomaHjao9vs5h 7YrsUvOXPQepjT6wKL/PgoViCoa7EmoIVXlgnX56+SFK9nMsecw44IMBrg39+2nhMUJJ rTyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691425386; x=1692030186; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=L7MLgX//c9aErISuUZEec4pqzAsW+rw0jQNMnk+tMag=; b=Qd/lViKJCTs4uwQ5Mpwwi/vecwJNzfWj/TvR1JK9GhhkxGwK56ejIqcbX6gajIHJLz 3xC5zPV81XxWJK2Tf+Mtl3qSw6RoDK4SEKXD2n9iC4nNy3COjaN4xYSmAaq794WU9Fn6 wrd83fMV3XlsVOX2P58YwmrnBMz0KI1ankXEkMPdid8Jn0gscNbYH4DuIH2mHcNszJIw rkKbCleJWHnnTd1Hqpec2uPE4lNp8wZBrX0V9fVLazGw8ZC9ZFcQ+8fWWJQj+o9m7ikE Q5mFcuXNs8+UxN5SuRQGwAD4zBNCl0de7ogunYF4PbriYSM5p4FbxxlpyLhB3Rj27x9f wjsw== X-Gm-Message-State: AOJu0YxZ+zUMR93NopURdBFLxatQDxotT7hLmySLEpsYLTsbqiYFciE1 Y7v3o7hx4QcLA1AQjqjjoo7D6uuUtY1Rq6Ko8N0= X-Received: by 2002:a05:6870:d611:b0:1bf:7b3:5116 with SMTP id a17-20020a056870d61100b001bf07b35116mr12624311oaq.47.1691425386563; Mon, 07 Aug 2023 09:23:06 -0700 (PDT) MIME-Version: 1.0 References: <20230801021129.4458-1-sunran001@208suo.com> In-Reply-To: <20230801021129.4458-1-sunran001@208suo.com> From: Alex Deucher Date: Mon, 7 Aug 2023 12:22:55 -0400 Message-ID: Subject: Re: [PATCH] drm/amd: Clean up errors in smu_v13_0_5_ppt.c To: Ran Sun Cc: alexander.deucher@amd.com, airlied@gmail.com, daniel@ffwll.ch, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Applied. Thanks! On Mon, Jul 31, 2023 at 10:11=E2=80=AFPM Ran Sun wro= te: > > Fix the following errors reported by checkpatch: > > ERROR: space prohibited before that ',' (ctx:WxW) > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/pm/swsmu/smu_internal.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu_internal.h b/drivers/gpu/dr= m/amd/pm/swsmu/smu_internal.h > index ceb13c838067..bcc42abfc768 100644 > --- a/drivers/gpu/drm/amd/pm/swsmu/smu_internal.h > +++ b/drivers/gpu/drm/amd/pm/swsmu/smu_internal.h > @@ -61,14 +61,14 @@ > #define smu_feature_get_enabled_mask(smu, mask) = smu_ppt_funcs(get_enabled_mask, -EOPNOTSUPP, smu, mask) > #define smu_feature_is_enabled(smu, mask) s= mu_ppt_funcs(feature_is_enabled, 0, smu, mask) > #define smu_disable_all_features_with_exception(smu, mask) s= mu_ppt_funcs(disable_all_features_with_exception, 0, smu, mask) > -#define smu_is_dpm_running(smu) = smu_ppt_funcs(is_dpm_running, 0 , smu) > +#define smu_is_dpm_running(smu) = smu_ppt_funcs(is_dpm_running, 0, smu) > #define smu_notify_display_change(smu) s= mu_ppt_funcs(notify_display_change, 0, smu) > #define smu_populate_umd_state_clk(smu) = smu_ppt_funcs(populate_umd_state_clk, 0, smu) > #define smu_enable_thermal_alert(smu) s= mu_ppt_funcs(enable_thermal_alert, 0, smu) > #define smu_disable_thermal_alert(smu) s= mu_ppt_funcs(disable_thermal_alert, 0, smu) > #define smu_smc_read_sensor(smu, sensor, data, size) s= mu_ppt_funcs(read_sensor, -EINVAL, smu, sensor, data, size) > #define smu_pre_display_config_changed(smu) s= mu_ppt_funcs(pre_display_config_changed, 0, smu) > -#define smu_display_config_changed(smu) = smu_ppt_funcs(display_config_changed, 0 , smu) > +#define smu_display_config_changed(smu) = smu_ppt_funcs(display_config_changed, 0, smu) > #define smu_apply_clocks_adjust_rules(smu) s= mu_ppt_funcs(apply_clocks_adjust_rules, 0, smu) > #define smu_notify_smc_display_config(smu) s= mu_ppt_funcs(notify_smc_display_config, 0, smu) > #define smu_run_btc(smu) s= mu_ppt_funcs(run_btc, 0, smu) > -- > 2.17.1 >