Received: by 2002:a05:6359:6284:b0:131:369:b2a3 with SMTP id se4csp3238437rwb; Mon, 7 Aug 2023 10:10:23 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGeL9w+m0Lm35h4C5pOuVQX8P6SDEYUPxxPv23xi6SuUSJXcpeVPMH/oT7PQaplpjW4caCN X-Received: by 2002:a17:903:248:b0:1b9:cf52:2bcf with SMTP id j8-20020a170903024800b001b9cf522bcfmr11816545plh.0.1691428223141; Mon, 07 Aug 2023 10:10:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691428223; cv=none; d=google.com; s=arc-20160816; b=lXdM0pRauk8ZrBvP5VnJVMzPNTF4kT4xCFajSzLb4IN5DJnCVG9+srkhg/wWMBCXhK 3ZvmnoZ94pImIPv8mnvrv23PhBteaqTQmUIodIGkQMpaCE6wVoto1CozZTUF5L/sY5jE lMtkVDRRn+4lUNjKroLmqtcFqM/soyhos32DpwBT4BaH2yAea5RMms77rNjmSFCyOwur uOzOZDPUE27RVMQFIzfnW/xu3Z1itbmA6EQJRES373lA2Tnr4QvASNEe8fGJ3yjdj2y+ jKg9aST1ldkgwiThckIXehWEK3nWz2Te3hPvd1WdEWZNNNPa8EB8JeA2A1hG3KcBKoOH SHxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=cEo7+Ascz0KNSk9INnQbYGEQxveiVHgJH2kyMj5CRE4=; fh=avicz4Od8aHm36toWW/NSm5QKN7bmMP1iLyRgm+nfx0=; b=B5TX39GE2p1stkYVPNe1loZ56t25u17Kid89z4Z08NrsTKCmkGov1O2WxzuCigCqUL 2tDTZjYcrwHtL/MAidBfPxJjyDKezMDBkKPCNlSz5jIi34wRPonCGgcuM0h3qVa3mKQI MfOod3DEnUWdPGpHvmtAyhqe1mzeZIk4DxoxUBPNgG4zpTuyEW/9uBiUtt/hEPAlMINB nBppeFLixobspNe7AajKJpU8ih9Qn/yoBP42do5h0IsSjO8LrOzCFml/3epTVTq0C08r Sf631tSNQq8WywaOJ+jZMinZKPng5Gki83ul7K2Q5bPM7fMdX1p7pthpCCT/my/nq5Zl jYng== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=nkrbVUn1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q22-20020a170902789600b001ab1d1a6802si3829899pll.1.2023.08.07.10.10.09; Mon, 07 Aug 2023 10:10:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=nkrbVUn1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229887AbjHGP4Z (ORCPT + 99 others); Mon, 7 Aug 2023 11:56:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44390 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229491AbjHGP4X (ORCPT ); Mon, 7 Aug 2023 11:56:23 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F3720F0; Mon, 7 Aug 2023 08:56:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1691423782; x=1722959782; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=udsAEu9C41dvA0CswFSJhLFhNgvz1he+2g/uOtdU38Y=; b=nkrbVUn1NPyvTBU38sHTs9MTkQKz1hyxCJXXdrqlLUwDFQKbwqrdIIMP Dd/cubs5Acw42DKbeqFNj6jF+QEMjn7mDqQiP7f2AkZ2IbSgFNbch8dcd jiwxec9VBDbsqawMYKIkqeXAEpUEI0KK4WrqbKdMQvRAUxCMyKnRtkp4i b8Ud+4WLQPX2uVHn2Ybfhk2pSs8ffeaQrry+NSf9j1C2EGzgK4tqZ2XtJ tGkCJrqhcPEDzOsJwYEQZcShpNQHz9OG8lbZw0tnn/SuRS+Aj3mGuCbsP zVQ5zOdpvwB4LoKn+1i61JNJlH1puyKpVG3uasX038otnEqaN35U8J2Kq g==; X-IronPort-AV: E=McAfee;i="6600,9927,10795"; a="456965930" X-IronPort-AV: E=Sophos;i="6.01,262,1684825200"; d="scan'208";a="456965930" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Aug 2023 08:56:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10795"; a="724559351" X-IronPort-AV: E=Sophos;i="6.01,262,1684825200"; d="scan'208";a="724559351" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga007.jf.intel.com with ESMTP; 07 Aug 2023 08:56:16 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qT2ac-000kTr-36; Mon, 07 Aug 2023 18:56:14 +0300 Date: Mon, 7 Aug 2023 18:56:14 +0300 From: Andy Shevchenko To: xingtong_wu@163.com Cc: ilpo.jarvinen@linux.intel.com, hdegoede@redhat.com, markgross@kernel.org, xingtong.wu@siemens.com, lee@kernel.org, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, gerd.haeussler.ext@siemens.com, tobias.schaffner@siemens.com, lkp@intel.com Subject: Re: [PATCH v2 1/2] platform/x86/siemens: simatic-ipc: fix logic error in BX-59A Message-ID: References: <7196d4b9-34fe-4a18-863b-65d07c4a348c@linux.intel.com> <20430731173026.2631-1-xingtong_wu@163.com> <20430731173026.2631-2-xingtong_wu@163.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20430731173026.2631-2-xingtong_wu@163.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Aug 01, 2043 at 01:30:26AM +0800, xingtong_wu@163.com wrote: > From: "xingtong.wu" > > The variable "ledmode" is missing from if statement that leads to > a logical error. Add the missing variable to the if condition. > > Fixes: b8af77951941 ("platform/x86/siemens: simatic-ipc: add new models BX-56A/BX-59A") > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-kbuild-all/202307312322.Aa8upHWK-lkp@intel.com/ > Blank lines are not allowed in the tag block. > Signed-off-by: xingtong.wu -- With Best Regards, Andy Shevchenko