Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230801060937.6178-1-sunran001@208suo.com>
In-Reply-To: <20230801060937.6178-1-sunran001@208suo.com>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Mon, 7 Aug 2023 12:33:26 -0400
Message-ID: <CADnq5_MbgT64L+7ga8zzTrNJ1G0TvMFV4BPw5Lv9gDFfNCukMw@mail.gmail.com>
Subject: Re: [PATCH] drm/amd/pm: Clean up errors in vega12_baco.c
To:     Ran Sun <sunran001@208suo.com>
Cc:     alexander.deucher@amd.com, airlied@gmail.com, daniel@ffwll.ch,
        dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Applied.  Thanks!

On Tue, Aug 1, 2023 at 2:09=E2=80=AFAM Ran Sun <sunran001@208suo.com> wrote=
:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: that open brace { should be on the previous line
>
> Signed-off-by: Ran Sun <sunran001@208suo.com>
> ---
>  drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega12_baco.c | 12 ++++--------
>  1 file changed, 4 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega12_baco.c b/drive=
rs/gpu/drm/amd/pm/powerplay/hwmgr/vega12_baco.c
> index bc53cce4f32d..32cc8de296e4 100644
> --- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega12_baco.c
> +++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega12_baco.c
> @@ -29,16 +29,14 @@
>  #include "vega12_ppsmc.h"
>  #include "vega12_baco.h"
>
> -static const struct soc15_baco_cmd_entry  pre_baco_tbl[] =3D
> -{
> +static const struct soc15_baco_cmd_entry  pre_baco_tbl[] =3D {
>         { CMD_READMODIFYWRITE, NBIF_HWID, 0, mmBIF_DOORBELL_CNTL_BASE_IDX=
, mmBIF_DOORBELL_CNTL, BIF_DOORBELL_CNTL__DOORBELL_MONITOR_EN_MASK, BIF_DOO=
RBELL_CNTL__DOORBELL_MONITOR_EN__SHIFT, 0, 0 },
>         { CMD_WRITE, NBIF_HWID, 0, mmBIF_FB_EN_BASE_IDX, mmBIF_FB_EN, 0, =
0, 0, 0 },
>         { CMD_READMODIFYWRITE, NBIF_HWID, 0, mmRCC_BACO_CNTL_MISC_BASE_ID=
X, mmBACO_CNTL, BACO_CNTL__BACO_DSTATE_BYPASS_MASK, BACO_CNTL__BACO_DSTATE_=
BYPASS__SHIFT, 0, 1 },
>         { CMD_READMODIFYWRITE, NBIF_HWID, 0, mmRCC_BACO_CNTL_MISC_BASE_ID=
X, mmBACO_CNTL, BACO_CNTL__BACO_RST_INTR_MASK_MASK, BACO_CNTL__BACO_RST_INT=
R_MASK__SHIFT, 0, 1 }
>  };
>
> -static const struct soc15_baco_cmd_entry enter_baco_tbl[] =3D
> -{
> +static const struct soc15_baco_cmd_entry enter_baco_tbl[] =3D {
>         { CMD_WAITFOR, THM_HWID, 0, mmTHM_BACO_CNTL_BASE_IDX, mmTHM_BACO_=
CNTL, THM_BACO_CNTL__SOC_DOMAIN_IDLE_MASK, THM_BACO_CNTL__SOC_DOMAIN_IDLE__=
SHIFT, 0xffffffff, 0x80000000 },
>         { CMD_READMODIFYWRITE, NBIF_HWID, 0, mmRCC_BACO_CNTL_MISC_BASE_ID=
X, mmBACO_CNTL, BACO_CNTL__BACO_EN_MASK, BACO_CNTL__BACO_EN__SHIFT, 0, 1 },
>         { CMD_READMODIFYWRITE, NBIF_HWID, 0, mmRCC_BACO_CNTL_MISC_BASE_ID=
X, mmBACO_CNTL, BACO_CNTL__BACO_BIF_LCLK_SWITCH_MASK, BACO_CNTL__BACO_BIF_L=
CLK_SWITCH__SHIFT, 0, 1 },
> @@ -56,8 +54,7 @@ static const struct soc15_baco_cmd_entry enter_baco_tbl=
[] =3D
>         { CMD_WAITFOR, NBIF_HWID, 0, mmRCC_BACO_CNTL_MISC_BASE_IDX, mmBAC=
O_CNTL, BACO_CNTL__BACO_MODE_MASK, BACO_CNTL__BACO_MODE__SHIFT, 0xffffffff,=
 0x100 }
>  };
>
> -static const struct soc15_baco_cmd_entry exit_baco_tbl[] =3D
> -{
> +static const struct soc15_baco_cmd_entry exit_baco_tbl[] =3D {
>         { CMD_READMODIFYWRITE, NBIF_HWID, 0, mmRCC_BACO_CNTL_MISC_BASE_ID=
X, mmBACO_CNTL, BACO_CNTL__BACO_POWER_OFF_MASK, BACO_CNTL__BACO_POWER_OFF__=
SHIFT, 0, 0 },
>         { CMD_DELAY_MS, 0, 0, 0, 0, 0, 0, 10, 0 },
>         { CMD_READMODIFYWRITE, THM_HWID, 0, mmTHM_BACO_CNTL_BASE_IDX, mmT=
HM_BACO_CNTL, THM_BACO_CNTL__BACO_SOC_REFCLK_OFF_MASK, THM_BACO_CNTL__BACO_=
SOC_REFCLK_OFF__SHIFT, 0, 0 },
> @@ -77,8 +74,7 @@ static const struct soc15_baco_cmd_entry exit_baco_tbl[=
] =3D
>         { CMD_WAITFOR, NBIF_HWID, 0, mmRCC_BACO_CNTL_MISC_BASE_IDX, mmBAC=
O_CNTL, BACO_CNTL__BACO_MODE_MASK, 0, 0xffffffff, 0 }
>  };
>
> -static const struct soc15_baco_cmd_entry clean_baco_tbl[] =3D
> -{
> +static const struct soc15_baco_cmd_entry clean_baco_tbl[] =3D {
>         { CMD_WRITE, NBIF_HWID, 0, mmBIOS_SCRATCH_6_BASE_IDX, mmBIOS_SCRA=
TCH_6, 0, 0, 0, 0 },
>         { CMD_WRITE, NBIF_HWID, 0, mmBIOS_SCRATCH_7_BASE_IDX, mmBIOS_SCRA=
TCH_7, 0, 0, 0, 0 }
>  };
> --
> 2.17.1
>