Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <08ff46b0-09e6-fd04-afee-99ccc1d9274b@ti.com>
Date:   Mon, 7 Aug 2023 10:37:49 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH] reset: ti: syscon: remove unneeded call to
 platform_set_drvdata()
Content-Language: en-US
To:     Alexandru Ardelean <alex@shruggie.ro>,
        Andrei Coardos <aboutphysycs@gmail.com>
CC:     <linux-kernel@vger.kernel.org>, <p.zabel@pengutronix.de>,
        <s-anna@ti.com>
References: <20230807111534.12392-1-aboutphysycs@gmail.com>
 <CAH3L5QrdF3fZDKV4FvsO+czgWyWNxKZE3yaxP7C94o0oyLZ6HQ@mail.gmail.com>
From:   Andrew Davis <afd@ti.com>
In-Reply-To: <CAH3L5QrdF3fZDKV4FvsO+czgWyWNxKZE3yaxP7C94o0oyLZ6HQ@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 8/7/23 6:57 AM, Alexandru Ardelean wrote:
> On Mon, Aug 7, 2023 at 2:15 PM Andrei Coardos <aboutphysycs@gmail.com> wrote:
>>
>> This function call was found to be unnecessary as there is no equivalent
>> platform_get_drvdata() call to access the private data of the driver. Also,
>> the private data is defined in this driver, so there is no risk of it being
>> accessed outside of this driver file.
>>
> 
> Reviewed-by: Alexandru Ardelean <alex@shruggie.ro>
> 
> // also adding the people listed as MODULE_AUTHOR
> // the list seems a bit short otherwise; no idea if these emails work
> 
>> Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com>
>> ---

LGTM,

Acked-by: Andrew Davis <afd@ti.com>

>>   drivers/reset/reset-ti-syscon.c | 2 --
>>   1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/reset/reset-ti-syscon.c b/drivers/reset/reset-ti-syscon.c
>> index f0dd7ffc3b72..23f86ddb8668 100644
>> --- a/drivers/reset/reset-ti-syscon.c
>> +++ b/drivers/reset/reset-ti-syscon.c
>> @@ -204,8 +204,6 @@ static int ti_syscon_reset_probe(struct platform_device *pdev)
>>          data->controls = controls;
>>          data->nr_controls = nr_controls;
>>
>> -       platform_set_drvdata(pdev, data);
>> -
>>          return devm_reset_controller_register(dev, &data->rcdev);
>>   }
>>
>> --
>> 2.34.1
>>