Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230801023658.4667-1-sunran001@208suo.com>
In-Reply-To: <20230801023658.4667-1-sunran001@208suo.com>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Mon, 7 Aug 2023 12:24:11 -0400
Message-ID: <CADnq5_MZ7HOUiw05H4oQokT4ad+=4ypjVBtSyYdqBNgfL5Q3CA@mail.gmail.com>
Subject: Re: [PATCH] drm/amd/pm: Clean up errors in amd_powerplay.c
To:     Ran Sun <sunran001@208suo.com>
Cc:     alexander.deucher@amd.com, airlied@gmail.com, daniel@ffwll.ch,
        dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Applied.  Thanks!

On Mon, Jul 31, 2023 at 10:37=E2=80=AFPM Ran Sun <sunran001@208suo.com> wro=
te:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: that open brace { should be on the previous line
> ERROR: spaces required around that '||' (ctx:WxO)
>
> Signed-off-by: Ran Sun <sunran001@208suo.com>
> ---
>  drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c b/drivers/g=
pu/drm/amd/pm/powerplay/amd_powerplay.c
> index ff360c699171..9e4f8a4104a3 100644
> --- a/drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c
> +++ b/drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c
> @@ -612,7 +612,7 @@ static int pp_dpm_get_pp_num_states(void *handle,
>
>         memset(data, 0, sizeof(*data));
>
> -       if (!hwmgr || !hwmgr->pm_en ||!hwmgr->ps)
> +       if (!hwmgr || !hwmgr->pm_en || !hwmgr->ps)
>                 return -EINVAL;
>
>         data->nums =3D hwmgr->num_ps;
> @@ -644,7 +644,7 @@ static int pp_dpm_get_pp_table(void *handle, char **t=
able)
>  {
>         struct pp_hwmgr *hwmgr =3D handle;
>
> -       if (!hwmgr || !hwmgr->pm_en ||!hwmgr->soft_pp_table)
> +       if (!hwmgr || !hwmgr->pm_en || !hwmgr->soft_pp_table)
>                 return -EINVAL;
>
>         *table =3D (char *)hwmgr->soft_pp_table;
> @@ -1002,7 +1002,7 @@ static int pp_get_power_limit(void *handle, uint32_=
t *limit,
>         struct pp_hwmgr *hwmgr =3D handle;
>         int ret =3D 0;
>
> -       if (!hwmgr || !hwmgr->pm_en ||!limit)
> +       if (!hwmgr || !hwmgr->pm_en || !limit)
>                 return -EINVAL;
>
>         if (power_type !=3D PP_PWR_TYPE_SUSTAINED)
> @@ -1047,7 +1047,7 @@ static int pp_get_display_power_level(void *handle,
>  {
>         struct pp_hwmgr *hwmgr =3D handle;
>
> -       if (!hwmgr || !hwmgr->pm_en ||!output)
> +       if (!hwmgr || !hwmgr->pm_en || !output)
>                 return -EINVAL;
>
>         return phm_get_dal_power_level(hwmgr, output);
> @@ -1120,7 +1120,7 @@ static int pp_get_clock_by_type_with_latency(void *=
handle,
>  {
>         struct pp_hwmgr *hwmgr =3D handle;
>
> -       if (!hwmgr || !hwmgr->pm_en ||!clocks)
> +       if (!hwmgr || !hwmgr->pm_en || !clocks)
>                 return -EINVAL;
>
>         return phm_get_clock_by_type_with_latency(hwmgr, type, clocks);
> @@ -1132,7 +1132,7 @@ static int pp_get_clock_by_type_with_voltage(void *=
handle,
>  {
>         struct pp_hwmgr *hwmgr =3D handle;
>
> -       if (!hwmgr || !hwmgr->pm_en ||!clocks)
> +       if (!hwmgr || !hwmgr->pm_en || !clocks)
>                 return -EINVAL;
>
>         return phm_get_clock_by_type_with_voltage(hwmgr, type, clocks);
> @@ -1155,7 +1155,7 @@ static int pp_display_clock_voltage_request(void *h=
andle,
>  {
>         struct pp_hwmgr *hwmgr =3D handle;
>
> -       if (!hwmgr || !hwmgr->pm_en ||!clock)
> +       if (!hwmgr || !hwmgr->pm_en || !clock)
>                 return -EINVAL;
>
>         return phm_display_clock_voltage_request(hwmgr, clock);
> @@ -1167,7 +1167,7 @@ static int pp_get_display_mode_validation_clocks(vo=
id *handle,
>         struct pp_hwmgr *hwmgr =3D handle;
>         int ret =3D 0;
>
> -       if (!hwmgr || !hwmgr->pm_en ||!clocks)
> +       if (!hwmgr || !hwmgr->pm_en || !clocks)
>                 return -EINVAL;
>
>         clocks->level =3D PP_DAL_POWERLEVEL_7;
> --
> 2.17.1
>