Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230801084024.6826-1-sunran001@208suo.com>
In-Reply-To: <20230801084024.6826-1-sunran001@208suo.com>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Mon, 7 Aug 2023 12:38:31 -0400
Message-ID: <CADnq5_Pn4U0uV4qLkBauxnWdRQZHtiq135qn+-uDRR34ZHbaPQ@mail.gmail.com>
Subject: Re: [PATCH] drm/amd/pm: Clean up errors in vega10_pptable.h
To:     Ran Sun <sunran001@208suo.com>
Cc:     alexander.deucher@amd.com, airlied@gmail.com, daniel@ffwll.ch,
        dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Applied.  Thanks!

On Tue, Aug 1, 2023 at 4:40=E2=80=AFAM Ran Sun <sunran001@208suo.com> wrote=
:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: open brace '{' following struct go on the same line
>
> Signed-off-by: Ran Sun <sunran001@208suo.com>
> ---
>  .../amd/pm/powerplay/hwmgr/vega10_pptable.h    | 18 ++++++------------
>  1 file changed, 6 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_pptable.h b/dr=
ivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_pptable.h
> index 9c479bd9a786..8b0590b834cc 100644
> --- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_pptable.h
> +++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_pptable.h
> @@ -317,16 +317,14 @@ typedef struct _ATOM_Vega10_Thermal_Controller {
>      UCHAR ucFlags;          /* to be defined */
>  } ATOM_Vega10_Thermal_Controller;
>
> -typedef struct _ATOM_Vega10_VCE_State_Record
> -{
> +typedef struct _ATOM_Vega10_VCE_State_Record {
>      UCHAR  ucVCEClockIndex;         /*index into usVCEDependencyTableOff=
set of 'ATOM_Vega10_MM_Dependency_Table' type */
>      UCHAR  ucFlag;                  /* 2 bits indicates memory p-states =
*/
>      UCHAR  ucSCLKIndex;             /* index into ATOM_Vega10_SCLK_Depen=
dency_Table */
>      UCHAR  ucMCLKIndex;             /* index into ATOM_Vega10_MCLK_Depen=
dency_Table */
>  } ATOM_Vega10_VCE_State_Record;
>
> -typedef struct _ATOM_Vega10_VCE_State_Table
> -{
> +typedef struct _ATOM_Vega10_VCE_State_Table {
>      UCHAR ucRevId;
>      UCHAR ucNumEntries;
>      ATOM_Vega10_VCE_State_Record entries[1];
> @@ -361,8 +359,7 @@ typedef struct _ATOM_Vega10_PowerTune_Table {
>         USHORT usTemperatureLimitTedge;
>  } ATOM_Vega10_PowerTune_Table;
>
> -typedef struct _ATOM_Vega10_PowerTune_Table_V2
> -{
> +typedef struct _ATOM_Vega10_PowerTune_Table_V2 {
>         UCHAR  ucRevId;
>         USHORT usSocketPowerLimit;
>         USHORT usBatteryPowerLimit;
> @@ -388,8 +385,7 @@ typedef struct _ATOM_Vega10_PowerTune_Table_V2
>         USHORT usTemperatureLimitTedge;
>  } ATOM_Vega10_PowerTune_Table_V2;
>
> -typedef struct _ATOM_Vega10_PowerTune_Table_V3
> -{
> +typedef struct _ATOM_Vega10_PowerTune_Table_V3 {
>         UCHAR  ucRevId;
>         USHORT usSocketPowerLimit;
>         USHORT usBatteryPowerLimit;
> @@ -428,15 +424,13 @@ typedef struct _ATOM_Vega10_Hard_Limit_Record {
>      USHORT usVddMemLimit;
>  } ATOM_Vega10_Hard_Limit_Record;
>
> -typedef struct _ATOM_Vega10_Hard_Limit_Table
> -{
> +typedef struct _ATOM_Vega10_Hard_Limit_Table {
>      UCHAR ucRevId;
>      UCHAR ucNumEntries;
>      ATOM_Vega10_Hard_Limit_Record entries[1];
>  } ATOM_Vega10_Hard_Limit_Table;
>
> -typedef struct _Vega10_PPTable_Generic_SubTable_Header
> -{
> +typedef struct _Vega10_PPTable_Generic_SubTable_Header {
>      UCHAR  ucRevId;
>  } Vega10_PPTable_Generic_SubTable_Header;
>
> --
> 2.17.1
>