Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230801030334.5069-1-sunran001@208suo.com>
In-Reply-To: <20230801030334.5069-1-sunran001@208suo.com>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Mon, 7 Aug 2023 12:26:16 -0400
Message-ID: <CADnq5_OVqaYzv6_y20axW+dmx1+_x9M9A29R8dKnM8rVNjh-=g@mail.gmail.com>
Subject: Re: [PATCH] drm/amd/pm/powerplay/hwmgr/ppevvmath: Clean up errors in ppevvmath.h
To:     Ran Sun <sunran001@208suo.com>
Cc:     alexander.deucher@amd.com, airlied@gmail.com, daniel@ffwll.ch,
        dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Applied.  Thanks!

On Mon, Jul 31, 2023 at 11:03=E2=80=AFPM Ran Sun <sunran001@208suo.com> wro=
te:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: return is not a function, parentheses are not required
> ERROR: space required after that ',' (ctx:VxV)
> ERROR: space required before the open parenthesis '('
> ERROR: need consistent spacing around '-' (ctx:WxV)
>
> Signed-off-by: Ran Sun <sunran001@208suo.com>
> ---
>  drivers/gpu/drm/amd/pm/powerplay/hwmgr/ppevvmath.h | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/ppevvmath.h b/drivers=
/gpu/drm/amd/pm/powerplay/hwmgr/ppevvmath.h
> index dac29fe6cfc6..6f54c410c2f9 100644
> --- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/ppevvmath.h
> +++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/ppevvmath.h
> @@ -166,7 +166,7 @@ static fInt fNaturalLog(fInt value)
>
>         error_term =3D fAdd(fNegativeOne, value);
>
> -       return (fAdd(solution, error_term));
> +       return fAdd(solution, error_term);
>  }
>
>  static fInt fDecodeLinearFuse(uint32_t fuse_value, fInt f_min, fInt f_ra=
nge, uint32_t bitlength)
> @@ -230,7 +230,7 @@ static fInt ConvertToFraction(int X) /*Add all range =
checking here. Is it possib
>  static fInt fNegate(fInt X)
>  {
>         fInt CONSTANT_NEGONE =3D ConvertToFraction(-1);
> -       return (fMultiply(X, CONSTANT_NEGONE));
> +       return fMultiply(X, CONSTANT_NEGONE);
>  }
>
>  static fInt Convert_ULONG_ToFraction(uint32_t X)
> @@ -382,14 +382,14 @@ static int ConvertBackToInteger (fInt A) /*THIS is =
the function that will be use
>
>         scaledDecimal.full =3D uGetScaledDecimal(A);
>
> -       fullNumber =3D fAdd(scaledDecimal,scaledReal);
> +       fullNumber =3D fAdd(scaledDecimal, scaledReal);
>
>         return fullNumber.full;
>  }
>
>  static fInt fGetSquare(fInt A)
>  {
> -       return fMultiply(A,A);
> +       return fMultiply(A, A);
>  }
>
>  /* x_new =3D x_old - (x_old^2 - C) / (2 * x_old) */
> @@ -447,7 +447,7 @@ static fInt fSqrt(fInt num)
>
>         } while (uAbs(error) > 0);
>
> -       return (x_new);
> +       return x_new;
>  }
>
>  static void SolveQuadracticEqn(fInt A, fInt B, fInt C, fInt Roots[])
> @@ -459,7 +459,7 @@ static void SolveQuadracticEqn(fInt A, fInt B, fInt C=
, fInt Roots[])
>         f_CONSTANT100 =3D ConvertToFraction(100);
>         f_CONSTANT10 =3D ConvertToFraction(10);
>
> -       while(GreaterThan(A, f_CONSTANT100) || GreaterThan(B, f_CONSTANT1=
00) || GreaterThan(C, f_CONSTANT100)) {
> +       while (GreaterThan(A, f_CONSTANT100) || GreaterThan(B, f_CONSTANT=
100) || GreaterThan(C, f_CONSTANT100)) {
>                 A =3D fDivide(A, f_CONSTANT10);
>                 B =3D fDivide(B, f_CONSTANT10);
>                 C =3D fDivide(C, f_CONSTANT10);
> @@ -515,7 +515,7 @@ static int uGetScaledDecimal (fInt A) /*Converts the =
fractional portion to whole
>                 dec[i] =3D tmp / (1 << SHIFT_AMOUNT);
>                 tmp =3D tmp - ((1 << SHIFT_AMOUNT)*dec[i]);
>                 tmp *=3D 10;
> -               scaledDecimal =3D scaledDecimal + dec[i]*uPow(10, PRECISI=
ON - 1 -i);
> +               scaledDecimal =3D scaledDecimal + dec[i]*uPow(10, PRECISI=
ON - 1 - i);
>         }
>
>         return scaledDecimal;
> --
> 2.17.1
>