Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230802012302.8498-1-sunran001@208suo.com>
In-Reply-To: <20230802012302.8498-1-sunran001@208suo.com>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Mon, 7 Aug 2023 12:55:53 -0400
Message-ID: <CADnq5_MwvypKA+B9FGwHE1BCKjJdRCrbRZbF+7_U7GxiHSFwAA@mail.gmail.com>
Subject: Re: [PATCH] drm/amd/pm: Clean up errors in smu71.h
To:     Ran Sun <sunran001@208suo.com>
Cc:     alexander.deucher@amd.com, dri-devel@lists.freedesktop.org,
        amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Applied.  Thanks!

On Tue, Aug 1, 2023 at 9:23=E2=80=AFPM Ran Sun <sunran001@208suo.com> wrote=
:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: open brace '{' following struct go on the same line
> ERROR: space prohibited before open square bracket '['
>
> Signed-off-by: Ran Sun <sunran001@208suo.com>
> ---
>  drivers/gpu/drm/amd/pm/powerplay/inc/smu71.h | 22 +++++++-------------
>  1 file changed, 8 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/powerplay/inc/smu71.h b/drivers/gpu/d=
rm/amd/pm/powerplay/inc/smu71.h
> index 71c9b2d28640..b5f177412769 100644
> --- a/drivers/gpu/drm/amd/pm/powerplay/inc/smu71.h
> +++ b/drivers/gpu/drm/amd/pm/powerplay/inc/smu71.h
> @@ -118,8 +118,7 @@ typedef struct {
>
>  #endif
>
> -struct SMU71_PIDController
> -{
> +struct SMU71_PIDController {
>      uint32_t Ki;
>      int32_t LFWindupUpperLim;
>      int32_t LFWindupLowerLim;
> @@ -133,8 +132,7 @@ struct SMU71_PIDController
>
>  typedef struct SMU71_PIDController SMU71_PIDController;
>
> -struct SMU7_LocalDpmScoreboard
> -{
> +struct SMU7_LocalDpmScoreboard {
>      uint32_t PercentageBusy;
>
>      int32_t  PIDError;
> @@ -179,8 +177,8 @@ struct SMU7_LocalDpmScoreboard
>      uint8_t  DteClampMode;
>      uint8_t  FpsClampMode;
>
> -    uint16_t LevelResidencyCounters [SMU71_MAX_LEVELS_GRAPHICS];
> -    uint16_t LevelSwitchCounters [SMU71_MAX_LEVELS_GRAPHICS];
> +    uint16_t LevelResidencyCounters[SMU71_MAX_LEVELS_GRAPHICS];
> +    uint16_t LevelSwitchCounters[SMU71_MAX_LEVELS_GRAPHICS];
>
>      void     (*TargetStateCalculator)(uint8_t);
>      void     (*SavedTargetStateCalculator)(uint8_t);
> @@ -200,8 +198,7 @@ typedef struct SMU7_LocalDpmScoreboard SMU7_LocalDpmS=
coreboard;
>
>  #define SMU7_MAX_VOLTAGE_CLIENTS 12
>
> -struct SMU7_VoltageScoreboard
> -{
> +struct SMU7_VoltageScoreboard {
>      uint16_t CurrentVoltage;
>      uint16_t HighestVoltage;
>      uint16_t MaxVid;
> @@ -325,8 +322,7 @@ typedef struct SMU7_PowerScoreboard SMU7_PowerScorebo=
ard;
>
>  // ---------------------------------------------------------------------=
-----------------------------
>
> -struct SMU7_ThermalScoreboard
> -{
> +struct SMU7_ThermalScoreboard {
>     int16_t  GpuLimit;
>     int16_t  GpuHyst;
>     uint16_t CurrGnbTemp;
> @@ -360,8 +356,7 @@ typedef struct SMU7_ThermalScoreboard SMU7_ThermalSco=
reboard;
>  #define SMU7_VCE_SCLK_HANDSHAKE_DISABLE                  0x00020000
>
>  // All 'soft registers' should be uint32_t.
> -struct SMU71_SoftRegisters
> -{
> +struct SMU71_SoftRegisters {
>      uint32_t        RefClockFrequency;
>      uint32_t        PmTimerPeriod;
>      uint32_t        FeatureEnables;
> @@ -413,8 +408,7 @@ struct SMU71_SoftRegisters
>
>  typedef struct SMU71_SoftRegisters SMU71_SoftRegisters;
>
> -struct SMU71_Firmware_Header
> -{
> +struct SMU71_Firmware_Header {
>      uint32_t Digest[5];
>      uint32_t Version;
>      uint32_t HeaderSize;
> --
> 2.17.1
>