Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230801094443.7942-1-sunran001@208suo.com>
In-Reply-To: <20230801094443.7942-1-sunran001@208suo.com>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Mon, 7 Aug 2023 12:49:45 -0400
Message-ID: <CADnq5_MbmP9sEkWHndxaG+pp6bJkeO7h1qvya3wZWmktDpFYpQ@mail.gmail.com>
Subject: Re: [PATCH] drm/amd/pm: Clean up errors in vega20_pptable.h
To:     Ran Sun <sunran001@208suo.com>
Cc:     alexander.deucher@amd.com, airlied@gmail.com, daniel@ffwll.ch,
        dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Applied.  Thanks!

On Tue, Aug 1, 2023 at 5:44=E2=80=AFAM Ran Sun <sunran001@208suo.com> wrote=
:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: open brace '{' following struct go on the same line
> ERROR: space prohibited before open square bracket '['
>
> Signed-off-by: Ran Sun <sunran001@208suo.com>
> ---
>  .../amd/pm/powerplay/hwmgr/vega20_pptable.h   | 19 ++++++++-----------
>  1 file changed, 8 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_pptable.h b/dr=
ivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_pptable.h
> index 2222e29405c6..b468dddbefff 100644
> --- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_pptable.h
> +++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_pptable.h
> @@ -73,14 +73,13 @@ enum ATOM_VEGA20_ODSETTING_ID {
>  };
>  typedef enum ATOM_VEGA20_ODSETTING_ID ATOM_VEGA20_ODSETTING_ID;
>
> -typedef struct _ATOM_VEGA20_OVERDRIVE8_RECORD
> -{
> +typedef struct _ATOM_VEGA20_OVERDRIVE8_RECORD {
>    UCHAR ucODTableRevision;
>    ULONG ODFeatureCount;
> -  UCHAR ODFeatureCapabilities [ATOM_VEGA20_ODFEATURE_MAX_COUNT];   //OD =
feature support flags
> +  UCHAR ODFeatureCapabilities[ATOM_VEGA20_ODFEATURE_MAX_COUNT];   //OD f=
eature support flags
>    ULONG ODSettingCount;
> -  ULONG ODSettingsMax [ATOM_VEGA20_ODSETTING_MAX_COUNT];           //Upp=
er Limit for each OD Setting
> -  ULONG ODSettingsMin [ATOM_VEGA20_ODSETTING_MAX_COUNT];           //Low=
er Limit for each OD Setting
> +  ULONG ODSettingsMax[ATOM_VEGA20_ODSETTING_MAX_COUNT];           //Uppe=
r Limit for each OD Setting
> +  ULONG ODSettingsMin[ATOM_VEGA20_ODSETTING_MAX_COUNT];           //Lowe=
r Limit for each OD Setting
>  } ATOM_VEGA20_OVERDRIVE8_RECORD;
>
>  enum ATOM_VEGA20_PPCLOCK_ID {
> @@ -99,16 +98,14 @@ enum ATOM_VEGA20_PPCLOCK_ID {
>  };
>  typedef enum ATOM_VEGA20_PPCLOCK_ID ATOM_VEGA20_PPCLOCK_ID;
>
> -typedef struct _ATOM_VEGA20_POWER_SAVING_CLOCK_RECORD
> -{
> +typedef struct _ATOM_VEGA20_POWER_SAVING_CLOCK_RECORD {
>    UCHAR ucTableRevision;
>    ULONG PowerSavingClockCount;                                 // Count =
of PowerSavingClock Mode
> -  ULONG PowerSavingClockMax  [ATOM_VEGA20_PPCLOCK_MAX_COUNT];      // Po=
werSavingClock Mode Clock Maximum array In MHz
> -  ULONG PowerSavingClockMin  [ATOM_VEGA20_PPCLOCK_MAX_COUNT];      // Po=
werSavingClock Mode Clock Minimum array In MHz
> +  ULONG PowerSavingClockMax[ATOM_VEGA20_PPCLOCK_MAX_COUNT];      // Powe=
rSavingClock Mode Clock Maximum array In MHz
> +  ULONG PowerSavingClockMin[ATOM_VEGA20_PPCLOCK_MAX_COUNT];      // Powe=
rSavingClock Mode Clock Minimum array In MHz
>  } ATOM_VEGA20_POWER_SAVING_CLOCK_RECORD;
>
> -typedef struct _ATOM_VEGA20_POWERPLAYTABLE
> -{
> +typedef struct _ATOM_VEGA20_POWERPLAYTABLE {
>        struct atom_common_table_header sHeader;
>        UCHAR  ucTableRevision;
>        USHORT usTableSize;
> --
> 2.17.1
>