Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230802065127.12183-1-sunran001@208suo.com>
In-Reply-To: <20230802065127.12183-1-sunran001@208suo.com>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Mon, 7 Aug 2023 13:20:05 -0400
Message-ID: <CADnq5_PQr8Op2tqs4s78Qg+niP9=VMxxPQt9Ya8BJL-czWCshQ@mail.gmail.com>
Subject: Re: [PATCH] drm/amdgpu/atomfirmware: Clean up errors in amdgpu_atomfirmware.c
To:     Ran Sun <sunran001@208suo.com>
Cc:     alexander.deucher@amd.com, dri-devel@lists.freedesktop.org,
        amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Applied.  Thanks!

On Wed, Aug 2, 2023 at 2:51=E2=80=AFAM Ran Sun <sunran001@208suo.com> wrote=
:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: spaces required around that '>=3D' (ctx:WxV)
> ERROR: spaces required around that '!=3D' (ctx:WxV)
> ERROR: code indent should use tabs where possible
>
> Signed-off-by: Ran Sun <sunran001@208suo.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c b/drivers/g=
pu/drm/amd/amdgpu/amdgpu_atomfirmware.c
> index 0b7f4c4d58e5..835980e94b9e 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c
> @@ -58,7 +58,7 @@ uint32_t amdgpu_atomfirmware_query_firmware_capability(=
struct amdgpu_device *ade
>         if (amdgpu_atom_parse_data_header(adev->mode_info.atom_context,
>                                 index, &size, &frev, &crev, &data_offset)=
) {
>                 /* support firmware_info 3.1 + */
> -               if ((frev =3D=3D 3 && crev >=3D1) || (frev > 3)) {
> +               if ((frev =3D=3D 3 && crev >=3D 1) || (frev > 3)) {
>                         firmware_info =3D (union firmware_info *)
>                                 (mode_info->atom_context->bios + data_off=
set);
>                         fw_cap =3D le32_to_cpu(firmware_info->v31.firmwar=
e_capability);
> @@ -597,7 +597,7 @@ bool amdgpu_atomfirmware_ras_rom_addr(struct amdgpu_d=
evice *adev,
>                                           index, &size, &frev, &crev,
>                                           &data_offset)) {
>                 /* support firmware_info 3.4 + */
> -               if ((frev =3D=3D 3 && crev >=3D4) || (frev > 3)) {
> +               if ((frev =3D=3D 3 && crev >=3D 4) || (frev > 3)) {
>                         firmware_info =3D (union firmware_info *)
>                                 (mode_info->atom_context->bios + data_off=
set);
>                         /* The ras_rom_i2c_slave_addr should ideally
> @@ -850,7 +850,7 @@ int amdgpu_atomfirmware_get_fw_reserved_fb_size(struc=
t amdgpu_device *adev)
>
>         firmware_info =3D (union firmware_info *)(ctx->bios + data_offset=
);
>
> -       if (frev !=3D3)
> +       if (frev !=3D 3)
>                 return -EINVAL;
>
>         switch (crev) {
> @@ -909,7 +909,7 @@ int amdgpu_atomfirmware_asic_init(struct amdgpu_devic=
e *adev, bool fb_reset)
>         }
>
>         index =3D get_index_into_master_table(atom_master_list_of_command=
_functions_v2_1,
> -                                            asic_init);
> +                                       asic_init);
>         if (amdgpu_atom_parse_cmd_header(mode_info->atom_context, index, =
&frev, &crev)) {
>                 if (frev =3D=3D 2 && crev >=3D 1) {
>                         memset(&asic_init_ps_v2_1, 0, sizeof(asic_init_ps=
_v2_1));
> --
> 2.17.1
>