Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230802032256.10846-1-sunran001@208suo.com>
In-Reply-To: <20230802032256.10846-1-sunran001@208suo.com>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Mon, 7 Aug 2023 13:13:22 -0400
Message-ID: <CADnq5_O5FY_eYetryQ47FRwhh4-w=ifakZy0GNkvswQccuef2g@mail.gmail.com>
Subject: Re: [PATCH] drm/amd/display: Clean up errors in bios_parser2.c
To:     Ran Sun <sunran001@208suo.com>
Cc:     alexander.deucher@amd.com, dri-devel@lists.freedesktop.org,
        amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Applied.  Thanks!

As a follow up patch, care to drop the break statements after a return?

On Tue, Aug 1, 2023 at 11:23=E2=80=AFPM Ran Sun <sunran001@208suo.com> wrot=
e:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: switch and case should be at the same indent
> ERROR: code indent should use tabs where possible
>
> Signed-off-by: Ran Sun <sunran001@208suo.com>
> ---
>  .../drm/amd/display/dc/bios/bios_parser2.c    | 32 +++++++++----------
>  1 file changed, 16 insertions(+), 16 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c b/drivers=
/gpu/drm/amd/display/dc/bios/bios_parser2.c
> index 540d19efad8f..033ce2638eb2 100644
> --- a/drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c
> +++ b/drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c
> @@ -772,20 +772,20 @@ static enum bp_result bios_parser_get_device_tag(
>                 return BP_RESULT_BADINPUT;
>
>         switch (bp->object_info_tbl.revision.minor) {
> -           case 4:
> -           default:
> +       case 4:
> +       default:
>                 /* getBiosObject will return MXM object */
> -               object =3D get_bios_object(bp, connector_object_id);
> +               object =3D get_bios_object(bp, connector_object_id);
>
>                 if (!object) {
>                         BREAK_TO_DEBUGGER(); /* Invalid object id */
>                         return BP_RESULT_BADINPUT;
>                 }
>
> -               info->acpi_device =3D 0; /* BIOS no longer provides this =
*/
> -               info->dev_id =3D device_type_from_device_id(object->devic=
e_tag);
> -               break;
> -           case 5:
> +               info->acpi_device =3D 0; /* BIOS no longer provides this =
*/
> +               info->dev_id =3D device_type_from_device_id(object->devic=
e_tag);
> +               break;
> +       case 5:
>                 object_path_v3 =3D get_bios_object_from_path_v3(bp, conne=
ctor_object_id);
>
>                 if (!object_path_v3) {
> @@ -1580,13 +1580,13 @@ static bool bios_parser_is_device_id_supported(
>         uint32_t mask =3D get_support_mask_for_device_id(id);
>
>         switch (bp->object_info_tbl.revision.minor) {
> -           case 4:
> -           default:
> -               return (le16_to_cpu(bp->object_info_tbl.v1_4->supportedde=
vices) & mask) !=3D 0;
> -                       break;
> -           case 5:
> -                       return (le16_to_cpu(bp->object_info_tbl.v1_5->sup=
porteddevices) & mask) !=3D 0;
> -                       break;
> +       case 4:
> +       default:
> +               return (le16_to_cpu(bp->object_info_tbl.v1_4->supportedde=
vices) & mask) !=3D 0;
> +               break;
> +       case 5:
> +               return (le16_to_cpu(bp->object_info_tbl.v1_5->supportedde=
vices) & mask) !=3D 0;
> +               break;
>         }
>
>         return false;
> @@ -1755,7 +1755,7 @@ static enum bp_result bios_parser_get_firmware_info=
(
>                         case 2:
>                         case 3:
>                                 result =3D get_firmware_info_v3_2(bp, inf=
o);
> -                                break;
> +                       break;
>                         case 4:
>                                 result =3D get_firmware_info_v3_4(bp, inf=
o);
>                                 break;
> @@ -2225,7 +2225,7 @@ static enum bp_result bios_parser_get_disp_connecto=
r_caps_info(
>                 return BP_RESULT_BADINPUT;
>
>         switch (bp->object_info_tbl.revision.minor) {
> -           case 4:
> +       case 4:
>             default:
>                     object =3D get_bios_object(bp, object_id);
>
> --
> 2.17.1
>