Received: by 2002:a05:6359:6284:b0:131:369:b2a3 with SMTP id se4csp3313874rwb; Mon, 7 Aug 2023 11:22:15 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFh4rtBwsNF38mZhQNyIT+7+I1FfOisl/XhLXnFKLS77fPBnufgilbtoAlqQeszBe3FRF5p X-Received: by 2002:a17:902:8341:b0:1b6:ba60:77f0 with SMTP id z1-20020a170902834100b001b6ba6077f0mr7685750pln.10.1691432534968; Mon, 07 Aug 2023 11:22:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691432534; cv=none; d=google.com; s=arc-20160816; b=wxN4xoEa+xHZ6x/og61cC39SVbW7sYcIBsLpgih/9fXC0NjksNFjqe2Yi6pWLJ/85Z v165x9EfhnhFK5JEoHJbTthQU7f8oskXC4EIdF/LHpbsgmGQGgmQjHRhUMVY/eOTdY/9 rQKHCdyG9/7J+iFNg3vp+9C3xVDrezM3shKJHvkIf+8wxLkiqbRHfxRB6YKGy0ZI3U9K g95SPhjAyJn0PgbuITa2F+f13L+1CwmsGy/0wkOsBMoVEZAHuKn0HS5grnCWzrOtfFMh SN30j7Zrrh6xrU+4QRnaDUrtvSUOp55fJqey8auN1Z5xe+msZOIUKN6D5V3jHd9zH5KJ TbQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=m16fJSelMd4HZcAn1Zx8fvrGuQ+wWIhwtRhDA7myOIk=; fh=YwR8hmjC2QSif+72cT3/sIS32/1FMEJSAUJ+j+OuTzU=; b=vCtODrPP7TmpPTJsf5ONYryQCQz78UXYdkJdrFKCx3e9DayVlki4x+FTKWeO71tyha NEdux3BViFPGj6DUaYIM8jOcWgSHNVg8P8SlYUDWib2xW2fh5NuPQc7wibbZrvW7ev0p U2kvotgnZC3Ay6U209nwGa61TLF8Yx6sxNmPl7m98CUJ79w99k2EJJse1zW3rxmYG0uG WhR2I7ykbb9UoXMhJDmG9abePqcme0KKdyV5nHJcb0vILj/Cy7V9hVs+sNAPqu58iqAU fkzWy3yHQ1Vp9YQj+ij9Bfyu/c1aILW4lgzHCyp/clbpN9XMu2+eAVKFoqLK9y24xWhV hQkw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=MSYUk2F8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u10-20020a170903124a00b001bb3135003fsi5908045plh.161.2023.08.07.11.22.01; Mon, 07 Aug 2023 11:22:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=MSYUk2F8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230228AbjHGRLJ (ORCPT + 99 others); Mon, 7 Aug 2023 13:11:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42674 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230089AbjHGRLH (ORCPT ); Mon, 7 Aug 2023 13:11:07 -0400 Received: from mail-oo1-xc31.google.com (mail-oo1-xc31.google.com [IPv6:2607:f8b0:4864:20::c31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE3B61A3 for ; Mon, 7 Aug 2023 10:11:06 -0700 (PDT) Received: by mail-oo1-xc31.google.com with SMTP id 006d021491bc7-56cc3453e31so3109432eaf.1 for ; Mon, 07 Aug 2023 10:11:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691428266; x=1692033066; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=m16fJSelMd4HZcAn1Zx8fvrGuQ+wWIhwtRhDA7myOIk=; b=MSYUk2F8V927UzOSmS+4fdZ/330PbUEqDcZWJVNyRRIp9V6BPcn2m0AmB74eqD1M8x z0/qzM7eRkxnPVmq3Ch2bhLig/AFhcec/LAVgsAPiyZqPrGIqqVmw+eASt47JkTcht2h eMF1YRIkHsN5x5ZGhA39FqaAPr4HCsuZupYPB+yc8N84NnQAy4qJaTbf4MD8fUUdA05K FB6fC383Ff6S4GIedCwd25vetvo1EhDYEJFnIqE96l3b0TFbgwKjBz28O69wQ9jJNxZd dKRgbnpStZBSuJWUmSdmIUe9EoR57gILkXm9RN/jJtuem6Jw99xiLkSXGmlyXBXA5B0/ 7NZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691428266; x=1692033066; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=m16fJSelMd4HZcAn1Zx8fvrGuQ+wWIhwtRhDA7myOIk=; b=IytS61SCgnsRPyUVf2xMwLfAy547g/tFESPGMdH1bgOn2QWoill1CzVcnCXUX9blqt 1OXoOXcrWCRHMXY/KceBQTLrTTGI1sNkmVDBfSxkJObl2qwGTZiXGiHJjYddyrVxTuXA PUeBem/3GyW2Ia7GHNbWkdZMcYcbsOyg8DxbuOwkiYdpBsGPCNPeoA2ykvPnRVYJS+Mr NDMWVDo5rjRq6vE3O+xua4eQJ5LWGSwdoWmVzw74Zd3jSBInntSHY/r+aBDjYwKPf4Ot bu1FDk8JFxez6kLaEHINjGumFJsPQxKgP3JrJR8s27EgZiZINN6VkKty64tG4QLt0jrX mAqQ== X-Gm-Message-State: AOJu0YxxfJocnKt3m18HLnMcUvxOPrlseX4y96l1fXyaoWeHvL8o9r5T FLGOMBOy7/DdtRomRDKI5bpLEocUNbFIVDjGaUk= X-Received: by 2002:a4a:3818:0:b0:567:154:25dc with SMTP id c24-20020a4a3818000000b00567015425dcmr9049143ooa.7.1691428266104; Mon, 07 Aug 2023 10:11:06 -0700 (PDT) MIME-Version: 1.0 References: <20230802025814.10569-1-sunran001@208suo.com> In-Reply-To: <20230802025814.10569-1-sunran001@208suo.com> From: Alex Deucher Date: Mon, 7 Aug 2023 13:10:55 -0400 Message-ID: Subject: Re: [PATCH] drm/amd/display: Clean up errors in dcn315_smu.c To: Ran Sun Cc: alexander.deucher@amd.com, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Applied. Thanks! On Tue, Aug 1, 2023 at 10:58=E2=80=AFPM Ran Sun wrot= e: > > Fix the following errors reported by checkpatch: > > ERROR: open brace '{' following struct go on the same line > ERROR: code indent should use tabs where possible > > Signed-off-by: Ran Sun > --- > .../display/dc/clk_mgr/dcn315/dcn315_smu.c | 26 +++++++++---------- > 1 file changed, 12 insertions(+), 14 deletions(-) > > diff --git a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn315/dcn315_smu.c b= /drivers/gpu/drm/amd/display/dc/clk_mgr/dcn315/dcn315_smu.c > index 925d6e13620e..3e0da873cf4c 100644 > --- a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn315/dcn315_smu.c > +++ b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn315/dcn315_smu.c > @@ -33,28 +33,26 @@ > #define MAX_INSTANCE 6 > #define MAX_SEGMENT 6 > > -struct IP_BASE_INSTANCE > -{ > +struct IP_BASE_INSTANCE { > unsigned int segment[MAX_SEGMENT]; > }; > > -struct IP_BASE > -{ > +struct IP_BASE { > struct IP_BASE_INSTANCE instance[MAX_INSTANCE]; > }; > > static const struct IP_BASE MP0_BASE =3D { { { { 0x00016000, 0x00DC0000,= 0x00E00000, 0x00E40000, 0x0243FC00, 0 } }, > - { { 0, 0, 0, 0, 0, 0 } }, > - { { 0, 0, 0, 0, 0, 0 } }, > - { { 0, 0, 0, 0, 0, 0 } }, > - { { 0, 0, 0, 0, 0, 0 } }, > - { { 0, 0, 0, 0, 0, 0 } } } }; > + { { 0, 0, 0, 0, 0, 0 } }, > + { { 0, 0, 0, 0, 0, 0 } }, > + { { 0, 0, 0, 0, 0, 0 } }, > + { { 0, 0, 0, 0, 0, 0 } }, > + { { 0, 0, 0, 0, 0, 0 } } } }; > static const struct IP_BASE NBIO_BASE =3D { { { { 0x00000000, 0x00000014= , 0x00000D20, 0x00010400, 0x0241B000, 0x04040000 } }, > - { { 0, 0, 0, 0, 0, 0 } }, > - { { 0, 0, 0, 0, 0, 0 } }, > - { { 0, 0, 0, 0, 0, 0 } }, > - { { 0, 0, 0, 0, 0, 0 } }, > - { { 0, 0, 0, 0, 0, 0 } } } }; > + { { 0, 0, 0, 0, 0, 0 } }, > + { { 0, 0, 0, 0, 0, 0 } }, > + { { 0, 0, 0, 0, 0, 0 } }, > + { { 0, 0, 0, 0, 0, 0 } }, > + { { 0, 0, 0, 0, 0, 0 } } } }; > > #define regBIF_BX_PF2_RSMU_INDEX = 0x0000 > #define regBIF_BX_PF2_RSMU_INDEX_BASE_IDX = 1 > -- > 2.17.1 >