Received: by 2002:a05:6359:6284:b0:131:369:b2a3 with SMTP id se4csp3314046rwb; Mon, 7 Aug 2023 11:22:25 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEYSGCuX7OYjWGwi2IyleyVCRzqwBMmvDakkmqcrOtmnDufFRJdyPGKG1P2uWLcjwSorZlt X-Received: by 2002:a05:6a00:2d13:b0:67b:f249:35e3 with SMTP id fa19-20020a056a002d1300b0067bf24935e3mr10348136pfb.26.1691432545471; Mon, 07 Aug 2023 11:22:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691432545; cv=none; d=google.com; s=arc-20160816; b=AsXZhXxqkFfghHaCvIINFh7HQt7Yn9KWv1k8RUR14njTuEeY3xrePS6sn0JgOx/CPy 7duew7+nlS39SS02w5YE7oGq0Al9+G9oX3XMFK49ikgSQbIBF2M2Wtdd9s0PAd4Kedpv arr1CnC+g6LJ9v+yMHOx+OX1zZhLh0kTRmySMAh5mRvl6N2Vb/cET35NYY5m01rZaPtU hnsITVZZBdTZnx9AfibiCizlKNr2idY/C5CDZrGdeWzXAa57txs89CuLaAX5bGk5W0vT WYdBRDJRw0+COi4nVyR0aEf42FYXOTtxhDKWelFymNOP/mfzfHpBwEQFfAlGVQ1rczso erAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:message-id:mime-version:date :dkim-signature; bh=+DH1RGsmuAo7vrM49oUA1O8QELPBtiixKmknDzKlrMs=; fh=ulraDtVjifu6RIxQMG1eG8kJQPLjeO5amD5PDUssFN8=; b=ntn9MkjdxohEsYTTd1y8pcAcrX/w/Jr/2RKrL8E23V+WPz6m6urD4NNuDCU65E37R2 7VOl9w4SU9u6RpgcKNAADAiwYECm+p/QKnXD5TF5mRMsNUAYVtrYSPsJEgac1TScxFKx JRnLznNGVjCFcAjmxlwc7jfJsWUQaYrvfphLsoBtN6lqzxDlLXYowFFnOMCVCttbmd4D 6Runm47k/60wUuAE+jlYf6pNWTNahDOYjngBB4pHVe0yggUk12Hh5oVQH54QDcRDsDBb /k6RQ6GhbCikaOEG7ZYLk3SLkzxRd7vOGkmhjeokHe+3w4uDUlsOTWrnpnL1Pir7+BQu ggtg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20221208 header.b=UcHqa2R4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n47-20020a056a000d6f00b0068795f00997si6043124pfv.108.2023.08.07.11.22.13; Mon, 07 Aug 2023 11:22:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20221208 header.b=UcHqa2R4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229643AbjHGQvC (ORCPT + 99 others); Mon, 7 Aug 2023 12:51:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55028 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229640AbjHGQvA (ORCPT ); Mon, 7 Aug 2023 12:51:00 -0400 Received: from mail-yw1-x114a.google.com (mail-yw1-x114a.google.com [IPv6:2607:f8b0:4864:20::114a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B32EB9D for ; Mon, 7 Aug 2023 09:50:59 -0700 (PDT) Received: by mail-yw1-x114a.google.com with SMTP id 00721157ae682-586a5ac5c29so41664667b3.1 for ; Mon, 07 Aug 2023 09:50:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1691427059; x=1692031859; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=+DH1RGsmuAo7vrM49oUA1O8QELPBtiixKmknDzKlrMs=; b=UcHqa2R41JL5C38LwWIBt1mJ8uByZE/Xlbtryhjq0yCeZ6PnmszUdnIGGJIDIeCLi8 izw5ctPRXAuigX+MwUivoQlyykmafMQntoahk+xwngh3F3EGGkXCPyGtgs7pDJHUztcc KgP4bdF8yo/CXbiMEgD74mER7n9AKk1iGRVqBEq7wfXQoeiJ+xiH7ifIbrHM4f5b2k4l IOoba3EUMrJutY0FqS3n3c6i49D0hNSdz7Q+U3XzX3L9+0JhBUN87PvlQGHGV67XrqX6 aqL2eFZEpykmK3Mg3eJCmPZlMl3hQE0z+z7JMNgBk1YUtISVT/vwtxVMll1SH7S/k/41 l7ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691427059; x=1692031859; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=+DH1RGsmuAo7vrM49oUA1O8QELPBtiixKmknDzKlrMs=; b=gr+yac4XzebsQCnewZMgWEUieIhh9JEztH6QgTdBlpBQuOUg6YO+bCFx6vNFWGBqFu RJROBchOkwSF6h+gl5arpBd3NiMmM0GBSE6ITa9HThqp3Rfw/D6fYC7hcEZKMXol49yd knkOEDWXR8Oc17DnsMbhJZz1IvzG92ORlGx+7DmuZiX1Q/tv3XV4OUejBTLuzU7PsaRM 8vQw4anfFi1H8dQ0EGy88vTrfGnoWZ2mT/iixio+dH0hiXWnSvRDewD1g+ARWkJ5NT7r /6WFCSqahqYBIPJJkA19z/Q4/TcEr81SebG7EQ7qJUXPJ8piZAvwOhbej2/uClNl/I9P 49Tw== X-Gm-Message-State: AOJu0YxN0w1V5Te9wgViyMmFE3v7duFJ1NAaJ6rcXF6PcjQqFybgMMgO yi7dMatPK05JTpVajspjLFqCfZd3SZGSL1FvVvU= X-Received: from ndesaulniers-desktop.svl.corp.google.com ([2620:15c:2d1:203:4746:957d:1a28:5104]) (user=ndesaulniers job=sendgmr) by 2002:a81:b144:0:b0:56f:f77c:3c7d with SMTP id p65-20020a81b144000000b0056ff77c3c7dmr77675ywh.3.1691427058981; Mon, 07 Aug 2023 09:50:58 -0700 (PDT) Date: Mon, 07 Aug 2023 09:50:32 -0700 Mime-Version: 1.0 X-B4-Tracking: v=1; b=H4sIANcg0WQC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE vPSU3UzU4B8JSMDI2MDCwNz3dzM4uLMvPT4gqL8knxdg+QkS4PUZDMTU5NkJaCegqLUtMwKsHn RsbW1AANxIeRfAAAA X-Developer-Key: i=ndesaulniers@google.com; a=ed25519; pk=UIrHvErwpgNbhCkRZAYSX0CFd/XFEwqX3D0xqtqjNug= X-Developer-Signature: v=1; a=ed25519-sha256; t=1691427057; l=1415; i=ndesaulniers@google.com; s=20220923; h=from:subject:message-id; bh=3s6B3WRHZwONDqr660gEy+YqAcQ7kOQd/SC/ue2x6Kc=; b=o9mPOXezO1m1peqnQnJ9Xh9NmpG6OGUleGqyCPai/FHu3L5j1iHQdxfIhbIC4aYIa1C1emYrj fT1jBNQi6XgDsLGtvc8W9xWd9BF1MF+sBN52XQfIibvFQNPns+iYt/y X-Mailer: b4 0.12.3 Message-ID: <20230807-missing_proto-v1-1-7f566b7ba5ca@google.com> Subject: [PATCH] Makefile.extrawarn: enable -Wmissing-variable-declarations for W=1 From: Nick Desaulniers To: Masahiro Yamada , Nathan Chancellor , Nicolas Schier , Tom Rix Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, Nick Desaulniers Content-Type: text/plain; charset="utf-8" X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I noticed Tom was sending patches where smatch was recommending annotating functions as static when no previous declaration existed. Surely the compiler could make such recommendations as well, I thought. Looks like -Wmissing-variable-declarations can make such recommendations. GCC just added support for this warning (gcc 14.1.0 will ship with support), and all versions of clang relevant to building the kernel support this flag. Signed-off-by: Nick Desaulniers --- scripts/Makefile.extrawarn | 1 + 1 file changed, 1 insertion(+) diff --git a/scripts/Makefile.extrawarn b/scripts/Makefile.extrawarn index 40cd13eca82e..617739eb84e2 100644 --- a/scripts/Makefile.extrawarn +++ b/scripts/Makefile.extrawarn @@ -32,6 +32,7 @@ KBUILD_CFLAGS += $(call cc-option, -Wunused-but-set-variable) KBUILD_CFLAGS += $(call cc-option, -Wunused-const-variable) KBUILD_CFLAGS += $(call cc-option, -Wpacked-not-aligned) KBUILD_CFLAGS += $(call cc-option, -Wstringop-truncation) +KBUILD_CFLAGS += $(call cc-option, -Wmissing-varibale-declarations) # The following turn off the warnings enabled by -Wextra KBUILD_CFLAGS += -Wno-missing-field-initializers KBUILD_CFLAGS += -Wno-sign-compare --- base-commit: 52a93d39b17dc7eb98b6aa3edb93943248e03b2f change-id: 20230807-missing_proto-0cb90ec6454c Best regards, -- Nick Desaulniers