Received: by 2002:a05:6359:6284:b0:131:369:b2a3 with SMTP id se4csp3315468rwb; Mon, 7 Aug 2023 11:24:08 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFvQGtxkmsl7EjsVoCjFUJh3E9mZcVhnI2KGmBkuq3Vz9SX/vWPgHz2rpQVAVVJZXzAE5EH X-Received: by 2002:a05:6a20:9151:b0:134:37bb:89be with SMTP id x17-20020a056a20915100b0013437bb89bemr9375289pzc.57.1691432648031; Mon, 07 Aug 2023 11:24:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691432648; cv=none; d=google.com; s=arc-20160816; b=DMBOEdQN3IhhpUFC8kxJepvt4MHiFYf5SeB7/6OGg9rB0tP/69LPsM4apWOnVL8cmJ UBui1qlwWxNKG9klhk5ZQfLASaNtDHxQsHSHNMUN+KG0cZDYI3SHMt0jSX5aU5vSAwQM aiU8wogyxukHAT5yzoq98SsHm+w03Lm+gXGfPe4LsLLlucMm7iMKZf0ZoY6TcZzR681u PiW5yWU3f8jsLyGz2nCYj6+IDzKphakAXDWhVxpJ4OEIXg6sCQLgvVZZDYQEw9UOva7U KclghnT4iE+8ylm6/wCexnRtFiFAYOL/CMa8h/t0Qa3aWZfTJKp6nh6psyEnhDsoLAC8 AFnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=n1fFiDl47tj0kGpFVmy5pI63q4LR33axRCdbXWh8XXc=; fh=YwR8hmjC2QSif+72cT3/sIS32/1FMEJSAUJ+j+OuTzU=; b=aTNKzESd+ht71YW5D174GkkMGBanjzYQ6aJ2C/Nt1cy/8RtZ0LcWmOtei5fxC1JzIj 6mN0zZvMXr/QNWcjG52VJEJQsEzHNcozhpeCvNdkC3foKUkS9436AyFRSUlPv6l5AfC+ Y7wtIaFdHAd72GF2mATTa+5B/bFqghcQy5FgeKNVdOLbiGZfJHR8neV0a9ZR76gs2ltl 0IstDz40zshJ9M+JkmzdbbY0SIQqx7tlgxBnAI2tO5iRoY1Ud42DjsMtvZ4jnEB5Kv5n 7sw8/Dfs3fJoVSBeIwSuOIZsptqYpUvMUurOifP4q62n9CyPKs76dk0YnhvjerxQaaRV bYbQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b="Dxv/yJ1p"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a26-20020a630b5a000000b00563deb65f93si5524587pgl.200.2023.08.07.11.23.56; Mon, 07 Aug 2023 11:24:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b="Dxv/yJ1p"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232122AbjHGRM2 (ORCPT + 99 others); Mon, 7 Aug 2023 13:12:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43478 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232078AbjHGRMO (ORCPT ); Mon, 7 Aug 2023 13:12:14 -0400 Received: from mail-oo1-xc2a.google.com (mail-oo1-xc2a.google.com [IPv6:2607:f8b0:4864:20::c2a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 340C219BA for ; Mon, 7 Aug 2023 10:12:05 -0700 (PDT) Received: by mail-oo1-xc2a.google.com with SMTP id 006d021491bc7-56cb1e602e7so2914552eaf.1 for ; Mon, 07 Aug 2023 10:12:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691428324; x=1692033124; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=n1fFiDl47tj0kGpFVmy5pI63q4LR33axRCdbXWh8XXc=; b=Dxv/yJ1pcK4dyFHi2blaRWsooeHDuJVqxDYsmx3LVyICVQ7gUd+DO1ddjkZHSLAk7f EcxaoiFdT0G5F01Nqg1UQLjI17n0RqJ1PrreI5L5bucMQSsGhxHM/HMhGi9abKNaK3oi f2luBXDYx9BylQ9olG46Veb8eHXZk0R/H/+sTGBCop3G113iOGbO3Kjax+nWjniQ20DW Hr7l0lV1iBzGVMs4o+lz0bQeCGPz/ajvCu2D8xpgYomMEy43wFFoIud812IjIKYwNTGe eQfU3W1uOdvk59laOm5gtyrOaMigl4L9H72rvRJkEl6Mj5fDCa0sCF5kpteaTHbu6ucT f4qA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691428324; x=1692033124; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=n1fFiDl47tj0kGpFVmy5pI63q4LR33axRCdbXWh8XXc=; b=ThLzamFz3X/brFe14TytnRovuW2t5HluWKYkCkUP+Wf0/gLQesAsA5kVTOIjuT2Q5t HxeyJF5khhBNG80Js9GfeWP1llTHYcIgXOHYYacjGpq0aRC005qEg1NFy4W/jeWMJRNP S//srDhPgKRaAkY7z3HJvivSZPjlcvgtEB3SM7Gh9vxah4xGpVvj4UPAMsQU0fd8HmNF bzgZKp0jag1JLsaAy7Rq68Nucdl92Njml9z/Uz+GskQw5SV7VVmzf2KuOAoD0gJInXZn q41w+3783sZO/Wnhl0p+oYuQpAvWzorKBXnEaIr5Us68u2UYXPOawV4xK7naOqXXU7ba 0qQg== X-Gm-Message-State: AOJu0YzHMiRr9ZLxjeV5Dud1iHx6K4HRIAzDN1GnLQIPhBBrf8KE0bJL tiPFMvKcOAVmCXWzWBzXjUsjNO7mdcgf6XVxQeo= X-Received: by 2002:a4a:d2dc:0:b0:56c:43cd:7267 with SMTP id j28-20020a4ad2dc000000b0056c43cd7267mr8345158oos.8.1691428324097; Mon, 07 Aug 2023 10:12:04 -0700 (PDT) MIME-Version: 1.0 References: <20230802030311.10746-1-sunran001@208suo.com> In-Reply-To: <20230802030311.10746-1-sunran001@208suo.com> From: Alex Deucher Date: Mon, 7 Aug 2023 13:11:53 -0400 Message-ID: Subject: Re: [PATCH] drm/amd/display: Clean up errors in dcn316_smu.c To: Ran Sun Cc: alexander.deucher@amd.com, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Applied. Thanks! On Tue, Aug 1, 2023 at 11:03=E2=80=AFPM Ran Sun wrot= e: > > Fix the following errors reported by checkpatch: > > ERROR: open brace '{' following struct go on the same line > ERROR: code indent should use tabs where possible > > Signed-off-by: Ran Sun > --- > .../amd/display/dc/clk_mgr/dcn316/dcn316_smu.c | 18 ++++++++---------- > 1 file changed, 8 insertions(+), 10 deletions(-) > > diff --git a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn316/dcn316_smu.c b= /drivers/gpu/drm/amd/display/dc/clk_mgr/dcn316/dcn316_smu.c > index 457a9254ae1c..3ed19197a755 100644 > --- a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn316/dcn316_smu.c > +++ b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn316/dcn316_smu.c > @@ -34,23 +34,21 @@ > #define MAX_INSTANCE 7 > #define MAX_SEGMENT 6 > > -struct IP_BASE_INSTANCE > -{ > +struct IP_BASE_INSTANCE { > unsigned int segment[MAX_SEGMENT]; > }; > > -struct IP_BASE > -{ > +struct IP_BASE { > struct IP_BASE_INSTANCE instance[MAX_INSTANCE]; > }; > > static const struct IP_BASE MP0_BASE =3D { { { { 0x00016000, 0x00DC0000,= 0x00E00000, 0x00E40000, 0x0243FC00, 0 } }, > - { { 0, 0, 0, 0, 0, 0 } }, > - { { 0, 0, 0, 0, 0, 0 } }, > - { { 0, 0, 0, 0, 0, 0 } }, > - { { 0, 0, 0, 0, 0, 0 } }, > - { { 0, 0, 0, 0, 0, 0 } }, > - { { 0, 0, 0, 0, 0, 0 } } } }; > + { { 0, 0, 0, 0, 0, 0 } }, > + { { 0, 0, 0, 0, 0, 0 } }, > + { { 0, 0, 0, 0, 0, 0 } }, > + { { 0, 0, 0, 0, 0, 0 } }, > + { { 0, 0, 0, 0, 0, 0 } }, > + { { 0, 0, 0, 0, 0, 0 } } } }; > > #define REG(reg_name) \ > (MP0_BASE.instance[0].segment[reg ## reg_name ## _BASE_IDX] + reg= ## reg_name) > -- > 2.17.1 >