Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230802074315.13688-1-sunran001@208suo.com>
In-Reply-To: <20230802074315.13688-1-sunran001@208suo.com>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Mon, 7 Aug 2023 13:31:37 -0400
Message-ID: <CADnq5_PYnyF4JB5vWYydcWziaAyULWmxayZN6q+-iYnCBohO+A@mail.gmail.com>
Subject: Re: [PATCH] drm/amdgpu: Clean up errors in vcn_v4_0.c
To:     Ran Sun <sunran001@208suo.com>
Cc:     alexander.deucher@amd.com, dri-devel@lists.freedesktop.org,
        amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Applied.  Thanks!

On Wed, Aug 2, 2023 at 3:43=E2=80=AFAM Ran Sun <sunran001@208suo.com> wrote=
:
>
> Fix the following errors reported by checkpatch:
>
> spaces required around that '=3D=3D' (ctx:VxV)
> ERROR: space required before the open parenthesis '('
> ERROR: that open brace { should be on the previous line
>
> Signed-off-by: Ran Sun <sunran001@208suo.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c | 11 +++++------
>  1 file changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c b/drivers/gpu/drm/amd/=
amdgpu/vcn_v4_0.c
> index 6089c7deba8a..ef5b16061e96 100644
> --- a/drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c
> @@ -1139,11 +1139,11 @@ static int vcn_v4_0_start(struct amdgpu_device *a=
dev)
>                                 if (status & 2)
>                                         break;
>                                 mdelay(10);
> -                               if (amdgpu_emu_mode=3D=3D1)
> +                               if (amdgpu_emu_mode =3D=3D 1)
>                                         msleep(1);
>                         }
>
> -                       if (amdgpu_emu_mode=3D=3D1) {
> +                       if (amdgpu_emu_mode =3D=3D 1) {
>                                 r =3D -1;
>                                 if (status & 2) {
>                                         r =3D 0;
> @@ -1959,7 +1959,7 @@ static int vcn_v4_0_set_powergating_state(void *han=
dle, enum amd_powergating_sta
>                 return 0;
>         }
>
> -       if(state =3D=3D adev->vcn.cur_state)
> +       if (state =3D=3D adev->vcn.cur_state)
>                 return 0;
>
>         if (state =3D=3D AMD_PG_STATE_GATE)
> @@ -1967,7 +1967,7 @@ static int vcn_v4_0_set_powergating_state(void *han=
dle, enum amd_powergating_sta
>         else
>                 ret =3D vcn_v4_0_start(adev);
>
> -       if(!ret)
> +       if (!ret)
>                 adev->vcn.cur_state =3D state;
>
>         return ret;
> @@ -2101,8 +2101,7 @@ static const struct amd_ip_funcs vcn_v4_0_ip_funcs =
=3D {
>         .set_powergating_state =3D vcn_v4_0_set_powergating_state,
>  };
>
> -const struct amdgpu_ip_block_version vcn_v4_0_ip_block =3D
> -{
> +const struct amdgpu_ip_block_version vcn_v4_0_ip_block =3D {
>         .type =3D AMD_IP_BLOCK_TYPE_VCN,
>         .major =3D 4,
>         .minor =3D 0,
> --
> 2.17.1
>