Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230802070632.12626-1-sunran001@208suo.com>
In-Reply-To: <20230802070632.12626-1-sunran001@208suo.com>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Mon, 7 Aug 2023 13:24:18 -0400
Message-ID: <CADnq5_NqVzu4gxx9dM3ALQCi-SRfqG_BfrhcQqB3X=aj14aAGw@mail.gmail.com>
Subject: Re: [PATCH] drm/amdgpu: Clean up errors in mxgpu_nv.c
To:     Ran Sun <sunran001@208suo.com>
Cc:     alexander.deucher@amd.com, dri-devel@lists.freedesktop.org,
        amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Applied.  Thanks!

On Wed, Aug 2, 2023 at 3:06=E2=80=AFAM Ran Sun <sunran001@208suo.com> wrote=
:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: else should follow close brace '}'
> ERROR: that open brace { should be on the previous line
>
> Signed-off-by: Ran Sun <sunran001@208suo.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/mxgpu_nv.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/mxgpu_nv.c b/drivers/gpu/drm/amd/=
amdgpu/mxgpu_nv.c
> index cae1aaa4ddb6..6a68ee946f1c 100644
> --- a/drivers/gpu/drm/amd/amdgpu/mxgpu_nv.c
> +++ b/drivers/gpu/drm/amd/amdgpu/mxgpu_nv.c
> @@ -183,12 +183,10 @@ static int xgpu_nv_send_access_requests(struct amdg=
pu_device *adev,
>                         if (req !=3D IDH_REQ_GPU_INIT_DATA) {
>                                 pr_err("Doesn't get msg:%d from pf, error=
=3D%d\n", event, r);
>                                 return r;
> -                       }
> -                       else /* host doesn't support REQ_GPU_INIT_DATA ha=
ndshake */
> +                       } else /* host doesn't support REQ_GPU_INIT_DATA =
handshake */
>                                 adev->virt.req_init_data_ver =3D 0;
>                 } else {
> -                       if (req =3D=3D IDH_REQ_GPU_INIT_DATA)
> -                       {
> +                       if (req =3D=3D IDH_REQ_GPU_INIT_DATA) {
>                                 adev->virt.req_init_data_ver =3D
>                                         RREG32_NO_KIQ(mmMAILBOX_MSGBUF_RC=
V_DW1);
>
> --
> 2.17.1
>