Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230802071201.12717-1-sunran001@208suo.com>
In-Reply-To: <20230802071201.12717-1-sunran001@208suo.com>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Mon, 7 Aug 2023 13:24:53 -0400
Message-ID: <CADnq5_O6H-YLDHxDM0baTpmLgrfdASsyFX4CPRQfZ9WyD8_ZRg@mail.gmail.com>
Subject: Re: [PATCH] drm/amdgpu/jpeg: Clean up errors in vcn_v1_0.c
To:     Ran Sun <sunran001@208suo.com>
Cc:     alexander.deucher@amd.com, dri-devel@lists.freedesktop.org,
        amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Applied.  Thanks!

On Wed, Aug 2, 2023 at 3:12=E2=80=AFAM Ran Sun <sunran001@208suo.com> wrote=
:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: space required before the open parenthesis '('
> ERROR: space prohibited after that '~' (ctx:WxW)
>
> Signed-off-by: Ran Sun <sunran001@208suo.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c b/drivers/gpu/drm/amd/=
amdgpu/vcn_v1_0.c
> index 16feb491adf5..25ba27151ac0 100644
> --- a/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c
> @@ -473,7 +473,7 @@ static void vcn_v1_0_disable_clock_gating(struct amdg=
pu_device *adev)
>         if (adev->cg_flags & AMD_CG_SUPPORT_VCN_MGCG)
>                 data |=3D 1 << UVD_CGC_CTRL__DYN_CLOCK_MODE__SHIFT;
>         else
> -               data &=3D ~ UVD_CGC_CTRL__DYN_CLOCK_MODE_MASK;
> +               data &=3D ~UVD_CGC_CTRL__DYN_CLOCK_MODE_MASK;
>
>         data |=3D 1 << UVD_CGC_CTRL__CLK_GATE_DLY_TIMER__SHIFT;
>         data |=3D 4 << UVD_CGC_CTRL__CLK_OFF_DELAY__SHIFT;
> @@ -1772,7 +1772,7 @@ static int vcn_v1_0_set_powergating_state(void *han=
dle,
>         int ret;
>         struct amdgpu_device *adev =3D (struct amdgpu_device *)handle;
>
> -       if(state =3D=3D adev->vcn.cur_state)
> +       if (state =3D=3D adev->vcn.cur_state)
>                 return 0;
>
>         if (state =3D=3D AMD_PG_STATE_GATE)
> @@ -1780,7 +1780,7 @@ static int vcn_v1_0_set_powergating_state(void *han=
dle,
>         else
>                 ret =3D vcn_v1_0_start(adev);
>
> -       if(!ret)
> +       if (!ret)
>                 adev->vcn.cur_state =3D state;
>         return ret;
>  }
> @@ -2065,8 +2065,7 @@ static void vcn_v1_0_set_irq_funcs(struct amdgpu_de=
vice *adev)
>         adev->vcn.inst->irq.funcs =3D &vcn_v1_0_irq_funcs;
>  }
>
> -const struct amdgpu_ip_block_version vcn_v1_0_ip_block =3D
> -{
> +const struct amdgpu_ip_block_version vcn_v1_0_ip_block =3D {
>                 .type =3D AMD_IP_BLOCK_TYPE_VCN,
>                 .major =3D 1,
>                 .minor =3D 0,
> --
> 2.17.1
>