Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Rahul Rameshbabu <rrameshbabu@nvidia.com>
To:     Jiri Kosina <jikos@kernel.org>,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc:     linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
        Rahul Rameshbabu <rrameshbabu@nvidia.com>
Subject: [PATCH 3/3] HID: nvidia-shield: Update Thunderstrike LED instance name to use id
Date:   Mon,  7 Aug 2023 09:36:20 -0700
Message-Id: <20230807163620.16855-3-rrameshbabu@nvidia.com>
In-Reply-To: <20230807163620.16855-1-rrameshbabu@nvidia.com>
References: <20230807163620.16855-1-rrameshbabu@nvidia.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?97uLySpM2XMihRo/G4rESNv1SExPzIC4rnJckupDytJHhhOnquuy357thDsm?=
 =?us-ascii?Q?iV1P3hdn3jipojPg3o+azan837WUcCJJg//5DaokdAskq1k0IRlAiK6V1JY8?=
 =?us-ascii?Q?6CkjJj6rz0euXcMNgFfOhqbEObq66Ha1S2gP9e7O8eVqzUXWxSV4omRwAbIl?=
 =?us-ascii?Q?yiJ6psqm3P40v2Jd2vdwh135OEsKCYqRr4ZymWmUVLafyHOtRbxiUSBBitA8?=
 =?us-ascii?Q?HVEto7rXPXgcrWWoXrCl++z82/ykAH2zs2xBPdXenuBlT8Gz7isPgKV2slxD?=
 =?us-ascii?Q?xeeRsR3iAE+v6iY17PxRZDqyytUdLy1EZ25E1Lo8ryitJvde/wwtUtSxxqrm?=
 =?us-ascii?Q?e1HtaCRDSmCEnNzSkoh+3rn0G1aLs5fiaPj9wSWW+uD31nbTHBGkNxCeA6Rz?=
 =?us-ascii?Q?cB94QgNVAe9oZ69bnxXyNHr07ZmbQinz4xKOoBrXvpPWBDN5eoIgQ2K2RZtC?=
 =?us-ascii?Q?ppycIpcgXY47L3IB6yQdSkjJIkHLbHoP/1C/6dTAhXb66752mKkgf9xGhlsH?=
 =?us-ascii?Q?5I858vRYF0lGeFJ988XiFPyF+BUqiw3A/+JhQvM5DSrCf9EoATxL8wpYxlV5?=
 =?us-ascii?Q?cK+K9fdl0wjHYChurVlnH8TJZPqNK5YrKtAKY2tOY/GF3NneLKeqn6Xz0a72?=
 =?us-ascii?Q?MLoJ48RylpiGRzUlhygTwxwUrqL+ikEkpmx1bT58bPcgDRJXokve7EcvkZI5?=
 =?us-ascii?Q?ls2RKS0iIgPBJp2KyZ8xBCkkzx3b3MHU8m8dfsGXiMG1AWnhsqBuF9qvDyX5?=
 =?us-ascii?Q?Us4kzd4FGvzA9RcoqxJqtjda8AwLIlaniVKo3ujOIK8RyVCcUETgEIhzbRdv?=
 =?us-ascii?Q?2t0pCEfoy6hbOicR+AAAjEaSUo7dfPKJlBmzAxWzfeR4nrePdOIfKlSkywIG?=
 =?us-ascii?Q?yBGUhSjWK5OdiisO7GEJXdLAHHLP3jzTyNFmIiZmgSgmGAxWdFHWK5yOs0ij?=
 =?us-ascii?Q?PzENwMm2hnG2BV7TzyueOKnEahFTHcojpDOKudal9ripSUYSXitOLYRtaFB0?=
 =?us-ascii?Q?tRSVp7vEhobwQ0sljugtRKgYu2sGp4PI0VkxI02x/L1JEi3lUbfE1Kl9tWEU?=
 =?us-ascii?Q?JAj8dUbi/kwU1HfFIi9oy+EUVZUL+nyonM35+zvtj8vyqTvLkCr63YqEAsl3?=
 =?us-ascii?Q?nSrlohj+0z2v7ySCyT8Pt7KTd3D0WN41w+QDsAqkqF7lUJM9YsV3PjRwZVAK?=
 =?us-ascii?Q?ZJ4s/VJsHFi0p00durYuTA7ZVHdxkpLEZ8Kp4xrSJzGxebtgLkktpyLjwM2X?=
 =?us-ascii?Q?dCYlwyLz+GACWUeBZ2xwZLah08DdlVdsFRnPOlkKZfikigI0h2R+U+45eLM0?=
 =?us-ascii?Q?rc7iQYkBpKBLohGmTr27ROK2O/E6SZ6v8jyxO700ILxDPyBPs80h9vFhwNwb?=
 =?us-ascii?Q?B309AZKk7XqV/L8YMKouI7N0wgoqZyZnn7Lqvk8FP4QuXS44xMWfBGQblnyl?=
 =?us-ascii?Q?gbomF1/C1zy9vK1yCWCGlIe2kuka/9SdVjJHo6utPmOQlme9WZvMTeGsSEEw?=
 =?us-ascii?Q?4QAXMKWEGdoRiJLIAiDPNsOAUpr0zohfRlhdMufjBItd8WtlIxIerOMdnCww?=
 =?us-ascii?Q?R/L4ZjYCRMLz6+4fMgK6N8XRhHeetYXD+ppD4pyQrr4PlJjT5c0Co1dytGcu?=
 =?us-ascii?Q?/g=3D=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 946cc96c-4c3a-429b-da1d-08db976474ba
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB2743.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2023 16:36:31.5418
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DPFY4FsNnvxlVM08jAAVqftabKGpu1F6GID1x4UzeZVTZAsNb7fWZeGVxZbtbLsbjoPR33pk8QUUF82jqub+Mg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB8194
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Previously would let led_classdev handle renaming when name collision
occurred. Now that an ID allocator is used to uniquely identify multiple
Thunderstrike controllers, generate unique led device names.

Signed-off-by: Rahul Rameshbabu <rrameshbabu@nvidia.com>
---
 drivers/hid/hid-nvidia-shield.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/hid/hid-nvidia-shield.c b/drivers/hid/hid-nvidia-shield.c
index 1612de3ef4c5..43784bb57d3f 100644
--- a/drivers/hid/hid-nvidia-shield.c
+++ b/drivers/hid/hid-nvidia-shield.c
@@ -798,7 +798,8 @@ static inline int thunderstrike_led_create(struct thunderstrike *ts)
 {
 	struct led_classdev *led = &ts->led_dev;
 
-	led->name = "thunderstrike:blue:led";
+	led->name = devm_kasprintf(&ts->base.hdev->dev, GFP_KERNEL,
+				   "thunderstrike%d:blue:led", ts->id);
 	led->max_brightness = 1;
 	led->flags = LED_CORE_SUSPENDRESUME;
 	led->brightness_get = &thunderstrike_led_get_brightness;
-- 
2.40.1