Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230801093656.7761-1-sunran001@208suo.com>
In-Reply-To: <20230801093656.7761-1-sunran001@208suo.com>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Mon, 7 Aug 2023 12:48:24 -0400
Message-ID: <CADnq5_N8PzxV27cpYsw9MBe2dDvt7Ba7Pjf1d_O8hpEgSjJZCg@mail.gmail.com>
Subject: Re: [PATCH] drm/amd/pm/powerplay/hwmgr/hwmgr: Clean up errors in hwmgr.c
To:     Ran Sun <sunran001@208suo.com>
Cc:     alexander.deucher@amd.com, airlied@gmail.com, daniel@ffwll.ch,
        dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Applied.  Thanks!

On Tue, Aug 1, 2023 at 5:37=E2=80=AFAM Ran Sun <sunran001@208suo.com> wrote=
:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: space prohibited after that '~' (ctx:WxW)
> ERROR: spaces required around that '||' (ctx:VxW)
>
> Signed-off-by: Ran Sun <sunran001@208suo.com>
> ---
>  drivers/gpu/drm/amd/pm/powerplay/hwmgr/hwmgr.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/hwmgr.c b/drivers/gpu=
/drm/amd/pm/powerplay/hwmgr/hwmgr.c
> index f2cef0930aa9..2b5ac21fee39 100644
> --- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/hwmgr.c
> +++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/hwmgr.c
> @@ -120,7 +120,7 @@ int hwmgr_early_init(struct pp_hwmgr *hwmgr)
>                 case CHIP_TOPAZ:
>                         hwmgr->smumgr_funcs =3D &iceland_smu_funcs;
>                         topaz_set_asic_special_caps(hwmgr);
> -                       hwmgr->feature_mask &=3D ~ (PP_VBI_TIME_SUPPORT_M=
ASK |
> +                       hwmgr->feature_mask &=3D ~(PP_VBI_TIME_SUPPORT_MA=
SK |
>                                                 PP_ENABLE_GFX_CG_THRU_SMU=
);
>                         hwmgr->pp_table_version =3D PP_TABLE_V0;
>                         hwmgr->od_enabled =3D false;
> @@ -133,7 +133,7 @@ int hwmgr_early_init(struct pp_hwmgr *hwmgr)
>                 case CHIP_FIJI:
>                         hwmgr->smumgr_funcs =3D &fiji_smu_funcs;
>                         fiji_set_asic_special_caps(hwmgr);
> -                       hwmgr->feature_mask &=3D ~ (PP_VBI_TIME_SUPPORT_M=
ASK |
> +                       hwmgr->feature_mask &=3D ~(PP_VBI_TIME_SUPPORT_MA=
SK |
>                                                 PP_ENABLE_GFX_CG_THRU_SMU=
);
>                         break;
>                 case CHIP_POLARIS11:
> @@ -195,7 +195,7 @@ int hwmgr_early_init(struct pp_hwmgr *hwmgr)
>
>  int hwmgr_sw_init(struct pp_hwmgr *hwmgr)
>  {
> -       if (!hwmgr|| !hwmgr->smumgr_funcs || !hwmgr->smumgr_funcs->smu_in=
it)
> +       if (!hwmgr || !hwmgr->smumgr_funcs || !hwmgr->smumgr_funcs->smu_i=
nit)
>                 return -EINVAL;
>
>         phm_register_irq_handlers(hwmgr);
> --
> 2.17.1
>