Received: by 2002:a05:6359:6284:b0:131:369:b2a3 with SMTP id se4csp3387088rwb; Mon, 7 Aug 2023 12:40:45 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEtkisMo+pe57toGzGKPNVgeDUYVKy6wuCJoJvoyPgjTC95XOR7pud+ED962EQPz2BDzEMD X-Received: by 2002:a05:6a20:12d0:b0:133:6816:c889 with SMTP id v16-20020a056a2012d000b001336816c889mr12846768pzg.40.1691437245540; Mon, 07 Aug 2023 12:40:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691437245; cv=none; d=google.com; s=arc-20160816; b=on+f4IW6Z1g0z7Xrw45iqU/rOJN1j2ZLbR3mInrDQ5uMn0Rl1ESTtq6EZSvVw+8ubB z4s8GaySKi/IeHAC3KkkUD5LJPRZCjc1V2J9L2Cp+Xh1hv0PSG0+GGd/9O8iqbvYm5Jb gTcxqj4jEFdiC1GLjEanM1pTGYsFgoLRfjYWuin3e68dltxv6o7AP4loCRULr5aWkpii lhe3us4C68JTHA6wkkmJRb9b7nzaIv3KBA7BSWmVPLZc8fBjkkrSsZ0wCMG39g2TjQKj vGwBykKjbzn5LaHbcyUgP2glLbn9zb5sx/P+7UhaYUklt3zp575iCXyrIqbAYYr1ptIJ qTDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=CSOWVrjZ1/u9To54jiA15JDLcV2I1XHj1QAMnIKhAvY=; fh=YwR8hmjC2QSif+72cT3/sIS32/1FMEJSAUJ+j+OuTzU=; b=UeM9dBFc5NIr8TOSEUBw1UTxoNTCDUem1opo4WlwEl7iGbTlS/vIRs/fMI1oq940KB d9CvPAzK4Pc68iGNjug9i1TlTUpPdn9N+iRvIgRq6Ro2L+Dipc8nWLKvMtEqFBM8LBIC LyqXb8TtU4/MjJtPYf0E0YeTAbnsEe2MWoLloKtuDRoEyUmyAKE615ONG8oyZLltuepV FslKAJqNKVu7mWG0c6VYGV2GbUs35HZmNEqZOWk8d7ilsSIxxkNoWqgsRYSqh8bUymiy fqsiYmcOezKfl4IdsJ1UafHiyKQgyzrnSlJoDSEv86Sy6SQ4yF5M9v5GqeoHnCFSWkkq 83/A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=scuOA7ac; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 36-20020a630c64000000b00563e9d3d78csi5894890pgm.422.2023.08.07.12.40.32; Mon, 07 Aug 2023 12:40:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=scuOA7ac; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232163AbjHGR0V (ORCPT + 99 others); Mon, 7 Aug 2023 13:26:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60316 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230308AbjHGR0U (ORCPT ); Mon, 7 Aug 2023 13:26:20 -0400 Received: from mail-oi1-x230.google.com (mail-oi1-x230.google.com [IPv6:2607:f8b0:4864:20::230]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0A06EF9 for ; Mon, 7 Aug 2023 10:26:18 -0700 (PDT) Received: by mail-oi1-x230.google.com with SMTP id 5614622812f47-3a78a2c0f81so1571267b6e.0 for ; Mon, 07 Aug 2023 10:26:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691429177; x=1692033977; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=CSOWVrjZ1/u9To54jiA15JDLcV2I1XHj1QAMnIKhAvY=; b=scuOA7ac5toaJ55K4HcKWCHf+y9/KRko3nm0b2dp7tiEtLP/mHWWtrzGVarrKClqZ2 nAV2UNP3Xmw2LjuWLSQri0TO6ZQRdStQ3OUySRdMZu1rHxgjcIgGuTndjgCnFDhwkWNf Q2kTu7A34vC0xJMsWFysuLy24ib3d4MJWJRybTw6uOibnqX5An7404wPNV+2MSLOADet 9vkGQpE22x30LHyy9KUBNF7cWDgsTaIczRB8rmIxIe5xLo9Lw/3AvJY8Fuq6+9vOivyH R7Rr8HmIQULCm3oiCkyGJD++nyniXbTrUPv44+xW0osY7fEfCZSDuGNJ+CAQRr9on78R NDiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691429177; x=1692033977; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CSOWVrjZ1/u9To54jiA15JDLcV2I1XHj1QAMnIKhAvY=; b=OXCDek1G46M8miOziLz6Egp6TH8JptdntOj2Vy/DtT/Jmm8wpj7jtUtwq0Y7Zix14Y WBPzRlghEq2OXoRL48TiixTLihBO5rqJ+28H13qtR+zIAkJL9Q+jvKslGQIAjsMCty5v NBbFGwkQpzVHgh4IlWfwF4j8Bty4TGY2UJ9HFx8GHDWgf/VpYwRyhGCZVtepdTHwi0fr 75xxAB8ICcUBGx1aEUnhynmkqxp9kszRnRi1r3FgEwXqWRhvrrMiQEDm89ArvozL/Tpk 7ldXAuVq3AQkj8+cem7XWRlI/mYBBVHWydGAIU5z0f4gRgQe+7vg7oJDiAjPTpeyYabv hRAg== X-Gm-Message-State: AOJu0YxaAvUJuvwXeAmTd3TjC9itVuiXpyQaWyfyTZtDZnagRcENWaPd SkX9/OBwTHkUH9UQQHL5zNTirjcZnRBZj4RzZtA= X-Received: by 2002:a05:6808:1410:b0:3a3:640d:ed71 with SMTP id w16-20020a056808141000b003a3640ded71mr14211892oiv.10.1691429177306; Mon, 07 Aug 2023 10:26:17 -0700 (PDT) MIME-Version: 1.0 References: <20230802072127.12896-1-sunran001@208suo.com> In-Reply-To: <20230802072127.12896-1-sunran001@208suo.com> From: Alex Deucher Date: Mon, 7 Aug 2023 13:26:06 -0400 Message-ID: Subject: Re: [PATCH] drm/amdgpu: Clean up errors in soc21.c To: Ran Sun Cc: alexander.deucher@amd.com, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Applied. Thanks! On Wed, Aug 2, 2023 at 3:21=E2=80=AFAM Ran Sun wrote= : > > Fix the following errors reported by checkpatch: > > ERROR: that open brace { should be on the previous line > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/amdgpu/soc21.c | 30 ++++++++++-------------------- > 1 file changed, 10 insertions(+), 20 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/soc21.c b/drivers/gpu/drm/amd/amd= gpu/soc21.c > index e5e5d68a4d70..4f3ecd66eb6b 100644 > --- a/drivers/gpu/drm/amd/amdgpu/soc21.c > +++ b/drivers/gpu/drm/amd/amdgpu/soc21.c > @@ -48,33 +48,28 @@ > static const struct amd_ip_funcs soc21_common_ip_funcs; > > /* SOC21 */ > -static const struct amdgpu_video_codec_info vcn_4_0_0_video_codecs_encod= e_array_vcn0[] =3D > -{ > +static const struct amdgpu_video_codec_info vcn_4_0_0_video_codecs_encod= e_array_vcn0[] =3D { > {codec_info_build(AMDGPU_INFO_VIDEO_CAPS_CODEC_IDX_MPEG4_AVC, 409= 6, 2304, 0)}, > {codec_info_build(AMDGPU_INFO_VIDEO_CAPS_CODEC_IDX_HEVC, 4096, 23= 04, 0)}, > {codec_info_build(AMDGPU_INFO_VIDEO_CAPS_CODEC_IDX_AV1, 8192, 435= 2, 0)}, > }; > > -static const struct amdgpu_video_codec_info vcn_4_0_0_video_codecs_encod= e_array_vcn1[] =3D > -{ > +static const struct amdgpu_video_codec_info vcn_4_0_0_video_codecs_encod= e_array_vcn1[] =3D { > {codec_info_build(AMDGPU_INFO_VIDEO_CAPS_CODEC_IDX_MPEG4_AVC, 409= 6, 2304, 0)}, > {codec_info_build(AMDGPU_INFO_VIDEO_CAPS_CODEC_IDX_HEVC, 4096, 23= 04, 0)}, > }; > > -static const struct amdgpu_video_codecs vcn_4_0_0_video_codecs_encode_vc= n0 =3D > -{ > +static const struct amdgpu_video_codecs vcn_4_0_0_video_codecs_encode_vc= n0 =3D { > .codec_count =3D ARRAY_SIZE(vcn_4_0_0_video_codecs_encode_array_v= cn0), > .codec_array =3D vcn_4_0_0_video_codecs_encode_array_vcn0, > }; > > -static const struct amdgpu_video_codecs vcn_4_0_0_video_codecs_encode_vc= n1 =3D > -{ > +static const struct amdgpu_video_codecs vcn_4_0_0_video_codecs_encode_vc= n1 =3D { > .codec_count =3D ARRAY_SIZE(vcn_4_0_0_video_codecs_encode_array_v= cn1), > .codec_array =3D vcn_4_0_0_video_codecs_encode_array_vcn1, > }; > > -static const struct amdgpu_video_codec_info vcn_4_0_0_video_codecs_decod= e_array_vcn0[] =3D > -{ > +static const struct amdgpu_video_codec_info vcn_4_0_0_video_codecs_decod= e_array_vcn0[] =3D { > {codec_info_build(AMDGPU_INFO_VIDEO_CAPS_CODEC_IDX_MPEG4_AVC, 409= 6, 4096, 52)}, > {codec_info_build(AMDGPU_INFO_VIDEO_CAPS_CODEC_IDX_HEVC, 8192, 43= 52, 186)}, > {codec_info_build(AMDGPU_INFO_VIDEO_CAPS_CODEC_IDX_JPEG, 4096, 40= 96, 0)}, > @@ -82,22 +77,19 @@ static const struct amdgpu_video_codec_info vcn_4_0_0= _video_codecs_decode_array_ > {codec_info_build(AMDGPU_INFO_VIDEO_CAPS_CODEC_IDX_AV1, 8192, 435= 2, 0)}, > }; > > -static const struct amdgpu_video_codec_info vcn_4_0_0_video_codecs_decod= e_array_vcn1[] =3D > -{ > +static const struct amdgpu_video_codec_info vcn_4_0_0_video_codecs_decod= e_array_vcn1[] =3D { > {codec_info_build(AMDGPU_INFO_VIDEO_CAPS_CODEC_IDX_MPEG4_AVC, 409= 6, 4096, 52)}, > {codec_info_build(AMDGPU_INFO_VIDEO_CAPS_CODEC_IDX_HEVC, 8192, 43= 52, 186)}, > {codec_info_build(AMDGPU_INFO_VIDEO_CAPS_CODEC_IDX_JPEG, 4096, 40= 96, 0)}, > {codec_info_build(AMDGPU_INFO_VIDEO_CAPS_CODEC_IDX_VP9, 8192, 435= 2, 0)}, > }; > > -static const struct amdgpu_video_codecs vcn_4_0_0_video_codecs_decode_vc= n0 =3D > -{ > +static const struct amdgpu_video_codecs vcn_4_0_0_video_codecs_decode_vc= n0 =3D { > .codec_count =3D ARRAY_SIZE(vcn_4_0_0_video_codecs_decode_array_v= cn0), > .codec_array =3D vcn_4_0_0_video_codecs_decode_array_vcn0, > }; > > -static const struct amdgpu_video_codecs vcn_4_0_0_video_codecs_decode_vc= n1 =3D > -{ > +static const struct amdgpu_video_codecs vcn_4_0_0_video_codecs_decode_vc= n1 =3D { > .codec_count =3D ARRAY_SIZE(vcn_4_0_0_video_codecs_decode_array_v= cn1), > .codec_array =3D vcn_4_0_0_video_codecs_decode_array_vcn1, > }; > @@ -445,8 +437,7 @@ static void soc21_program_aspm(struct amdgpu_device *= adev) > adev->nbio.funcs->program_aspm(adev); > } > > -const struct amdgpu_ip_block_version soc21_common_ip_block =3D > -{ > +const struct amdgpu_ip_block_version soc21_common_ip_block =3D { > .type =3D AMD_IP_BLOCK_TYPE_COMMON, > .major =3D 1, > .minor =3D 0, > @@ -547,8 +538,7 @@ static int soc21_update_umd_stable_pstate(struct amdg= pu_device *adev, > return 0; > } > > -static const struct amdgpu_asic_funcs soc21_asic_funcs =3D > -{ > +static const struct amdgpu_asic_funcs soc21_asic_funcs =3D { > .read_disabled_bios =3D &soc21_read_disabled_bios, > .read_bios_from_rom =3D &amdgpu_soc15_read_bios_from_rom, > .read_register =3D &soc21_read_register, > -- > 2.17.1 >