Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 7 Aug 2023 19:17:58 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Alexandru Ardelean <alex@shruggie.ro>
Cc:     Andrei Coardos <aboutphysycs@gmail.com>,
        linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
        nick.hawkins@hpe.com, verdun@hpe.com
Subject: Re: [PATCH] spi: gxp: removed unneeded call to platform_set_drvdata()
Message-ID: <196642e7-4136-4ba6-a918-8c759f27f818@sirena.org.uk>
References: <20230807130217.17853-1-aboutphysycs@gmail.com>
 <c867e685-7665-420b-9478-bce6eb067463@sirena.org.uk>
 <CAH3L5Qrzk-7WoF8+GKMYS40Dj_fxGpiLrTvVB_PJdA_VZVsDAQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="7gwrvj5+w54pKtcv"
Content-Disposition: inline
In-Reply-To: <CAH3L5Qrzk-7WoF8+GKMYS40Dj_fxGpiLrTvVB_PJdA_VZVsDAQ@mail.gmail.com>
Precedence: bulk


--7gwrvj5+w54pKtcv
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Aug 07, 2023 at 08:38:27PM +0300, Alexandru Ardelean wrote:
> On Mon, Aug 7, 2023 at 4:27=E2=80=AFPM Mark Brown <broonie@kernel.org> wr=
ote:

> > On Mon, Aug 07, 2023 at 04:02:17PM +0300, Andrei Coardos wrote:

> > > This function call was found to be unnecessary as there is no equival=
ent
> > > platform_get_drvdata() call to access the private data of the driver.=
 Also,
> > > the private data is defined in this driver, so there is no risk of it=
 being
> > > accessed outside of this driver file.

> > That isn't enough of a check here - people can still reference the
> > driver data without going through the accessor function.

> So, is that like calling `platform_get_drvdata()` in a parent/chid
> device, to check if the driver-data is set?

That wasn't what I was thinking of, waht I was thinking of was just open
coding platform_get_drvdata() and looking directly at struct device.
Another common case is where drivers that support multiple bus types
will pass around the struct device and use dev_get_drvdata() to read the
data rather than using platform_get_drvdata().  The driver data can be
allocated and initialised with bus specific bits before being passed off
to the generic code.

That said the looking at the parent's driver data is definitely a thing
that happens with MFDs.

--7gwrvj5+w54pKtcv
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmTRNVUACgkQJNaLcl1U
h9DRbQf/UD6rT6THBwwsVjvF+9xmAJZdPPLu0/Bqms50iz2PhJKdjfhZfjo8vOXt
yWawMNetOUo3iUVxnMesYI43et1n+veZB9tA5qaXX5Fu2OBXOAnHHWdbha7f/99R
kdQ8+L+Hhw7rb+EalNBlx15aeo+b6iWJ1BiYFQ5PD2wLgHPUe24der7IbM1I0gRR
u+DUr9SEoGBpPtKT/0AzTtVlLPc0kFLOUIotXVqgkgISKxylhdOK1aErIjdGJM5P
3COmUmsJq5EyT9fm6+CC3Q/bPyCeYcZIwrouxPdImOM1AnGrW124BHTUVi8K8oVh
sR3JyZuBS1jCYiccd/JEi7agqqqWLw==
=NKz9
-----END PGP SIGNATURE-----

--7gwrvj5+w54pKtcv--