Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230802065518.12271-1-sunran001@208suo.com>
In-Reply-To: <20230802065518.12271-1-sunran001@208suo.com>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Mon, 7 Aug 2023 13:21:36 -0400
Message-ID: <CADnq5_NOoz1ciFDqtbv54dRB2Bd_55sO-0kLnZXxBxxdT2cc_A@mail.gmail.com>
Subject: Re: [PATCH] drm/amd: Clean up errors in amdgpu_cgs.c
To:     Ran Sun <sunran001@208suo.com>
Cc:     alexander.deucher@amd.com, dri-devel@lists.freedesktop.org,
        amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Already fixed.

On Wed, Aug 2, 2023 at 2:55=E2=80=AFAM Ran Sun <sunran001@208suo.com> wrote=
:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: switch and case should be at the same indent
>
> Signed-off-by: Ran Sun <sunran001@208suo.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c | 64 ++++++++++++-------------
>  1 file changed, 32 insertions(+), 32 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c b/drivers/gpu/drm/am=
d/amdgpu/amdgpu_cgs.c
> index 456e385333b6..fafe7057a8c9 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c
> @@ -163,38 +163,38 @@ static uint16_t amdgpu_get_firmware_version(struct =
cgs_device *cgs_device,
>         uint16_t fw_version =3D 0;
>
>         switch (type) {
> -               case CGS_UCODE_ID_SDMA0:
> -                       fw_version =3D adev->sdma.instance[0].fw_version;
> -                       break;
> -               case CGS_UCODE_ID_SDMA1:
> -                       fw_version =3D adev->sdma.instance[1].fw_version;
> -                       break;
> -               case CGS_UCODE_ID_CP_CE:
> -                       fw_version =3D adev->gfx.ce_fw_version;
> -                       break;
> -               case CGS_UCODE_ID_CP_PFP:
> -                       fw_version =3D adev->gfx.pfp_fw_version;
> -                       break;
> -               case CGS_UCODE_ID_CP_ME:
> -                       fw_version =3D adev->gfx.me_fw_version;
> -                       break;
> -               case CGS_UCODE_ID_CP_MEC:
> -                       fw_version =3D adev->gfx.mec_fw_version;
> -                       break;
> -               case CGS_UCODE_ID_CP_MEC_JT1:
> -                       fw_version =3D adev->gfx.mec_fw_version;
> -                       break;
> -               case CGS_UCODE_ID_CP_MEC_JT2:
> -                       fw_version =3D adev->gfx.mec_fw_version;
> -                       break;
> -               case CGS_UCODE_ID_RLC_G:
> -                       fw_version =3D adev->gfx.rlc_fw_version;
> -                       break;
> -               case CGS_UCODE_ID_STORAGE:
> -                       break;
> -               default:
> -                       DRM_ERROR("firmware type %d do not have version\n=
", type);
> -                       break;
> +       case CGS_UCODE_ID_SDMA0:
> +               fw_version =3D adev->sdma.instance[0].fw_version;
> +               break;
> +       case CGS_UCODE_ID_SDMA1:
> +               fw_version =3D adev->sdma.instance[1].fw_version;
> +               break;
> +       case CGS_UCODE_ID_CP_CE:
> +               fw_version =3D adev->gfx.ce_fw_version;
> +               break;
> +       case CGS_UCODE_ID_CP_PFP:
> +               fw_version =3D adev->gfx.pfp_fw_version;
> +               break;
> +       case CGS_UCODE_ID_CP_ME:
> +               fw_version =3D adev->gfx.me_fw_version;
> +               break;
> +       case CGS_UCODE_ID_CP_MEC:
> +               fw_version =3D adev->gfx.mec_fw_version;
> +               break;
> +       case CGS_UCODE_ID_CP_MEC_JT1:
> +               fw_version =3D adev->gfx.mec_fw_version;
> +               break;
> +       case CGS_UCODE_ID_CP_MEC_JT2:
> +               fw_version =3D adev->gfx.mec_fw_version;
> +               break;
> +       case CGS_UCODE_ID_RLC_G:
> +               fw_version =3D adev->gfx.rlc_fw_version;
> +               break;
> +       case CGS_UCODE_ID_STORAGE:
> +               break;
> +       default:
> +               DRM_ERROR("firmware type %d do not have version\n", type)=
;
> +               break;
>         }
>         return fw_version;
>  }
> --
> 2.17.1
>