Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <dd320704-a923-2e0e-a8ed-0693d294ee33@linuxfoundation.org>
Date:   Mon, 7 Aug 2023 12:47:18 -0600
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH v5 12/19] selftests/resctrl: Remove
 "malloc_and_init_memory" param from run_fill_buf()
To:     Reinette Chatre <reinette.chatre@intel.com>,
        =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        linux-kselftest@vger.kernel.org, Shuah Khan <shuah@kernel.org>,
        Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>,
        Fenghua Yu <fenghua.yu@intel.com>,
        Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>,
        linux-kernel@vger.kernel.org,
        Shuah Khan <skhan@linuxfoundation.org>
References: <20230717131507.32420-1-ilpo.jarvinen@linux.intel.com>
 <20230717131507.32420-13-ilpo.jarvinen@linux.intel.com>
 <7bba4db8-eaac-238d-b764-89d0ae2a9bba@linuxfoundation.org>
 <856ad175-26f8-90ea-d801-c722d2b19b2e@intel.com>
Content-Language: en-US
From:   Shuah Khan <skhan@linuxfoundation.org>
In-Reply-To: <856ad175-26f8-90ea-d801-c722d2b19b2e@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 7/25/23 09:26, Reinette Chatre wrote:
> Hi Shuah,
> 
> On 7/25/2023 7:49 AM, Shuah Khan wrote:
>> WARNING: Prefer strscpy over strcpy - see: https://github.com/KSPP/linux/issues/88
>> #233: FILE: tools/testing/selftests/resctrl/resctrl_tests.c:276:
>> +        strcpy(benchmark_cmd[3], "0");
>>
>> WARNING: Prefer strscpy over strcpy - see: https://github.com/KSPP/linux/issues/88
>> #234: FILE: tools/testing/selftests/resctrl/resctrl_tests.c:277:
>> +        strcpy(benchmark_cmd[4], "");
>>
>> total: 0 errors, 2 warnings, 142 lines checked
>>
>> I am applying the patch set to linux-kselftest next - please fix
>> the aboe and send a patch on top of linux-kselftest next
> 
> Is strscpy() available to userspace? I found lib/strscpy_kunit.c
> that makes me think this is currently only available to kernel code.
> 

Very likely. You can ignore the comment. I already applied the
series anyway.

thanks,
-- Shuah