Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <900b3b16-cfad-d043-39b4-8ea6802f87bc@quicinc.com>
Date:   Mon, 7 Aug 2023 13:03:05 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v2 2/7] dt-bindings: leds: leds-qcom-lpg: Add support for
 LPG PPG
Content-Language: en-US
To:     Rob Herring <robh@kernel.org>
CC:     <pavel@ucw.cz>, <lee@kernel.org>, <thierry.reding@gmail.com>,
        <krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
        <agross@kernel.org>, <andersson@kernel.org>,
        <luca.weiss@fairphone.com>, <konrad.dybcio@linaro.org>,
        <u.kleine-koenig@pengutronix.de>, <quic_subbaram@quicinc.com>,
        <linux-leds@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
        <linux-pwm@vger.kernel.org>
References: <20230725193423.25047-1-quic_amelende@quicinc.com>
 <20230725193423.25047-3-quic_amelende@quicinc.com>
 <20230803002502.GA1569972-robh@kernel.org>
From:   Anjelique Melendez <quic_amelende@quicinc.com>
In-Reply-To: <20230803002502.GA1569972-robh@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 8/2/2023 5:25 PM, Rob Herring wrote:
> On Tue, Jul 25, 2023 at 12:34:18PM -0700, Anjelique Melendez wrote:
>> +  - if:
>> +      properties:
>> +        compatible:
>> +          contains:
>> +            enum:
>> +              - qcom,pm8350c-pw
>> +              - qcom,pm8550-pwm
>> +    then:
>> +      properties:
>> +        nvmem:
>> +          minItems: 2
>> +        nvmem-names:
>> +          items:
>> +            - const: lpg_chan_sdam
>> +            - const: lut_sdam
> 
> This can go into the main section and then here you just say 
> 'minItems: 2'. And similar for the 1st if/then.
> 
ACK
>> +      required:
>> +        - nvmem
>> +        - nvmem-names
> 
> Looks like these are always required.
These are only required for the compatibles properties that do not
have lut peripherals. Right now this is is only for qcom,pmi632-lpg, 
qcom,pm8350c-pwm and qcom,pm8550-pwm.