Received: by 2002:a05:6359:6284:b0:131:369:b2a3 with SMTP id se4csp3459604rwb; Mon, 7 Aug 2023 14:03:09 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFxbFdmbQczJVBkdmgUIOEIz7Bv5uPodjk10MKPrst8XwV53I91XKwkNlU62Rc+lLvYGNAK X-Received: by 2002:a17:902:e890:b0:1bb:dc48:644a with SMTP id w16-20020a170902e89000b001bbdc48644amr10344304plg.49.1691442188998; Mon, 07 Aug 2023 14:03:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691442188; cv=none; d=google.com; s=arc-20160816; b=bC47VMGG7IyD5Raf3ffLYpD0H/F1pbNEX/0w+o3KA+iMBsEjnGrHcr0Zv2nm8scYu0 fJ6Hk3VLzfZEnP2d4O+PbAZ3zNlyKLTk58XOmZW/oZoliuKa99VqLSacloQ8Z8xeT5KL RRexv8rGtAUTy0vIAKeFLK0GJ5279okPU7dyaLmU0xvbWSer8Var79F96jocI697C747 EAklz0PtpNalsxTfg7jd0ac5MoycTlIGR0bB06KwUMFZjiaYortAKSfCeLfcMHXvpGYG sMmQWjYdQakIL6Yst9WUuuy9c8CxYkdLDzh0G2bcNpPg7f7rAUPmGGjEx3bcqSWPdfZF 7iYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=O0eJGJe1CcSFkdKrjL8/q25ZXBKM3etXFD40ItFNk3s=; fh=xlT3WZn60kz9NtMtR73gNL3DqkvY+cgh2bzE0dC7z6Y=; b=dKlCU/9HHIEmIKc5ij12hOoNpx7YxEyD0TKL8SSaRPNCQID4JsoGtOBNi7yR1PDxex xvSA3xgZtQtmCCePQl0HE5JMm7OfjIDIWWQwTWbjkL/TJFCFWp2OfzNPQinmF21ZG1LK Qhy8xHwVPgY/S7/vaRVI9A6rFwsdVo7Or9QamvE0GE7xciR02Y6t9/AIGFe0IkgG6BVE f58u3A1VBDqj4oeoJgQWrQQcdbd24mP9rd/gscaWvnr9OYUO/t0bfl7xUTABVMJO4Y+Q XcYItWcBwx9yjzqhrZ9QXO4iulTwKrqM3doCOg3VLioV/ASjUX/9FHQKVbDnzqDeqiL3 nMWg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=lBIGk9Sg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u4-20020a170902e80400b001bb8704e6f3si6468330plg.278.2023.08.07.14.02.48; Mon, 07 Aug 2023 14:03:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=lBIGk9Sg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230359AbjHGUJv (ORCPT + 99 others); Mon, 7 Aug 2023 16:09:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52884 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229726AbjHGUJu (ORCPT ); Mon, 7 Aug 2023 16:09:50 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 89F1C10C0 for ; Mon, 7 Aug 2023 13:09:49 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1B797621D5 for ; Mon, 7 Aug 2023 20:09:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D8FF4C433C8; Mon, 7 Aug 2023 20:09:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691438988; bh=qYWsNM5r7KU6Cd8OsjqQh7cSxa56PwYXzSXeTpvD484=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=lBIGk9Sgqtp2SLMYrLtIXYquMrq7NoVnRLTmtW60SpEdGz1Lq8fqFDjTmmMOJA3pd imgPShmiiwFa9g6FfQQFTgaa4L6u0Dun9rXEpXuxrJVYpZeFXYF2TzZC1S1uyqMIfk tx5N6SP7gQ2iR7YrnT5JHrYNw0Dyjl0eZPSyQ2VbPis4hKX9p7ok1JSFchlNsxWE7H iEN1AJ68ys3wNV9qxfYTf2riOcDKUpb55jYsoApqZEnLaXeB8Ks0EenpVo29SOn2uG EPD2diNQWNg4XEEyOjAwG3+QTpKCIxia6muqW7WTtuqGYrnOfgldAgbcAWMxZW/6s3 DbHWrEvxGwY4w== Date: Mon, 7 Aug 2023 13:09:46 -0700 From: Jakub Kicinski To: Alexander Lobakin Cc: "David S. Miller" , Eric Dumazet , Paolo Abeni , Maciej Fijalkowski , Larysa Zaremba , Yunsheng Lin , Alexander Duyck , Jesper Dangaard Brouer , Ilias Apalodimas , Simon Horman , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v4 1/6] page_pool: split types and declarations from page_pool.h Message-ID: <20230807130946.22da17b4@kernel.org> In-Reply-To: <20230804180529.2483231-2-aleksander.lobakin@intel.com> References: <20230804180529.2483231-1-aleksander.lobakin@intel.com> <20230804180529.2483231-2-aleksander.lobakin@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 4 Aug 2023 20:05:24 +0200 Alexander Lobakin wrote: > Split types and pure function declarations from page_pool.h > and add them in page_page/types.h, so that C sources can > include page_pool.h and headers should generally only include > page_pool/types.h as suggested by jakub. > Rename page_pool.h to page_pool/helpers.h to have both in > one place. I had to touch this one up a little when merging to fix build for the merged-in-meantime mana driver and also update the patch in Documentation.