Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 7 Aug 2023 22:06:02 +0300
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Vinicius Costa Gomes <vinicius.gomes@intel.com>
Cc:     netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Jamal Hadi Salim <jhs@mojatatu.com>,
        Cong Wang <xiyou.wangcong@gmail.com>,
        Jiri Pirko <jiri@resnulli.us>, linux-kernel@vger.kernel.org,
        intel-wired-lan@lists.osuosl.org,
        Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com>,
        Peilin Ye <yepeilin.cs@gmail.com>,
        Pedro Tammela <pctammela@mojatatu.com>,
        Richard Cochran <richardcochran@gmail.com>,
        Zhengchao Shao <shaozhengchao@huawei.com>,
        Maxim Georgiev <glipus@gmail.com>
Subject: Re: [PATCH v3 net-next 09/10] selftests/tc-testing: test that taprio
 can only be attached as root
Message-ID: <20230807190602.pvforrful3zmqiv6@skbuf>
References: <20230801182421.1997560-1-vladimir.oltean@nxp.com>
 <20230801182421.1997560-10-vladimir.oltean@nxp.com>
 <87pm4510r0.fsf@intel.com>
 <20230803143347.7hhn27hzjymdvvw6@skbuf>
 <87il9w0xx7.fsf@intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87il9w0xx7.fsf@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?8Cbl3zqOpLkHkCiFKJht0+CUxdzTgUYGdLJ1gOCVRyE7fLdw2384kCF0fxxT?=
 =?us-ascii?Q?VvMtweN+UEDUfJB7p6Pj4Eq+SZtIMc/qKGry/RgyadnQhblp86YbRWT0b3XN?=
 =?us-ascii?Q?IXwfZykjsEydpNGvf2LFPHTf554Gyu2AzZs2FMSTpQChz3J5PbZkFjtkmgIJ?=
 =?us-ascii?Q?OjEP3w6x4FwjKWHYJ7WTiKig8bqiAO2XF7pZIBCKn9RAuJK6iyswkpPHE/Ho?=
 =?us-ascii?Q?TlHTKX/VfyJOKfWJF1YxBPVu3sjwCejFa+RlXCOC4hCBoypuK/R/6vMfStK/?=
 =?us-ascii?Q?Ubq1Q2dJFrHJWyjSeip9LLeSQ60xRnCKE5vhdwWa5Hb95YBaEm6Trts91BgP?=
 =?us-ascii?Q?W8T8urp5o33sp4xmC3/ypY/KNWsU0pr9vQ3TZYLKatkZObz5PZ6bYGcSDl9G?=
 =?us-ascii?Q?tggxWj6++2AQTP6UCoOftfRs9Lg+Serd+hjUTEW1h/fuRC8VcPTGZbQAjkry?=
 =?us-ascii?Q?p2iawHROzZ238zIPjeoj+r3SN0/2kmKQu45x2bmY0BTu7363rQ+qP0uiq2P+?=
 =?us-ascii?Q?QLXu5hQkJgGsTNsyYnQYcKKR78GqgyRgvoUJ+PuDftTgdOHlDuY7UsLxNg1d?=
 =?us-ascii?Q?oDeTM5N5i1I83pTyecEX2bTis4LLA3OfcWyKscPRO7d3najqoQM+Ln7p8Nt7?=
 =?us-ascii?Q?PIJjAgMj1q0gcC/GadDhkFCwFcZg+ZlQqw9r+y9lBs6WQ0sQlGtz2zkCU0/d?=
 =?us-ascii?Q?yPz0vwVaRiN3c8VujZUi87hTlSs8V2yyrLzltvpMv+Gnvw5MId79hqc+t6ZL?=
 =?us-ascii?Q?VgmPhdYrVbmqwz/kNTmrwFug0xOHyXrgkn9gM4ligQivGZ0LqeVm94s0aL0C?=
 =?us-ascii?Q?naKYi5xfHxBXukeW9+CcZ9WNdMpfPnYnLwfDw1I2n0OqL15zefU9c3jPw4VK?=
 =?us-ascii?Q?VPgI56rS8El9VXyV/i5wjGLaVuab6YuMCsDJS9Flh8hyQcX+5R9g9AGT9avI?=
 =?us-ascii?Q?1z1dY0BCvcwp3Y6GeY8z5FLs/gbgqD3/2N+NtgaQVT84Iqsf2/IJ7ClzYstR?=
 =?us-ascii?Q?r+5CX0y1WF7jWV6nAFGL9tf98U272LDOU4Ifmo9M3jUB6lKh2K60SO8qoF8o?=
 =?us-ascii?Q?dHXujZ1pwlOIkZR+wDxq7nkI/DSw1QJhFRX/JLUEWWwuFJwYp+N0QXhU5bFX?=
 =?us-ascii?Q?Own3Vnhk57SZwGbZRA5wqG8Q5GXTDK+GVtoDfzj5UPJ0Fpkvhqj/ZKgOg00i?=
 =?us-ascii?Q?DOB1gUR3GaB/jQaISGUB9cMcJTQxaEYBq04FXShEBgLnjIj93OutJxZE4tJQ?=
 =?us-ascii?Q?tJn/ZX633X1HOpxoVHBLLJcZDepOsE54lljqo59nW+Ip2NvnaMSFAAR68WYZ?=
 =?us-ascii?Q?b3VZx7M7rNTeKhMqokhLYXIUi4aABePmyLIMtrPSsOz8KpKg55IQmFKyAQpK?=
 =?us-ascii?Q?Wv/3fBS2o+Yz59AnigN0M76W81np4dGrdINRLKRbyjPomUUj7jN0Xo4NUs4i?=
 =?us-ascii?Q?9D0eRdmLBdR3He4vpATwNFsyBGKyNM7WACC26nULFuhw+lmrGVYM+06LIhXX?=
 =?us-ascii?Q?lw2sTl1axi85K+4ZvGdmKaGjhBil9+wuNkYeffHkbyjpja20nl4BFpKU9ohx?=
 =?us-ascii?Q?3o0kpqb8J2Tl1+b6WNKeCp6tB0T1le/cy2CFjYZLK8QoSLu4O3BXUH7ot/CG?=
 =?us-ascii?Q?Cg=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d0d10adc-35bd-4d3f-dac9-08db97795ab6
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB6452.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2023 19:06:07.5559
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UxLMcfKO+LV0siMlf34QPscrjanUEjKsKFCSZsd1zZRbYNdoBIXcgCu5d9+Vl/bVat0c4UMj07ODQLxE/eu6xg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7396
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Aug 03, 2023 at 11:43:16AM -0700, Vinicius Costa Gomes wrote:
> Hmmm, I think that this test discovered another bug (perhaps even two).
> When it fails here's the json I get (edited for clarity):
> 
> [{"kind":"taprio","handle":"8001:","root":true,"refcnt":9,
>   "options":{
>         "tc":0,
>         "map":[0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0],
>         "queues":[],
>         "clockid":"TAI",
>         "base_time":0,
>         "cycle_time":0,
>         "cycle_time_extension":0,
>         {
>                 "base_time":0,
>                 "cycle_time":20000000,
>                 "cycle_time_extension":0,
>                 "schedule":[{"index":0,"cmd":"S","gatemask":"0xff","interval":20000000}]
>         }}}]
> 
> Thinking out loud: If I am reading this right, there's no "oper"
> schedule, only an "admin" schedule. So the first bug is probably a
> taprio bug when deciding if it should create an "open" vs. "admin"
> schedule.
> 
> The second bug seems to be in the way that q_taprio in iproute2
> handles the admin schedule, is just an object inside another, which
> seems to be invalid.
> 
> Does it make sense?

Yes, it makes sense, thanks. I've sent some iproute2 patches that fix
the user space issues, and I'll soon send a v4 which takes into
consideration the fact that the admin schedule may not become
operational right away.
https://patchwork.kernel.org/project/netdevbpf/patch/20230807160827.4087483-1-vladimir.oltean@nxp.com/