Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 7 Aug 2023 23:16:59 +0200
From:   Borislav Petkov <bp@alien8.de>
To:     "Maciej W. Rozycki" <macro@orcam.me.uk>
Cc:     Arnd Bergmann <arnd@arndb.de>, Arnd Bergmann <arnd@kernel.org>,
        linux-kernel@vger.kernel.org, x86@kernel.org,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH 2/5] [RESEND] x86: avoid unneeded __div64_32 function
 definition
Message-ID: <20230807211659.GKZNFfS+7PK71yYt0p@fat_crate.local>
References: <20230725134837.1534228-1-arnd@kernel.org>
 <20230725134837.1534228-3-arnd@kernel.org>
 <20230801170315.GGZMk60zojZOeuUwX7@fat_crate.local>
 <baf750f4-a42c-453a-91dc-7fd457bc1e80@app.fastmail.com>
 <20230802172030.GEZMqQXmeb98Tm+Qhg@fat_crate.local>
 <alpine.DEB.2.21.2308072124320.38537@angie.orcam.me.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.21.2308072124320.38537@angie.orcam.me.uk>
Precedence: bulk

On Mon, Aug 07, 2023 at 09:37:00PM +0100, Maciej W. Rozycki wrote:
>  Otherwise you risk `__div64_32(n, base)' getting expanded to `(n, base)', 

You mean in the very obscure case of a 32-bit kernel where they don't call
do_div() but call this low level function?

I'd say if they can't be bothered to even grep the tree for the right usage,
they deserve both pieces... :)

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette