Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a0bde410-a688-fac0-f3d5-2d4261bcd5b5@infradead.org>
Date:   Mon, 7 Aug 2023 15:37:13 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.14.0
Subject: Re: [PATCH 2/2] hexdump: add a new dump prefix
 DUMP_PREFIX_ADDRESS_LOW16
Content-Language: en-US
To:     thunder.leizhen@huaweicloud.com, Petr Mladek <pmladek@suse.com>,
        Sergey Senozhatsky <senozhatsky@chromium.org>,
        Steven Rostedt <rostedt@goodmis.org>,
        John Ogness <john.ogness@linutronix.de>,
        linux-kernel@vger.kernel.org
Cc:     Zhen Lei <thunder.leizhen@huawei.com>
References: <20230805072116.1260-1-thunder.leizhen@huaweicloud.com>
 <20230805072116.1260-3-thunder.leizhen@huaweicloud.com>
From:   Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <20230805072116.1260-3-thunder.leizhen@huaweicloud.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 8/5/23 00:21, thunder.leizhen@huaweicloud.com wrote:
> From: Zhen Lei <thunder.leizhen@huawei.com>
> 
> 
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>


Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.

> ---
>  include/linux/printk.h | 1 +
>  lib/hexdump.c          | 4 ++++
>  2 files changed, 5 insertions(+)
> 
> diff --git a/include/linux/printk.h b/include/linux/printk.h
> index 8ef499ab3c1ed2e..ccad9e8eaaf0c31 100644
> --- a/include/linux/printk.h
> +++ b/include/linux/printk.h
> @@ -704,6 +704,7 @@ extern const struct file_operations kmsg_fops;
>  enum {
>  	DUMP_PREFIX_NONE,
>  	DUMP_PREFIX_ADDRESS,
> +	DUMP_PREFIX_ADDRESS_LOW16,
>  	DUMP_PREFIX_OFFSET
>  };
>  extern int hex_dump_to_buffer(const void *buf, size_t len, int rowsize,
> diff --git a/lib/hexdump.c b/lib/hexdump.c
> index 86cb4cc3eec485a..eb33e477bc96df1 100644
> --- a/lib/hexdump.c
> +++ b/lib/hexdump.c
> @@ -290,6 +290,10 @@ void print_hex_dump(const char *level, const char *prefix_str, int prefix_type,
>  			printk("%s%s%p: %s\n",
>  			       level, prefix_str, ptr + i, linebuf);
>  			break;
> +		case DUMP_PREFIX_ADDRESS_LOW16:
> +			printk("%s%s%04lx: %s\n", level,
> +			       prefix_str, 0xffff & (unsigned long)(ptr + i), linebuf);
> +			break;
>  		case DUMP_PREFIX_OFFSET:
>  			printk("%s%s%0*x: %s\n", level, prefix_str, width, i, linebuf);
>  			break;

-- 
~Randy