Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <ZNCZ4KL7TRDE9vIC@gmail.com>
In-Reply-To: <ZNCZ4KL7TRDE9vIC@gmail.com>
From:   Paul Moore <paul@paul-moore.com>
Date:   Mon, 7 Aug 2023 19:14:45 -0400
Message-ID: <CAHC9VhSULN1B_EjVPA5st+NhDjiUbymOwt81C4gZ9Tn4_wWpuw@mail.gmail.com>
Subject: Re: [PATCH v2] lsm: add comment block for security_sk_classify_flow()
 LSM hook
To:     Khadija Kamran <kamrankhadijadj@gmail.com>
Cc:     Alison Schofield <alison.schofield@intel.com>,
        ztarkhani@microsoft.com, James Morris <jmorris@namei.org>,
        "Serge E. Hallyn" <serge@hallyn.com>,
        linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Aug 7, 2023 at 3:14=E2=80=AFAM Khadija Kamran <kamrankhadijadj@gmai=
l.com> wrote:
>
> security_sk_classify_flow() LSM hook has no comment block. Add a comment
> block with a brief description of LSM hook and its function parameters.
>
> Signed-off-by: Khadija Kamran <kamrankhadijadj@gmail.com>
> ---
> Changed in v2:
>  - Add parenthesis with security_sk_calssify_flow to refer to it as a
>    function in commit message and commit log.
>  - Remove an extra space in the comment block.
>
> security/security.c | 7 +++++++
>  1 file changed, 7 insertions(+)

Hi Khadija,

Thanks, but I already merged your original patch :)

https://lore.kernel.org/linux-security-module/abe91475c7f9e3483405c6096006b=
2a9.paul@paul-moore.com/

> diff --git a/security/security.c b/security/security.c
> index d5ff7ff45b77..b76fb27a1dc6 100644
> --- a/security/security.c
> +++ b/security/security.c
> @@ -4396,6 +4396,13 @@ void security_sk_clone(const struct sock *sk, stru=
ct sock *newsk)
>  }
>  EXPORT_SYMBOL(security_sk_clone);
>
> +/**
> + * security_sk_classify_flow() - Set a flow's secid based on socket
> + * @sk: original socket
> + * @flic: target flow
> + *
> + * Set the target flow's secid to socket's secid.
> + */
>  void security_sk_classify_flow(struct sock *sk, struct flowi_common *fli=
c)
>  {
>         call_void_hook(sk_getsecid, sk, &flic->flowic_secid);
> --
> 2.34.1

--=20
paul-moore.com