Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230729024026.32228-1-yuehaibing@huawei.com>
In-Reply-To: <20230729024026.32228-1-yuehaibing@huawei.com>
From:   Paul Moore <paul@paul-moore.com>
Date:   Mon, 7 Aug 2023 17:46:35 -0400
Message-ID: <CAHC9VhRW0Jt0pitVx1cw-zJGWfTmvTU4RSmOFKANYJA7CeEF7g@mail.gmail.com>
Subject: Re: [PATCH v3 -next] keys: Remove unused extern declarations
To:     Yue Haibing <yuehaibing@huawei.com>
Cc:     dhowells@redhat.com, jarkko@kernel.org, jmorris@namei.org,
        serge@hallyn.com, keyrings@vger.kernel.org,
        linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Jul 28, 2023 at 10:40=E2=80=AFPM Yue Haibing <yuehaibing@huawei.com=
> wrote:
>
> From: YueHaibing <yuehaibing@huawei.com>
>
> Since commit b2a4df200d57 ("KEYS: Expand the capacity of a keyring")
> iterate_over_keyring() is never used, so can be removed.
>
> And commit b5f545c880a2 ("[PATCH] keys: Permit running process to instant=
iate keys")
> left behind keyring_search_instkey().
>
> Fixes: b2a4df200d57 ("KEYS: Expand the capacity of a keyring")
> Fixes: b5f545c880a2 ("[PATCH] keys: Permit running process to instantiate=
 keys")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> v3: Add Fixes tag
> v2: Also remove keyring_search_instkey()
> ---
>  security/keys/internal.h | 7 -------
>  1 file changed, 7 deletions(-)

Reviewed-by: Paul Moore <paul@paul-moore.com>

> diff --git a/security/keys/internal.h b/security/keys/internal.h
> index 3c1e7122076b..471cf36dedc0 100644
> --- a/security/keys/internal.h
> +++ b/security/keys/internal.h
> @@ -109,13 +109,6 @@ extern void __key_link_end(struct key *keyring,
>  extern key_ref_t find_key_to_update(key_ref_t keyring_ref,
>                                     const struct keyring_index_key *index=
_key);
>
> -extern struct key *keyring_search_instkey(struct key *keyring,
> -                                         key_serial_t target_id);
> -
> -extern int iterate_over_keyring(const struct key *keyring,
> -                               int (*func)(const struct key *key, void *=
data),
> -                               void *data);
> -
>  struct keyring_search_context {
>         struct keyring_index_key index_key;
>         const struct cred       *cred;
> --
> 2.34.1

--=20
paul-moore.com