Received: by 2002:a05:6359:6284:b0:131:369:b2a3 with SMTP id se4csp3674993rwb; Mon, 7 Aug 2023 18:35:25 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHngwIktw+HWiMQC4X47L1xHCuN2Y86bmOGMF8vQ/eMpsvl08b3R1P+13baVDP5xpDktN8l X-Received: by 2002:a17:906:32d9:b0:99c:c59:2283 with SMTP id k25-20020a17090632d900b0099c0c592283mr10470211ejk.60.1691458525200; Mon, 07 Aug 2023 18:35:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691458525; cv=none; d=google.com; s=arc-20160816; b=ojMWrcdJX/XOzsd71JJq1DaL62YKWwaEzyjvl4vQXMz8SB6GdJtEDiNqZk1m4pyCTP 91hjcQJKtGVpivFJ8Vs3tmFY0oe6Kvw/LIhFWnlZ+tRGhF1TdZ4M+LvJwEDv/sT6z44N 2p8KwiIccXHqPBBZ5u9JeiaLliPu9xZEQkyxQV6DlVZz2wcEwnKBU3HLTbYKpVyllfnl 35fznc+bEEAGLtbqPatn8cJsXVhpzbFnAVSvwxOL6wB8XYbWmnMrmR7ofT8FmnYyOa9m +qZ4hcvcU0LPKqNQ/4fLZMQMQsrL6a6bMWqqfm4nfADMxy+aFXi1n57sTdVcPtdJtN4a M6KQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=INUbKKFKupazV4prC4uBd7mkepqr/L5U62YOA8ZT7zA=; fh=TrfPeSpaxL9/gQJ7vXXT/r+ccpVpAQ0x8Amnsib6a5g=; b=HVfyIirFSpfJlu07K3yG79PKtwJI+LgDP1am9rSh2hmTNRBhNahhr38yl2Rdq/S1Bw BBQV27ye9hErUa9TLp7q9gqFBS1Yr68WiXkLo3wf4g24TMDm894sQr4ukbnx8MoUtEcd ww41ch4eM/rwR0szeztVX3eRUrSJZaDYkDxKHcld+yk8wBp/J+OJOL/yZo22rRxINm/f bXow5p+y6vWbh/MbItbFNEDlwgr15TrAg6+0HawLYvGiVSgYAHnUDXGLUcQ7FSnH+zqH D+/UZD69KCm3lWSfkZ7ZOgL83KmHzl0F3VYYmdNvJ6yL18PfC0sTI575Pt0sVwLwpLfP 1InQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id jt4-20020a170906ca0400b0098cf1b12715si6306547ejb.581.2023.08.07.18.35.01; Mon, 07 Aug 2023 18:35:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230445AbjHHBOV (ORCPT + 99 others); Mon, 7 Aug 2023 21:14:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55590 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229939AbjHHBOU (ORCPT ); Mon, 7 Aug 2023 21:14:20 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 03D6919B0 for ; Mon, 7 Aug 2023 18:14:13 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 87D6062349 for ; Tue, 8 Aug 2023 01:14:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3E4D8C433C8; Tue, 8 Aug 2023 01:14:11 +0000 (UTC) Date: Mon, 7 Aug 2023 21:14:09 -0400 From: Steven Rostedt To: thunder.leizhen@huaweicloud.com Cc: Petr Mladek , Sergey Senozhatsky , John Ogness , linux-kernel@vger.kernel.org, Zhen Lei Subject: Re: [PATCH 2/2] hexdump: add a new dump prefix DUMP_PREFIX_ADDRESS_LOW16 Message-ID: <20230807211409.750c17a5@gandalf.local.home> In-Reply-To: <20230805072116.1260-3-thunder.leizhen@huaweicloud.com> References: <20230805072116.1260-1-thunder.leizhen@huaweicloud.com> <20230805072116.1260-3-thunder.leizhen@huaweicloud.com> X-Mailer: Claws Mail 3.19.1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 5 Aug 2023 15:21:16 +0800 thunder.leizhen@huaweicloud.com wrote: > For example: > dump memory at sp=ffff800080883a90: > ffff800080883a90: 80883ac0 ffff8000 3d8e936c ffffbd5b > ffff800080883aa0: 5833f000 ffff3580 00000001 00000000 > ffff800080883ab0: 40299840 ffff3580 590dfa00 ffff3580 > ffff800080883ac0: 80883b30 ffff8000 3d938b28 ffffbd5b > ffff800080883ad0: 40877180 ffff3580 590dfa00 ffff3580 > ffff800080883ae0: 4090f600 ffff3580 80883cb0 ffff8000 > ffff800080883af0: 00000010 00000000 00000000 00000000 > ffff800080883b00: 4090f700 ffff3580 00000001 00000000 > > Generally, we do not dump more than 64 KB memory. It is sufficient to > print only the lower 16 bits of the address. > > dump memory at sp=ffff800080883a90: > 3a90: 80883ac0 ffff8000 3d8e936c ffffbd5b > 3aa0: 5833f000 ffff3580 00000001 00000000 > 3ab0: 40299840 ffff3580 590dfa00 ffff3580 > 3ac0: 80883b30 ffff8000 3d938b28 ffffbd5b > 3ad0: 40877180 ffff3580 590dfa00 ffff3580 > 3ae0: 4090f600 ffff3580 80883cb0 ffff8000 > 3af0: 00000010 00000000 00000000 00000000 > 3b00: 4090f700 ffff3580 00000001 00000000 I find the "before" much easier to read than the "after". -- Steve