Received: by 2002:a05:6359:6284:b0:131:369:b2a3 with SMTP id se4csp3709722rwb; Mon, 7 Aug 2023 19:25:35 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE31rzYLvXQinHkMm7HLXE1twysSptkphc4v3lYFWLdfWHDdwIKCtilJ2tRa8V0MIuP1PG5 X-Received: by 2002:a05:6a20:ce92:b0:117:a2f3:3c93 with SMTP id if18-20020a056a20ce9200b00117a2f33c93mr9777290pzb.2.1691461535598; Mon, 07 Aug 2023 19:25:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691461535; cv=none; d=google.com; s=arc-20160816; b=PiYJY2jonUgwKrxNflPqa1Q0tzwh6+BqAeUrUTwrtBBs0J7RuITGXHO7dte66GYksT L/XvUV53Nuff/VwdpzhPqy7P35t3kipelltd2G2VKvHZ59Ld0FAnjmt0OJep0MaC0hop XuDh5CTGzUcc/p0wgtZqal7ST9nDhuQMn7SuD3NbjS6YnXEVluB5vgu9NIu8el1o9sA7 j6hDW/KbJkPUUKjayeYbDpuR2R6w1Fg2yto+PQdGpf88F30ICivsa1IuPwvQlcrbGFlx AO9YxLLXy/I4OAkF2+KMufsNC02q4qSOhtLIW1kyyVsM/K1Gn5iFOnPTGlkGj9+Xf6mP Q74Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=g+VsSpIIvTZp+OYSzc71ePgWKvh9dbj0dOgrtfhVY08=; fh=oXB35Ft6gMu0wrsMTj5S5z7fp4R/QKVyBLXpPjxxEGg=; b=vEfn3kGJqdRMjlAN1rzQ6jAavRsyYg5IKjd+Lx/tsPk9XTZOksPW9v2nNp3/ulG4u6 B+Lp5EI9a8dFwP4TsOBG4z+7qgYNDP/7ML6tzZ4all704f7I50sRuCJH6Ez6JSz7mflw Axy3GkgVULishRWhPTNayDj9CcmaAaU1SeHJTIf3RpPEEOhAZzAtE/KK2ESRNx5TjdHP bpHKWzgnGZXKxgQg+Ok842bKrhKRg9p/BoNNdR19og+in9fhRJUNdke34RPu3Fbq8fs1 2MdSaBaXjIa82VLC5Z3HFMytGL1aTU2fWq1AciINCncrUg9/BFNba/AxsjIfJFXh0341 Zo7w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=nv3YiaN+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u4-20020a170902e80400b001b878f9e11csi6866534plg.54.2023.08.07.19.25.23; Mon, 07 Aug 2023 19:25:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=nv3YiaN+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230327AbjHGVpA (ORCPT + 99 others); Mon, 7 Aug 2023 17:45:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33374 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229615AbjHGVo6 (ORCPT ); Mon, 7 Aug 2023 17:44:58 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BA5B0199C; Mon, 7 Aug 2023 14:44:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=g+VsSpIIvTZp+OYSzc71ePgWKvh9dbj0dOgrtfhVY08=; b=nv3YiaN+c2/xvyBTT2Scu3RVHn Tj4b/HyzInNj8yGoInNGOYxe01yyjWs033Jma+vixDeIw5QdEW3/KFTOOcij/qjKWMuu5yJugNPak 5bGUWL8QxbO2hds1oMmC1dHP1V6cQK2D4CaALau+vpGeX5XE9OvQJDFIO1Yi21zaO8HE2+pk34l2n BVyUdtZzZvxBzsi1joxY+1qA9ciAyv62012YcPxmBErjy0ZIa5JCIYEpqbx+tuJU0O0v/7lnUWQPd Rgxo3BYCj2n7RrlkjDHbuZtr8gKU8wmwOtvkewC4c71qhu+pMW57ycko0SZ5Zi0jULdqh4x1zPD/o G0OdFzXQ==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1qT81L-000nZJ-0p; Mon, 07 Aug 2023 21:44:11 +0000 Date: Mon, 7 Aug 2023 14:44:11 -0700 From: Luis Chamberlain To: Joel Granados Cc: Catalin Marinas , Iurii Zaikin , Jozsef Kadlecsik , Sven Schnelle , Marcelo Ricardo Leitner , Steffen Klassert , Kees Cook , "D. Wythe" , mptcp@lists.linux.dev, Jakub Kicinski , Vasily Gorbik , Paolo Abeni , coreteam@netfilter.org, Jan Karcher , Alexander Aring , Will Deacon , Stefan Schmidt , Matthieu Baerts , bridge@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, Joerg Reuter , Julian Anastasov , David Ahern , netfilter-devel@vger.kernel.org, Wen Gu , linux-kernel@vger.kernel.org, Santosh Shilimkar , linux-wpan@vger.kernel.org, lvs-devel@vger.kernel.org, Karsten Graul , Miquel Raynal , Herbert Xu , linux-sctp@vger.kernel.org, Tony Lu , Pablo Neira Ayuso , Ralf Baechle , Florian Westphal , willy@infradead.org, Heiko Carstens , "David S. Miller" , linux-rdma@vger.kernel.org, Roopa Prabhu , Alexander Gordeev , Simon Horman , Mat Martineau , josh@joshtriplett.org, Christian Borntraeger , Eric Dumazet , linux-hams@vger.kernel.org, Wenjia Zhang , linux-fsdevel@vger.kernel.org, linux-s390@vger.kernel.org, Xin Long , Nikolay Aleksandrov , netdev@vger.kernel.org, rds-devel@oss.oracle.com, Joel Granados Subject: Re: [PATCH v2 00/14] sysctl: Add a size argument to register functions in sysctl Message-ID: References: <20230731071728.3493794-1-j.granados@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Luis Chamberlain X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 31, 2023 at 02:36:50PM -0700, Luis Chamberlain wrote: > > Joel Granados (14): > > sysctl: Prefer ctl_table_header in proc_sysctl > > sysctl: Use ctl_table_header in list_for_each_table_entry > > sysctl: Add ctl_table_size to ctl_table_header > > sysctl: Add size argument to init_header > > sysctl: Add a size arg to __register_sysctl_table > > sysctl: Add size to register_sysctl > > sysctl: Add size arg to __register_sysctl_init > > This is looking great thanks, I've taken the first 7 patches above > to sysctl-next to get more exposure / testing and since we're already > on rc4. Ok I havent't heard much more feedback from networking folks, and since this is mostly sysctl love I've taken in the rest of these patches. Thanks to Jani Nikula for the reviews and to Greg KH for the suggestion on simplifying things. Let's see what busts in linux-next, and if anything does I can reset my tree back to only the first 7 patches. Luis