Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230808020917.2230692-1-fengwei.yin@intel.com>
In-Reply-To: <20230808020917.2230692-1-fengwei.yin@intel.com>
From:   Yu Zhao <yuzhao@google.com>
Date:   Mon, 7 Aug 2023 20:43:49 -0600
Message-ID: <CAOUHufa99BbKi3pq2xxrNEzygULE-brUELK=DLU89REW-GT-Vw@mail.gmail.com>
Subject: Re: [PATCH v2 0/3] don't use mapcount() to check large folio sharing
To:     Yin Fengwei <fengwei.yin@intel.com>, akpm@linux-foundation.org
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        stable@vger.kernel.org, willy@infradead.org,
        vishal.moola@gmail.com, wangkefeng.wang@huawei.com,
        minchan@kernel.org, david@redhat.com, ryan.roberts@arm.com,
        shy828301@gmail.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Aug 7, 2023 at 8:10=E2=80=AFPM Yin Fengwei <fengwei.yin@intel.com> =
wrote:
>
> In madvise_cold_or_pageout_pte_range() and madvise_free_pte_range(),
> folio_mapcount() is used to check whether the folio is shared. But it's
> not correct as folio_mapcount() returns total mapcount of large folio.
>
> Use folio_estimated_sharers() here as the estimated number is enough.
>
>
> This patchset will fix the cases:
> User space application call madvise() with MADV_FREE, MADV_COLD and
> MADV_PAGEOUT for specific address range. There are THP mapped to the
> range. Without the patchset, the THP is skipped. With the patch, the
> THP will be split and handled accordingly.
>
> David reported the cow self test skip some cases because of
> MADV_PAGEOUT skip THP:
> https://lore.kernel.org/linux-mm/9e92e42d-488f-47db-ac9d-75b24cd0d037@int=
el.com/T/#mbf0f2ec7fbe45da47526de1d7036183981691e81
> and I confirmed this patchset make it work again.
>
>
> Changelog from v1:
>   - Avoid two Fixes tags make backport harder. Thank Andrew for pointing
>     this out.
>
>   - Add note section to mention this is a temporary fix which is fine
>     to reduce user-visble effects. For long term fix, we should wait for
>     David's solution. Thank Ryan and David for pointing this out.
>
>   - Spell user-visible effects out. Then people could decide whether
>     these patches are necessary for stable branch. Thank Andrew for
>     pointing this out.

LGTM, thank you.