Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230721101349.12387-1-victorshihgli@gmail.com> <20230721101349.12387-5-victorshihgli@gmail.com>
In-Reply-To: <20230721101349.12387-5-victorshihgli@gmail.com>
From:   Ulf Hansson <ulf.hansson@linaro.org>
Date:   Tue, 8 Aug 2023 12:28:06 +0200
Message-ID: <CAPDyKFrmwct=b6angucfrKOXneZXe+_2KQ4f--OQEoKD=fc5hg@mail.gmail.com>
Subject: Re: [PATCH V9 04/23] mmc: core: Extend support for mmc regulators
 with a vqmmc2
To:     Victor Shih <victorshihgli@gmail.com>
Cc:     adrian.hunter@intel.com, linux-mmc@vger.kernel.org,
        linux-kernel@vger.kernel.org, benchuanggli@gmail.com,
        HL.Liu@genesyslogic.com.tw, Greg.tu@genesyslogic.com.tw,
        takahiro.akashi@linaro.org, dlunev@chromium.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, 21 Jul 2023 at 12:14, Victor Shih <victorshihgli@gmail.com> wrote:
>
> From: Ulf Hansson <ulf.hansson@linaro.org>
>
> Updates in V4:
>  - Moved the voltage defines into this patch.
>
> Update in previous version:

Please drop the version information from the commit message.

> To allow an additional external regulator to be controlled by an mmc host
> driver, let's add support for a vqmmc2 regulator to the mmc core.
>
> For an SD UHS-II interface the vqmmc2 regulator may correspond to the so
> called vdd2 supply, as described by the SD spec. Initially, only 1.8V is
> needed, hence limit the new helper function, mmc_regulator_set_vqmmc2() to
> this too.
>
> Note that, to allow for flexibility mmc host drivers need to manage the
> enable/disable of the vqmmc2 regulator themselves, while the regulator is
> looked up through the common mmc_regulator_get_supply().
>
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>

[...]

Kind regards
Uffe