Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ad26d275-4373-429f-ecaa-3e35978f1fb0@amd.com>
Date:   Tue, 8 Aug 2023 15:55:56 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH v6 3/4] drm: Expand max DRM device number to full
 MINORBITS
Content-Language: en-US
To:     Simon Ser <contact@emersion.fr>
Cc:     =?UTF-8?Q?Micha=c5=82_Winiarski?= <michal.winiarski@intel.com>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        intel-gfx@lists.freedesktop.org, David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Maxime Ripard <mripard@kernel.org>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        Matthew Wilcox <willy@infradead.org>,
        Oded Gabbay <ogabbay@kernel.org>,
        James Zhu <James.Zhu@amd.com>,
        Pekka Paalanen <pekka.paalanen@collabora.com>,
        Emil Velikov <emil.l.velikov@gmail.com>
References: <20230724211428.3831636-1-michal.winiarski@intel.com>
 <20230724211428.3831636-4-michal.winiarski@intel.com>
 <83s0YPWEdYE6C2a8pa6UAa3EaWZ2zG-q7IL9M-y6W1ucF9V54VnZtigKj3BGKUA2FZpIrs0VVxmpHO2RAhs_FdOnss9vNLQNSHySY8uH7YA=@emersion.fr>
 <69801f61-37b0-3e46-cbef-31ff80ae9a34@amd.com>
 <TAdBP5BOy3cy7VnUb4t7ZkDOMK6wI_gPCjXanItN3TOsA1TbSk_6yrlcPTqvk3AZjamo96yHlEhjpfNUPFF6tA_9K8iRoie3h_z5Jf6zNtc=@emersion.fr>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
In-Reply-To: <TAdBP5BOy3cy7VnUb4t7ZkDOMK6wI_gPCjXanItN3TOsA1TbSk_6yrlcPTqvk3AZjamo96yHlEhjpfNUPFF6tA_9K8iRoie3h_z5Jf6zNtc=@emersion.fr>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?azNpL2o1Rk1KdFRjUG9nMnhoSk11ajRhSkVVajdNZTlnTlVKTmloYUFtbGh6?=
 =?utf-8?B?aUd2ZUxQMXlNSGVBckQrUGtJc0I1ZS9pTDU3czdZVkVYb2ZHOGUyNS9UbGox?=
 =?utf-8?B?K0oxMG1RRjN5bzdIbk1Tc0hydmU5WDNHU0NpdExIaEUyWnVxRkhZeDdEb2hI?=
 =?utf-8?B?aVkxNXc5TDhDVmRKQ2ZNY1p2eXZwTlorT1pJR29iNHlBMk9XU1RRcFlFVVYx?=
 =?utf-8?B?MVNLVHVKMVBXM2hoM0ZFKzY0K1RuR1lORGVtaGI2MDV4UHpFNmwrTCtqZWRz?=
 =?utf-8?B?VFRId09xWEZnNnFIOHVpSEd0VHkvSTlsZFFla2dRQVBLNTBQV0hLcHpEQkp4?=
 =?utf-8?B?UWprWjZJTURmNHdxSW96dkU0MzVta3lsUUVRUmU4WnlrcDZuUXRIOVJMY21E?=
 =?utf-8?B?bWhva3hCbzg3RE40ZGkyL3VXR1ZZNjBTdkorZWZaeGM1VHROWUJjbDJkTGJK?=
 =?utf-8?B?TGxXWWlRNWo2S1FxNG05MW11RUY2RWtLaHAwWmhTNGFhVXpZOGo2NDUyQ0t6?=
 =?utf-8?B?TU9qM0FYTVVid29sSDMySEdSWjVqU2xCY0p5VFdqSktlc2JKMlJ4c1NEVE5l?=
 =?utf-8?B?clVXOXVQaVVxWVpsR2JYSDNZSGxWOWxKN25ZTjl5UHloTC9ocldaTzA5Wmhj?=
 =?utf-8?B?SW9OK2tCdnhjRkc2MmUvelB1a3NjaFl2dEt0aHFtVVc1MG9EUFZGd0xIT3pQ?=
 =?utf-8?B?c3g1SUozcUJmUG9yTDYwL2UzU3lnU0VzK2J2SThJV2R5TlJZdEJ5aS9MbWh0?=
 =?utf-8?B?cEhvV2p2VUtjMnFaa0drQmtGWGlac3dVVDlvbExQNnpXM0piY0NPU05SR1Ns?=
 =?utf-8?B?bW1SWDhiRUwwRXM5dWNpMlRRYkZpOFVqUFdyUjFkckd5dkUwQWczd01qckh1?=
 =?utf-8?B?U2hoMmNIWWFMOWVUQ3dLTitoSjVvY252RmZQc3RZempzdlIyakg2aWpHNWI0?=
 =?utf-8?B?elI2QmhxQmY5cHR2K3dWZ0I2V0tkaXJvZnplaXA5K0lEOGM3S0ZKRG4vT1Zi?=
 =?utf-8?B?RWV2b0JUemw5MlJqYTVFUkpEU1FsTkMwV0JEaEpYdm9TQmtHUGpCR0hvY0RQ?=
 =?utf-8?B?aGtNd0NGSmtSODFFMXBsbSttQXJvVzZjeGU1ZmcxR1FZeUpscVN5QURyeGlB?=
 =?utf-8?B?enpkODVNOE5la3h4TUZ2SDIzTnZnN3RHMDZmU0tvZVUwU25rUHd4SWpLR0E5?=
 =?utf-8?B?ck5lYW5McnllU0VXVDg0T1pnNmhBQk8rU3hSUW03SUgwWlhkWlV4dzl2Ui9w?=
 =?utf-8?B?UkUvNFRHMW5YYnhEdmFGM1lnK1IzZ0hCSFR1U25FdVVsaVRJanhLb09Lem80?=
 =?utf-8?B?cElGcmRkS3YrM1ZzK0E0K1dPRzg2NjVTdXc2REZGTEFCTUoyTXFUSmFSLzNP?=
 =?utf-8?B?bWtwckZUeXR6N1dCV2R0UHEwTE9LeVVoajZ2VDMrMVBtZXAvOTBCZWdrNmNu?=
 =?utf-8?B?bThsZGZ2dk9uSjR1QTRyd3Z1ZWthRmlrdlhFWE91ZGdpUDNUcWJhd1g5WEFV?=
 =?utf-8?B?ZG9RdWk2bUdLYWs5Yk8rVEJQcWpISEowVDcwSnRPdGZlVzBJOEdZcHpPREVt?=
 =?utf-8?B?L0g5TTJvR1dkQ0ZsZTJpSG9Nb0prbzcvYXJzYVpQeG1JZTJxbzlxWis4Ykt0?=
 =?utf-8?B?NW5zUUErWlRGUVZCQ25TOGZ4WU5BTTBOWkp6Witaa2lVT21UZmN1eFZtMktB?=
 =?utf-8?B?eDV1Um1hUEhHaUV2cStFTzg0V0RHN0dFaFpSNU9Ram5pL3JiaWorcFR0U3k4?=
 =?utf-8?B?U1FBcGIvb2YrTTd2KzErd2pCNnhJejFGOUtad1Rtc2QvZXR2U3d6NVBwS3lZ?=
 =?utf-8?B?YXhlak1tMzZNbkRZemFlenZiQytwMWhyNUc3MmNyMkNKaUlQQzIyS2FxMzdR?=
 =?utf-8?B?S2lmWjQvY084WTFUaW5zSkM1dGxST0JSaldDL3orZC8wbDF4Y2djUkpJOUV6?=
 =?utf-8?B?Q0RSWjZtWTRFLy9XRTF2LzM3WTBvUFhEKzY1SVdxbENPNVd2cWJTd0R4R0E0?=
 =?utf-8?B?OFRKZXlyN1psUm1ENDI1amE4dytTNGNacWJxK1Qyc0Y2STNUUnRhK1dQekVo?=
 =?utf-8?B?ZFB5WWNRRmwyTU42QnJRRkZJSWw3WmE2Q0w0MTZLY3pIcTRWYlM1V3hIdDJM?=
 =?utf-8?B?Y0xLeDVMN2FEakd0TkpnR3RXN1ZJdWZtNmZaMkpGY1VzOWNOdVkzbDl5NU5C?=
 =?utf-8?Q?veaPBXnoOIkRjJc6UwJR5jL8tDJPcOlM5iH1ajVxbYuD?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f085530a-e6ff-4464-6791-08db9817336f
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3587.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2023 13:56:02.0070
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: eYgmixIhzTLHf5Z7i5Upf3gzFlrztsCI4og5VBgTlNcjmlF0ZN9sHXZJsMgnPjyt
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB5421
X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_PASS,SPF_NONE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 28.07.23 um 16:22 schrieb Simon Ser:
> On Thursday, July 27th, 2023 at 14:01, Christian König <christian.koenig@amd.com> wrote:
>
>>> We do need patches to stop trying to infer the node type from the minor
>>> in libdrm, though. Emil has suggested using sysfs, which we already do
>>> in a few places in libdrm.
>> That sounds like a really good idea to me as well.
>>
>> But what do we do with DRM_MAX_MINOR? Change it or keep it and say apps
>> should use drmGetDevices2() like Emil suggested?
> DRM_MAX_MINOR has been bumped to 64 now.
>
> With the new minor allocation scheme, DRM_MAX_MINOR is meaningless
> because there is no "max minor per type" concept anymore: the minor no
> longer contains the type.
>
> So I'd suggest leaving it as-is (so that old apps still continue to
> work on systems with < 64 devices like they do today) and mark it as
> deprecated.

Sounds like a plan to me.

Regards,
Christian.