Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <58ff2350-9e07-36a3-e7a6-f882b292bc35@quicinc.com>
Date:   Tue, 8 Aug 2023 08:31:46 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH V25 0/3] misc: Add driver support for Data Capture and
 Compare unit(DCC)
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC:     Trilok Soni <quic_tsoni@quicinc.com>,
        Andy Gross <agross@kernel.org>,
        Konrad Dybcio <konrad.dybcio@somainline.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Rob Herring <robh+dt@kernel.org>, Alex Elder <elder@ieee.org>,
        Arnd Bergmann <arnd@arndb.de>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
        <devicetree@vger.kernel.org>, Sibi Sankar <quic_sibis@quicinc.com>,
        "Rajendra Nayak" <quic_rjendra@quicinc.com>
References: <cover.1687945879.git.quic_schowdhu@quicinc.com>
 <f25f8c43-2996-23ff-e6af-9e39b7fced86@quicinc.com>
 <774b688f-0324-9097-6504-58d15a3e6afb@quicinc.com>
 <2023080438-reacquire-obsessed-3e81@gregkh>
 <2023080408-zoom-defraud-1ae8@gregkh>
 <75c25eac-e92c-5ca2-4ef6-06ee89584ce6@quicinc.com>
 <2023080753-decode-outgoing-b6c6@gregkh>
Content-Language: en-US
From:   Souradeep Chowdhury <quic_schowdhu@quicinc.com>
In-Reply-To: <2023080753-decode-outgoing-b6c6@gregkh>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 8/7/2023 11:14 PM, Greg Kroah-Hartman wrote:
> On Mon, Aug 07, 2023 at 11:03:45PM +0530, Souradeep Chowdhury wrote:
>>
>>
>> On 8/4/2023 7:19 PM, Greg Kroah-Hartman wrote:
>>> On Fri, Aug 04, 2023 at 03:47:26PM +0200, Greg Kroah-Hartman wrote:
>>>> On Thu, Aug 03, 2023 at 07:35:18AM -0700, Trilok Soni wrote:
>>>>> On 8/3/2023 12:06 AM, Souradeep Chowdhury wrote:
>>>>>>
>>>>>>
>>>>>> On 6/28/2023 3:53 PM, Souradeep Chowdhury wrote:
>>>>>
>>>>> ...
>>>>>
>>>>>>>
>>>>>>> https://git.codelinaro.org/clo/le/platform/vendor/qcom-opensource/tools/-/tree/opensource-tools.lnx.1.0.r176-rel/dcc_parser
>>>>>>>
>>>>>>> Changes in v25
>>>>>>>
>>>>>>> * Updated the documentation of the structure dcc_config_entry as per
>>>>>>> the comments in V23
>>>>>>> * Updated the documentation of the dcc Kconfig definition as per
>>>>>>> comment in V24
>>>>>>> * Used u64 where applicable
>>>>>>> * Removed the mutex locks where it is not needed
>>>>>>> * Removed the use of unlikely keyword
>>>>>>> * Renamed "nr_link_list" to "max_link_list"
>>>>>>>
>>>>>>> Souradeep Chowdhury (3):
>>>>>>>      dt-bindings: misc: qcom,dcc: Add the dtschema
>>>>>>>      misc: dcc: Add driver support for Data Capture and Compare unit(DCC)
>>>>>>>      MAINTAINERS: Add the entry for DCC(Data Capture and Compare) driver
>>>>>>>        support
>>>>>>>
>>>>>>>     Documentation/ABI/testing/debugfs-driver-dcc  |   10 +-
>>>>>>>     .../devicetree/bindings/misc/qcom,dcc.yaml    |   44 +
>>>>>>>     MAINTAINERS                                   |    8 +
>>>>>>>     drivers/misc/Kconfig                          |    8 +
>>>>>>>     drivers/misc/Makefile                         |    1 +
>>>>>>>     drivers/misc/qcom-dcc.c                       | 1312 +++++++++++++++++
>>>>>>>     6 files changed, 1378 insertions(+), 5 deletions(-)
>>>>>>>     create mode 100644 Documentation/devicetree/bindings/misc/qcom,dcc.yaml
>>>>>>>     create mode 100644 drivers/misc/qcom-dcc.c
>>>>>>
>>>>>> Gentle Ping
>>>>>
>>>>> Thank you for the reminder Souradeep. Greg and others, please see if we need
>>>>> any changes here or it can be picked up?
>>>>
>>>> It would help if the code would actually build:
>>>>
>>>> drivers/misc/qcom-dcc.c: In function ‘ready_read’:
>>>> drivers/misc/qcom-dcc.c:853:13: error: unused variable ‘ret’ [-Werror=unused-variable]
>>>>     853 |         int ret = 0;
>>>>         |             ^~~
>>>>
>>>> {sigh}
>>>>
>>>> How in the world was this ever tested?
>>>
>>> Ok, next time I want to see some QCOM engineers to sign off on this that
>>> it was actually tested and they can back it up that this is ready to be
>>> merged.  When the code doesn't even build, that is a huge red flag that
>>> this whole thing is being rushed as it obviously was never tested in the
>>> form that was submitted for inclusion.
>>>
>>> You all know better than this.
>>
>> My apologies on missing out on this, it is a W=1 level compilation warning
>> that got suppressed on a normal kernel build.
> 
> No, not at all, it showed up on my "normal kernel build", I do not have
> "W=1" set at all.
> 
> If you did a simple "make allmodconfig" I am pretty sure it would have
> tripped this.
> 
> How exactly was this tested?

My toolchain interprets this as a W=1 level warning rather than an 
error. So I am able to build the kernel with it. Probably because I
am using an older version. Will correct this in the next version.

> 
> thanks,
> 
> greg k-h