Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 7 Aug 2023 20:20:27 -0700
From:   Dan Williams <dan.j.williams@intel.com>
To:     Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>,
        <linux-pci@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-cxl@vger.kernel.org>
CC:     Bjorn Helgaas <bhelgaas@google.com>, <oohall@gmail.com>,
        Lukas Wunner <lukas@wunner.de>,
        Kuppuswamy Sathyanarayanan 
        <sathyanarayanan.kuppuswamy@linux.intel.com>,
        Mahesh J Salgaonkar <mahesh@linux.ibm.com>,
        Alison Schofield <alison.schofield@intel.com>,
        "Vishal Verma" <vishal.l.verma@intel.com>,
        Ira Weiny <ira.weiny@intel.com>,
        "Ben Widawsky" <bwidawsk@kernel.org>,
        Dan Williams <dan.j.williams@intel.com>,
        Jonathan Cameron <Jonathan.Cameron@huawei.com>,
        Yazen Ghannam <yazen.ghannam@amd.com>,
        Terry Bowman <terry.bowman@amd.com>,
        Robert Richter <rrichter@amd.com>,
        Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>
Subject: RE: [PATCH v2 2/3] PCI/AER: Export pcie_aer_is_native()
Message-ID: <64d1b47b7bd8_5ea6e2948c@dwillia2-xfh.jf.intel.com.notmuch>
References: <20230721214740.256602-1-Smita.KoralahalliChannabasappa@amd.com>
 <20230721214740.256602-3-Smita.KoralahalliChannabasappa@amd.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230721214740.256602-3-Smita.KoralahalliChannabasappa@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?K/g7mIoz93m0ZxX0xXfKTiJT/4hjseOnLj+pad/9awvIxQsihLzGdoFyjfG9?=
 =?us-ascii?Q?es1UbMeYlzxmxQOWJtEuTijzmAIX0pmH99/3j2itkQv+eQzCfqTjY2G5uqfR?=
 =?us-ascii?Q?LxJRXi0ulCKRZJfXXf3BGNwP1DdyaEB1E8hEI2OGeVXD1EI4XTQ2YpH8s3Hy?=
 =?us-ascii?Q?PSzRyCxPFF0sJO/ZjHvylVZz0kBJSMBy3UaUcwE8bwBKSWdyEDM0r2aVamdu?=
 =?us-ascii?Q?ZYGYGSUjMAhixS9L5HvHhf8a+SJ8Bhk+fGRgAH+oTTCF+3vII93wz3pEyGSJ?=
 =?us-ascii?Q?RS9guRbEwTPLPV0aM9HNKmelfYvrUyN/zhGHx9TqZxybCKA+KkE3fgwH+i7X?=
 =?us-ascii?Q?BFvndqN1PABeaAxcelQq4A5CA6/86XDOV35mv4m1EqQyeSopq47Etdqw2l6s?=
 =?us-ascii?Q?OJtr5/LD8Ugb2sll2cI+0v/EmlO+4Ld390rjvV3yCxLZhcG6De0n9Fkp0pbi?=
 =?us-ascii?Q?4wHhXdBj/FglYbHbNv0uzcDqwKfmdyiB7aTPPuMXXDvgR2K0UGkJgb/CJZgB?=
 =?us-ascii?Q?nbqZxqcTcU/hXHo4dEjTfW+Fvkj8ywnArA2p68HV3DV3HyJiWEXnWKxLO/bR?=
 =?us-ascii?Q?wnsMcfR5Lx4uafUWv8AOJGJALyDVAMpSLl4IsK4qtQSK5h0zZAsPB6UX7CvD?=
 =?us-ascii?Q?cnJVgX5SyqA8331vpWp70Bx6BxN1A2UCV4UrAa/9yQm45k+Gm2tb4jfwq65a?=
 =?us-ascii?Q?efUc1Dj/1V/7VmFubTFPI1lGvvnrqJ5ukMcyv97eH/HTNRVNEZtIPnYMb1L6?=
 =?us-ascii?Q?5Bxvwblv525n9dy1+V2pzY47hpCMo2x8ViP4+Z0lkvRYI+OLMHmpiwsUfwYB?=
 =?us-ascii?Q?1UfUe86ZrWig1pDv+T8Nq9JemyaCi7MY7JOjWr5V+uP6yoVRYDJkeG8iFQUF?=
 =?us-ascii?Q?mKpeal83d7s9DWWxiKd9hdLHXUAMAgV42xVyarUIzbPKKasNP8lDgE+aMjSA?=
 =?us-ascii?Q?LJV6WQTI37yxeTboxmZ1RF38DewVjgtp6bYjm8a7q2M07lRz2L0EbJ6danzk?=
 =?us-ascii?Q?u83T61MKQhC4rSXEfOxDJ6qni+yj60SpvT79qlM2oGhV1un2wJmlFuVoiiiz?=
 =?us-ascii?Q?EKAWCAdzF55d7tuoXWDhIRd/tLTuho7+o0UYAEGsIYJaulsgAtI73If5nGbg?=
 =?us-ascii?Q?6Ld3fXiF/sVWcL9/WAAH8J+SgaOMVJr066zmVRZV0VeTxepfVCvWvsRUWAtm?=
 =?us-ascii?Q?zWK0glazMoRf3Kwm5GE7Gc8youNVQ4g2lyfeBSJkqaJPsTtsW8iJfPr0o3r1?=
 =?us-ascii?Q?v0w5pfq9niwfctc1zDjl1CyYT2EzySz45xPcs+9m/Z3watd7oFXvehAEVPvs?=
 =?us-ascii?Q?UI2oQeeRh4kGC8hEda2dOP2/WYmZIQX3WhpaImnkefHDGOI7TBHcxDqwerfn?=
 =?us-ascii?Q?2764gRIbPiCIT8200qUnySmceLplAJbQxLwn63lVZHAQ+Kikq/4HOn6sKCXl?=
 =?us-ascii?Q?r6xoaTE9ItAYhgLTaT4GpEM+C7TsJZPJ7huZAPebTHWRjW7u+42lKV19Zj2M?=
 =?us-ascii?Q?Rhl1Tps6IFTY2xRC7vNN7hTLiH8evliaqj6pmPY7f0KFPQx9pFjwdIYWU6EJ?=
 =?us-ascii?Q?am8GSPiOlTOKsIL4mhOG4pyeO1AOftKSPS23Ovm2UerQ1tfq4P68dWfuDrvT?=
 =?us-ascii?Q?6w=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 014b1076-c327-46f2-2864-08db97be6b70
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2023 03:20:30.6810
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: g9sFpGY0MSfqnA9Nbw2xpKhg2JNJcNBdIy0pzPRMeNBtUgD8aDKzrWboMHj5tlXC03W6Haumcc4QmsibLgJxixTJWm6VVur+3qtOCR/9UlU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB8344
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,
        RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Smita Koralahalli wrote:
> Export and move the declaration of pcie_aer_is_native() to a common header
> file to be reused by cxl/pci module.
> 
> Signed-off-by: Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>
> Acked-by: Bjorn Helgaas <bhelgaas@google.com>
> Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
> ---
> v2:
> 	Fixed $SUBJECT
> ---
>  drivers/pci/pcie/aer.c     | 1 +
>  drivers/pci/pcie/portdrv.h | 2 --
>  include/linux/aer.h        | 2 ++
>  3 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c
> index f6c24ded134c..87d90dbda023 100644
> --- a/drivers/pci/pcie/aer.c
> +++ b/drivers/pci/pcie/aer.c
> @@ -229,6 +229,7 @@ int pcie_aer_is_native(struct pci_dev *dev)
>  
>  	return pcie_ports_native || host->native_aer;
>  }
> +EXPORT_SYMBOL_GPL(pcie_aer_is_native);

I would put this in the CXL symbol namespace since no other driver has
any business using this. Only the CXL subsystem, which is forced by the
specification to take on some PCI core work in its endpoint driver,
needs this export.

Otherwise, looks good to me.