Received: by 2002:a05:6359:6284:b0:131:369:b2a3 with SMTP id se4csp4546789rwb; Tue, 8 Aug 2023 10:00:38 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGTK+XjqVjh8YSuK2I7rvwZnCkdgfbA75QXiRb5LNKdZ86YKpjGZDKnfU3hP9RFpEO6ver2 X-Received: by 2002:a19:435d:0:b0:4fb:7626:31a8 with SMTP id m29-20020a19435d000000b004fb762631a8mr62278lfj.27.1691514037720; Tue, 08 Aug 2023 10:00:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691514037; cv=none; d=google.com; s=arc-20160816; b=THw6Unuq3axYsxIIjn/w7w8/6fcIYFJYb3gOv9u9ZmEbN+Cvjkj+2I8boXNwjd6Tb+ YBF9d4f4DdD2IGh4rxC+JRn8B7qTG5tPTXsOyH9NXUfQ+Ip6YytcwDj7A+HFrWD5vvld QHm1gd5tqYoPbTT8NlkpN6jp6zWjwbQhw+uxdbUYktVwSYBpUxgKrnANk7EkPh0Vxypd VriovqpMs1YEIQj36aaQz+5+25B3F59bk0qbKl7Bj0MQo9azkA4zEjmovWQVXrdTsqSt RwLYT32uRtxtT+20ZuPE49aIDI322nHe5788GFBkD5NBwmXpP5kXyl9AUx78ExdK6Rz0 PWFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=gXk7DwMJMx/+3yv/T7rkRo4kLX/dp8aZ/xLu8Eduf/8=; fh=5ALpVpDpEckpdPok08TSIjR/uc1zIXVyyhblh401P0I=; b=AMr4EDO4OgFtwFU38+aRpVcGZJn+G6n2gfT+E0wLFH6+mS773nzI3qPlnkssclMpEJ a8pApBlgW5DeDf/Ka5c667I27KHmmuRUihst3/CQBhqtUuRIy7WFoVbzGBWKulQtDki3 zptotEiqquzskLg9bKcATjcX/bSgXNMtfrT/NUkJcrSouR87Q3ZnuwtDJr1oDcoEQHeC hBonPuhApnXVsyqWKm/SbB8JUKHiuZpH5F1VM7OkK6GEKdUYAXXC4JKQVTLyDGyHWz7J SD31FO3f3Gy8AiFx7CjVCGxo80YHmznWxoOqiKJbYRNNdrjr00EdHUKtk4fy5DGczBE+ 0LCw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l23-20020aa7c3d7000000b00522aab68c9fsi7407163edr.491.2023.08.08.10.00.12; Tue, 08 Aug 2023 10:00:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233477AbjHHQqj (ORCPT + 99 others); Tue, 8 Aug 2023 12:46:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39190 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231904AbjHHQpq (ORCPT ); Tue, 8 Aug 2023 12:45:46 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9C94519B0; Tue, 8 Aug 2023 08:56:27 -0700 (PDT) X-IronPort-AV: E=McAfee;i="6600,9927,10795"; a="437152560" X-IronPort-AV: E=Sophos;i="6.01,156,1684825200"; d="scan'208";a="437152560" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Aug 2023 06:25:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10795"; a="766380704" X-IronPort-AV: E=Sophos;i="6.01,156,1684825200"; d="scan'208";a="766380704" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga001.jf.intel.com with ESMTP; 08 Aug 2023 06:25:05 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qTMhr-009eNj-2l; Tue, 08 Aug 2023 16:25:03 +0300 Date: Tue, 8 Aug 2023 16:25:03 +0300 From: Andy Shevchenko To: Wenhua Lin Cc: Linus Walleij , Bartosz Golaszewski , Orson Zhai , Baolin Wang , Chunyan Zhang , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, wenhua lin , Xiongpeng Wu Subject: Re: [PATCH 3/3] gpio: sprd: Add clear interrupt Message-ID: References: <20230808033144.2276-1-Wenhua.Lin@unisoc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230808033144.2276-1-Wenhua.Lin@unisoc.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_SOFTFAIL autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 08, 2023 at 11:31:44AM +0800, Wenhua Lin wrote: > Clear interrupt after set the interrupt type. Why? Can't it be done in the ->init_hw() callback of GPIO IRQ chip? -- With Best Regards, Andy Shevchenko