Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4e26eb3e-1cfb-2572-4002-b7abda022e5e@intel.com>
Date:   Tue, 8 Aug 2023 15:17:22 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH net-next v4 0/6] page_pool: a couple of assorted
 optimizations
Content-Language: en-US
To:     <patchwork-bot+netdevbpf@kernel.org>
CC:     <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
        <pabeni@redhat.com>, <maciej.fijalkowski@intel.com>,
        <larysa.zaremba@intel.com>, <linyunsheng@huawei.com>,
        <alexanderduyck@fb.com>, <hawk@kernel.org>,
        <ilias.apalodimas@linaro.org>, <simon.horman@corigine.com>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20230804180529.2483231-1-aleksander.lobakin@intel.com>
 <169143962373.20323.15736867821555960200.git-patchwork-notify@kernel.org>
From:   Alexander Lobakin <aleksander.lobakin@intel.com>
In-Reply-To: <169143962373.20323.15736867821555960200.git-patchwork-notify@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?end6YTcrMnlOVGRselNwcnVyMU1GdHgrb29peE15YTJkUTdtUVFEb2VDQk5I?=
 =?utf-8?B?ajBUM3A2UUZoK2xzUlA3ZEtRZXRTRHlPNWNuemtTU0ZTb2NVVHBUbmZ4T1dh?=
 =?utf-8?B?Nll0cndCYWlIb2dLMTlURlFrczBjdkhPYlRhTVJTZkwrQjBWMm9adzh5Y1pa?=
 =?utf-8?B?M2hUSTZBalg3L3huS2hQT3NDTG5BM3dBTWplT094Vm11NUoxWUM5cGpZWFJV?=
 =?utf-8?B?MWpMLy95MS84SHU4STF2ZlZ3bVIzdWtubkVYN1BnL2FuaXRqclNCSHg1bWJS?=
 =?utf-8?B?WkFPMGV5cGNuWm9vdGZnbTBiYzdlN0NhTzlGMUs0VUpqN2JmcGRJWkFUTWNy?=
 =?utf-8?B?Vm1DYnFrSFltaEZxR0RUd0kyeWdVS0cyeTdGcncxRENvZ3ZtN3ZrYWlRbmFK?=
 =?utf-8?B?TEplTWxtOEpObFdaWmU5SU9WNTVCbUF6TFQ0QnFuSTZDUDdqa2oveXROV3FT?=
 =?utf-8?B?aCtma1NwZzhDbWhUSGZqdHFVL21tVGJicHhwUW9NcUZrQ2JhMGlSOSs1dDlY?=
 =?utf-8?B?bERyUk82RDhsMmxFMHI2b0QxSzVwR2NVRDdaQmVvQmp4Y2MwekxxTzRVN2FG?=
 =?utf-8?B?L244SFMwUzFUaGdPMHAwcUtjMVFsaS9XWmI4RDhZeWpOQTdIQ2p3OWhxbUUw?=
 =?utf-8?B?UkJlaDlJRENsdEhaMWFhakNnNDc4eDljdzdvZlZZVjAzeEZSQ0VKeFlsZU5t?=
 =?utf-8?B?UStKRlZqWjNWRXlCRWhpWmlxekxIamk3NWxxc1BNMFNIdi9NaW5NWGk3ZFJI?=
 =?utf-8?B?b0ZkbjNydG92YndBL2V6a2RwWXNKQ0ZzNWVGekZaSDZuWlNKcnhheFdoN2Nm?=
 =?utf-8?B?bTQ3YWdpTjEwczJ5QlBVT0NXRUxaazEzTkVRdHc0ckpPTnN4eEZTS0dMNmdq?=
 =?utf-8?B?c3gxa05tRWNPdm9jZkJmSlJ1TVhUUG9PRkRzaDcyLzd1MHlwM1ZBWmZpT2Ir?=
 =?utf-8?B?TzlyVkxYWG0xUzNwZzl6OXc1YUhYOHk5WU9pSFBOL0JnUGdXU0NYdGtXN3JT?=
 =?utf-8?B?Mk5CNHNLTnRVeXZYMmxhTXJxMkMvN1JybC9EV0xjNGpUVkFkTFVrSFlOT09O?=
 =?utf-8?B?KzI2MVhBcWpQaVpiOGlmUXU1SVNMb2ZQWGpiNi9MNytuY3pscnAzS2JQN3Rj?=
 =?utf-8?B?em5wMkhhS1JjT3lxeWlHL2xHUitQQ01mSUxxU3o4aEFvdVRIeHlPdCtOWnYr?=
 =?utf-8?B?NnhXZTVVclpvSVNaTFFydGxXVjE5R2VyWWhJOHk5RmI1VW9VWnJ2alF0Rzgx?=
 =?utf-8?B?YkZTeEJsSHd6UnBGWUpVbzhLazBXVFRrRDVrNVhRd21JL3hYRy92RVVvaElO?=
 =?utf-8?B?MEJuWDlhTmMzb3F1WWpvMjNZcHhMNUVKNUFnQ0xZNU1GV0RScnhGRENWQnlP?=
 =?utf-8?B?anFTWlN2bG81TmlrcDRCVHptYUN1Z2xneW1oeVBPUHhGOFpnSUxFcWhWWXRG?=
 =?utf-8?B?aTg0ajNSaHdaMVZJYTZpaFJ1aDJCRHhWdlNvejVRMHRvMmtBdFFMODR1aVFM?=
 =?utf-8?B?QzJGSFh1b09KMFdzT1N0ajU2cC9GWlZNQ1ZhQ0k2R1lZMWI5eUdGQVdXV3Z2?=
 =?utf-8?B?a0RTdHlSQXFQa29DaDI3ZDdybm9jdHh6WkdzYkpneVdoZzhyS0tPQTN5UUI1?=
 =?utf-8?B?ZmV3dmRjVVJQL2xFcER0cFI2cWRGV2ZMdGJ3WmRWckxvVE1ieFpwUksvaWp6?=
 =?utf-8?B?bzl5a0RlcTNrOTUzRnQwSTJvelkwd25aVmh1NTFGc0xKc1JOWWp0TjhNZGlE?=
 =?utf-8?B?cjNRMXRVQnVrVkV3MnlXWVhzSjJaNHhhMC95T29IS1lPeFFHMHZoWDNobWRy?=
 =?utf-8?B?aWQ1cEt6RmJvQlZ6UzlUcElPZ0IxeVdaWnpvUlRMemU1TEkrTG5nZ28zQ3hq?=
 =?utf-8?B?VGE5c1MzWGRjZFA1dEhrMFJSQVBxK2ZXUTVpQTlac0tGUnB2dTBSaTcxcDdL?=
 =?utf-8?B?dzIrTGd1V0hPNko1bUd3TysvaW5kN01zNmtGYnBVcUdRM3JBaUp0NXVzRTZV?=
 =?utf-8?B?aFZBMFNQcXJZMTUveG9TWXpoN3N2cC80VlRWamIwMmo4cVdhQWdZYUpVTkhp?=
 =?utf-8?B?NUc5NlJEUmd4ajNoakxmUXFpVFNEOUtIVlZxRVBXa2xHZllPb25aMWRIbWJq?=
 =?utf-8?B?ckQ1VG02dk9zR2pic3kwaXBGYnNzSGVsZ1VYZTdSMFh3KzA4NFFXUm9xcm5m?=
 =?utf-8?B?NkE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 73482dd7-4a12-4e51-49d0-08db9811e439
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3625.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2023 13:18:01.5983
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6uS8R87E+ZFzLxsWEhoSHYkq/XnWONw3Pm84nyefyqSBQngw6afTu2/vsU8RIn59Do9DWukQhfVb9aQooelAQEw1N8NHymPl3JYyN5SJwj0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5222
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Patchwork-Bot+netdevbpf <patchwork-bot+netdevbpf@kernel.org>
Date: Mon, 07 Aug 2023 20:20:23 +0000

> Hello:
> 
> This series was applied to netdev/net-next.git (main)
> by Jakub Kicinski <kuba@kernel.org>:

Just got back from the long weekend and saw that mail, nice :D Thanks!

> 
> On Fri,  4 Aug 2023 20:05:23 +0200 you wrote:
>> That initially was a spin-off of the IAVF PP series[0], but has grown
>> (and shrunk) since then a bunch. In fact, it consists of three
>> semi-independent blocks:
>>
>> * #1-2: Compile-time optimization. Split page_pool.h into 2 headers to
>>   not overbloat the consumers not needing complex inline helpers and
>>   then stop including it in skbuff.h at all. The first patch is also
>>   prereq for the whole series.
>> * #3: Improve cacheline locality for users of the Page Pool frag API.
>> * #4-6: Use direct cache recycling more aggressively, when it is safe
>>   obviously. In addition, make sure nobody wants to use Page Pool API
>>   with disabled interrupts.
>>
>> [...]
> 
> Here is the summary with links:
>   - [net-next,v4,1/6] page_pool: split types and declarations from page_pool.h
>     https://git.kernel.org/netdev/net-next/c/a9ca9f9ceff3
>   - [net-next,v4,2/6] net: skbuff: don't include <net/page_pool/types.h> to <linux/skbuff.h>
>     https://git.kernel.org/netdev/net-next/c/75eaf63ea7af
>   - [net-next,v4,3/6] page_pool: place frag_* fields in one cacheline
>     https://git.kernel.org/netdev/net-next/c/06d0fbdad612
>   - [net-next,v4,4/6] net: skbuff: avoid accessing page_pool if !napi_safe when returning page
>     https://git.kernel.org/netdev/net-next/c/5b899c33b3b8
>   - [net-next,v4,5/6] page_pool: add a lockdep check for recycling in hardirq
>     https://git.kernel.org/netdev/net-next/c/ff4e538c8c3e
>   - [net-next,v4,6/6] net: skbuff: always try to recycle PP pages directly when in softirq
>     https://git.kernel.org/netdev/net-next/c/4a36d0180c45
> 
> You are awesome, thank you!

Thanks,
Olek