Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ebcaa6d3-a984-4916-a010-364e11e868ff@intel.com>
Date:   Tue, 8 Aug 2023 12:10:55 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 0/3] don't use mapcount() to check large folio sharing
To:     Yu Zhao <yuzhao@google.com>, <akpm@linux-foundation.org>
CC:     <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
        <stable@vger.kernel.org>, <willy@infradead.org>,
        <vishal.moola@gmail.com>, <wangkefeng.wang@huawei.com>,
        <minchan@kernel.org>, <david@redhat.com>, <ryan.roberts@arm.com>,
        <shy828301@gmail.com>
References: <20230808020917.2230692-1-fengwei.yin@intel.com>
 <CAOUHufa99BbKi3pq2xxrNEzygULE-brUELK=DLU89REW-GT-Vw@mail.gmail.com>
Content-Language: en-US
From:   "Yin, Fengwei" <fengwei.yin@intel.com>
In-Reply-To: <CAOUHufa99BbKi3pq2xxrNEzygULE-brUELK=DLU89REW-GT-Vw@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VFFaTHM2ZHd6cjZkMExORGMwNHhvS2I5UU1sRzdoaVRPeVpXaWlGOVhMU1Zh?=
 =?utf-8?B?S3F3REVSdzlrbzd4c1lRSC8xNWhHT1FjeUpyVDZSWkhTKzltblJQMmJlNlRN?=
 =?utf-8?B?SzJMemcrWEMzNnJjNWRkcS9Ub210VHYvRDV0REE3Q3ZLM1BNUmZKQjdnMEcr?=
 =?utf-8?B?elV5SzgyTUNIbkVJRFZUMWZSRnhIckt3RGlLZWErMHYvT0t6bnFMMWJqeHpv?=
 =?utf-8?B?KzVnRnkxR0lXamxlSVFxNHNuOWNsRUQ0UE82b2oxaDFja2UwQkN1TW9YUWww?=
 =?utf-8?B?UjUrMXFzcDQ3am84QUJLMXdObHQzcWxlbWt4eGVyQlk5SHB3WmtDcENQSGpP?=
 =?utf-8?B?clpUQWlrZC9ONXFOL29lN2cxeTVIZmM2Skl6UjUvUzF4ZlhLNWdZZFpUZFNr?=
 =?utf-8?B?eEFzU3dqZDB1WjdRbjNnSm9MVHdTdTBSWklTcFl4bUJqZ2VmaGpuaWZraWRU?=
 =?utf-8?B?SDN5U1plZTgvN0VZaFJDM2tvMWR0UmpWRWxUZUpHL2VjTWw5eDU5UWlNSFpX?=
 =?utf-8?B?clVBcWdlWDIwZHh0OFBEaW8zdlhVU0VEc2VhbFo0S3RzblB2Ny8zQnZoVDFl?=
 =?utf-8?B?Y1NJK3ZscXFyNDRZVFozaTdqb2hkLzloNDJRdDZUUncwSVpSV29SVDFhTUVK?=
 =?utf-8?B?UndyM2g0R0JsZEdNa3owckJtZGtiY25MOU1qb1JmbW52TXFBUER2QXNZMnBY?=
 =?utf-8?B?Y3lzNGhyUlBWTndxR2VBbC92ZXdzSStsdXFHRlBNZUJqaEwvRTdISmdrd3hr?=
 =?utf-8?B?aGRhQU4xeDZ3SUVrQmZueGlUR0VrWHVYWjZFWFpPOGVnakx4dGxvTGlkK3Yw?=
 =?utf-8?B?WDR3Z2h2dGxCbFF4N0x1d2JOMUtVeXY2VWt1WUlWalFreHBNWUF5UnJTaHQ5?=
 =?utf-8?B?WnRmV1Q5ZHIvU0VySzd4OTVpdzk3bk5BWE5wUit6cUQrRUR0V1VBWVpyb09Z?=
 =?utf-8?B?RWJpZ05RRVVxV2ZtRlFjS0RKSjBMUU1KZ3F0ZVduLzFqeS95Vmo3aEYxa0dM?=
 =?utf-8?B?ekUrWUk4R1Y5R2ZEYTE4cTB4MmFKZ2JxOFB1N0ZMZDJqVEJTN0NRN2xteWor?=
 =?utf-8?B?UmFoT2xqR3pnQUdtNENlTUhxWUxIY2l6RzFLaFU0a25iR2NETXV1NC9qZHF2?=
 =?utf-8?B?a05GK0o0RklsVHA4SUdEa3ZxRkFJMGpES003TzFacnVzQW5BR0M1SDRBUUNI?=
 =?utf-8?B?NGY1QU9lZzVKd0xTV3pkaHNhR1kza240ZXlKKzVLMDM4bzZpaloxT21aMXVi?=
 =?utf-8?B?MTBtdzFzMkRPS2pkMlFvenFETHg5VkdjY1JTaVVybXFCWTZ2YjJiZVB3RWpW?=
 =?utf-8?B?SU9pQ21GcGRxVGJsbXQ4UURYWGVLcS80Y1gyRjZZVy9FeHJURmV1c2J0YVNi?=
 =?utf-8?B?cmY4QzQreVVrRjJBNStGOW1DMjQxSHhMU3kreExpWHpJMWdNRnhSZmJNRTFK?=
 =?utf-8?B?M1dqc2NYM2VQZ29TMkpxRDFqaFUyRkJITGFTcXkxMWVGcmFJV1NpZEgxckJl?=
 =?utf-8?B?VElmdVlsU3RrYTJUektyYUhGOExlQnNSOHZMUzdzbkxZZVhobWtTeStFRFEy?=
 =?utf-8?B?VE8vNFdTbGhMQ0pxeWx4S25TdnJnYkdYeFJ1SlJxRmZydFJldjUyODBJcnNq?=
 =?utf-8?B?U0ZnazlZZEJGSWxick9XbUZvNGZUU01yYmNxWjZpcEdWSWRja09vUi9IcTg0?=
 =?utf-8?B?bDBtVVJURGk2RVRLbkJrcDU5SWN5cDUrQzB6dGhZNktFdWZ3aklsOU82RnFo?=
 =?utf-8?B?Qkg3QjMrRjZCWlR2cEwzeEFXYkl4eHBaWDIveHJOYmZaaDlsTW00bHJYVDlV?=
 =?utf-8?B?ZHhuVlBmM1RBYU1CNXI2N0NiRTlOQ21CS3drd0Y3WVYxb2V6ZzZsTzIyRk9O?=
 =?utf-8?B?UGdKVWlXVldUdmdpSTFBZ3FORFJuaDFhbTJpVDM3S2Exd2lmenp5MysrMDZM?=
 =?utf-8?B?OUFtTzRJK2MvV0VHb1kzeGk0ZzZCaWp3cWp4alFsMFlLVlN4T3VZWEpQRmgr?=
 =?utf-8?B?L3Y5QlBweWpqMWR2aXd4YllSYmdjNnhNWHBna1BteFJVdGQwYnZyb3pXRVZ5?=
 =?utf-8?B?UWtpSnRFeHRycUM1UjZsTHJ1S3NoTlQ4VVU4WW9BczlCYmRuajB5K2pzT1Jm?=
 =?utf-8?B?WVJhZVhlMU9MZmRUM3FXOHJuQlRWc1RyeC9PVjBzR1JFcExUa3RCeTcyU2FN?=
 =?utf-8?B?dEE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 914c7818-aa5a-42db-3888-08db97c57c13
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4820.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2023 04:11:05.2392
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wKxqgFIovlw4d+XScEOkrBeGQPUoGEiGVENdRB2dEQVnvXDPy9sY3BOMSMJi8EDl9aSKU87S5ABXXSJwi3Owbw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB6703
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,
        RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 8/8/2023 10:43 AM, Yu Zhao wrote:
> On Mon, Aug 7, 2023 at 8:10 PM Yin Fengwei <fengwei.yin@intel.com> wrote:
>>
>> In madvise_cold_or_pageout_pte_range() and madvise_free_pte_range(),
>> folio_mapcount() is used to check whether the folio is shared. But it's
>> not correct as folio_mapcount() returns total mapcount of large folio.
>>
>> Use folio_estimated_sharers() here as the estimated number is enough.
>>
>>
>> This patchset will fix the cases:
>> User space application call madvise() with MADV_FREE, MADV_COLD and
>> MADV_PAGEOUT for specific address range. There are THP mapped to the
>> range. Without the patchset, the THP is skipped. With the patch, the
>> THP will be split and handled accordingly.
>>
>> David reported the cow self test skip some cases because of
>> MADV_PAGEOUT skip THP:
>> https://lore.kernel.org/linux-mm/9e92e42d-488f-47db-ac9d-75b24cd0d037@intel.com/T/#mbf0f2ec7fbe45da47526de1d7036183981691e81
>> and I confirmed this patchset make it work again.
>>
>>
>> Changelog from v1:
>>   - Avoid two Fixes tags make backport harder. Thank Andrew for pointing
>>     this out.
>>
>>   - Add note section to mention this is a temporary fix which is fine
>>     to reduce user-visble effects. For long term fix, we should wait for
>>     David's solution. Thank Ryan and David for pointing this out.
>>
>>   - Spell user-visible effects out. Then people could decide whether
>>     these patches are necessary for stable branch. Thank Andrew for
>>     pointing this out.
> 
> LGTM, thank you.
Thanks a lot for looking at this patchset.


Regards
Yin, Fengwei