Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <5bc1e871-0788-18ba-6a01-7ce8c773eff5@suse.com>
Date:   Tue, 8 Aug 2023 14:15:15 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net-next 03/10] mlx4: Replace the mlx4_interface.event
 callback with a notifier
Content-Language: en-US
To:     Simon Horman <horms@kernel.org>
Cc:     tariqt@nvidia.com, yishaih@nvidia.com, leon@kernel.org,
        davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, jgg@ziepe.ca, netdev@vger.kernel.org,
        linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20230804150527.6117-1-petr.pavlu@suse.com>
 <20230804150527.6117-4-petr.pavlu@suse.com> <ZND4iQMbv5LWNaZA@vergenet.net>
From:   Petr Pavlu <petr.pavlu@suse.com>
In-Reply-To: <ZND4iQMbv5LWNaZA@vergenet.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aGV1b3ZBOFNKSUVIMnRyUHE4aWpVcE5GN0lMZXU4T05VZ3ZlaWxUaEhmb3BT?=
 =?utf-8?B?OWV5d3pLQ2RZMWxrM0p4dFhNbkZaMGhOeEo3c3plNWFaZHZPWm1sL2JodEo2?=
 =?utf-8?B?Y3hXT2ZWYWVqYytRNWhhOGVSd1NkblJhUFpJL0tPMWY5dDVCM3VqMzdVWURI?=
 =?utf-8?B?eXVMM3VXYnBpR1FSTGs4eVNQcC9ZTnVxL1hRaElmMDJSSXFpNXFkY1JCZmRr?=
 =?utf-8?B?RWRMSW5JTHM5c0d0ZTl6WUxHTmpLcHFUYlNzVk41WlBXd3FBZ3M5R0o2Tm9S?=
 =?utf-8?B?Rjl5SHFQQXpkYmdsVlZjWlZQS0RZcGYzOXhWTExoRzcrRytuZ1JsQU0vTExY?=
 =?utf-8?B?WUdjaUlhNGIvNzA5MlNoRmE1YUFKWVJ1SVpQU1NtdXFXUC83a3pBUHcvY3Bt?=
 =?utf-8?B?SGMrczg3bGJ4ajVpVng2RTNhUlJUWURkWmJvQzBnWlFuUHd0ZzRmdDNZQVN3?=
 =?utf-8?B?N2p4MytQbi9Vb0E4OC9IdndPa0NYUElDYTJJWDFsZUdoWllwdnBka3VEeE9L?=
 =?utf-8?B?QVRUT1YraDVjcjM0emJwbkF5dGpNUmp5RmpSeUZqa2VGUGtGR015ZFVQZkkr?=
 =?utf-8?B?RGQrMDFDc2ViZy9KNVF5Y2VQdkxURGtDM2o0anVoM1NKdE1xUjNwTlRtV2ZR?=
 =?utf-8?B?RjVhSmYyMXNhNFJCaDVmeEhPTGRxa2xTVVk4ZUZFd1duVGRUV2ZJVHJ5alc0?=
 =?utf-8?B?RW1QUDdQZU94T0lXQUJEVWpYQ0VBZVVTS1paVzRpbEtISWIwelRWSUoxaS85?=
 =?utf-8?B?dGFOVC8vR3l1a1NHZVNtck4zQk15VkFIVTg2dnpOREhhb2hKbTcwUHBMYXdJ?=
 =?utf-8?B?WHpMZVp4SGtzUk1zVUYyWWtrYXhObmhERkk2M0U2NGVIa2lmOWxmQjBEbm5F?=
 =?utf-8?B?cFYzL0loMjhSbHh0ck9LSGJzSW9qd3dzSDIwV0xMbmkyNjI3VjhPdFlVUVpR?=
 =?utf-8?B?c29HL2xZMnhTZko3T2NtUlBTZ1NsendNYVNrR0wvRmxKSHRLSXVqcGlneFJw?=
 =?utf-8?B?NEQ5aFVoVWwxdW9tS0RFOVh2NjYyQk5laFJtNFJPSFg5SEw1dnJnWmI3M3Fo?=
 =?utf-8?B?WnZ0MkNXVDc5QUR1QU8rMXQ5ZFNSbi9WZGY0SUdoUmhvWWM3ckw3L0grTVNR?=
 =?utf-8?B?RkF3VUFiZ0VvWUU5TC90bmk1Z29kSG5jM1hSZU5VYkU3UFZVcGVBT1ZORW4v?=
 =?utf-8?B?N3pkNzc1UFh2U2JZdjYwZTlsSFQ4eE5BWDhobnlKRWFINlY0SDI4cFIwTGR1?=
 =?utf-8?B?SkswbDRlS1FheDNEOWROUklma3VyTDh6UGExYXBvSFJHckh3RWpFYjdadkds?=
 =?utf-8?B?aE1jcnlBRDFyRmwyL096WlNaWWFQMnZxWmRMNXpwcU8xRnp1OUp2R2RUR1JD?=
 =?utf-8?B?cVVBSzIyOW00bGkwWlVleDllWXV1ZXlpdzAxeGxCNW0rdFZCcGhpanFSb1hV?=
 =?utf-8?B?ek1aLzVsaHNUbzZ5bFUvSk5SRXkrVmZmRFE0NWdzMzlHTk1rcmJibXh1aXdv?=
 =?utf-8?B?c0lCSjJrRmNYcCtVTWFsRE14a3NrMWsramFCcXBSbExiRHpqTGdsYmlTdTN2?=
 =?utf-8?B?UTlYT1pycWhNaGJpSDVDZnBwVGdGSlZnckRGd28rN29jSVo3a0puOHoremVW?=
 =?utf-8?B?V0ExRjhhS0lMK0dTSnd4bGRaKzB1OTNJTFpGbXpibTVmaFhTOWRIektMZWkz?=
 =?utf-8?B?V3BpSmRwYVF1ZmJCTzhtU093d1B5N2VXUWtOeE5hSTdsREwxL3l2QTVCS0ZH?=
 =?utf-8?B?WmdLOEJpandDWTVvQ0N0TGltcjNIbXZodmgwNzVsNUQzcmx3bW1xaUVDRUpW?=
 =?utf-8?B?K0hyZDA1SGVuWUdnUitFckpOV0ZjbURrZkJpZTh3ZWtCcjliTC9xUWd4R2F5?=
 =?utf-8?B?Y2RQSEh1NU9vMUExSDM3akR3Z2NTMVhVSml5M2UrN1ZpbVNITk5jdG1MMi9E?=
 =?utf-8?B?T21QbEtWN05WQXdRL2xkL0pVUytkVkpQcFBPT1JSVWNicEp0alNvL05PVC82?=
 =?utf-8?B?REJEVzd3cVV1SS9rOXRXbnJpN2l4VWlpNmtaYWFQckVSc1FHbjVxMU42UTZW?=
 =?utf-8?B?TWZzYlNHNFpZaWVkZXY0MllYWnZLb1lhcTRYZXpaM1RxZ1RyeWpKcWhrQWFL?=
 =?utf-8?Q?5DTD7kRYPtYw0G7c39kYNe5SO?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a423ead7-1183-42f5-7438-08db980920b2
X-MS-Exchange-CrossTenant-AuthSource: AM0PR0402MB3395.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2023 12:15:17.4969
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +gJ7UTwGwHF7Zyty400BcmDToEOgr1oUQ959Zj6jgM31s59AR39n0eVrtapZwXjErYUgF89cFE0VH+LiLdFL5Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7403
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 8/7/23 15:58, Simon Horman wrote:
> On Fri, Aug 04, 2023 at 05:05:20PM +0200, Petr Pavlu wrote:
> 
> ...
> 
>> diff --git a/drivers/net/ethernet/mellanox/mlx4/en_main.c b/drivers/net/ethernet/mellanox/mlx4/en_main.c
> 
> ...
> 
>> @@ -326,6 +333,11 @@ static void *mlx4_en_add(struct mlx4_dev *dev)
>>  	mutex_init(&mdev->state_lock);
>>  	mdev->device_up = true;
>>  
>> +	/* register mlx4 core notifier */
>> +	mdev->mlx_nb.notifier_call = mlx4_en_event;
>> +	err = mlx4_register_event_notifier(dev, &mdev->mlx_nb);
> 
> Hi Petr.
> 
> This fails to build because err isn't declared in this context.

Ah, the err variable in mlx4_en_add() is only defined by a subsequent
patch in the series. I'll fix it in v2.

Thanks,
Petr